TODO: don't add token-delete endpoint on non-integrated auth?

stlaz · stlaz · commit d7924922fe11 · 2024-01-09T15:29:04.000+01:00
diff --git a/pkg/server/server.go b/pkg/server/server.go
@@ -285,6 +285,7 @@ func (s *Server) HTTPHandler() http.Handler {
 		handleFunc(authLogoutEndpoint, allowMethod(http.MethodPost, s.handleLogout))
 		handleFunc(AuthLoginCallbackEndpoint, s.Authenticator.CallbackFunc(fn))
 		handle(requestTokenEndpoint, authHandler(s.handleClusterTokenURL))
+		// TODO: only add the following in case the auth type is openshift?
 		handleFunc(deleteOpenshiftTokenEndpoint, allowMethod(http.MethodPost, authHandlerWithUser(s.handleOpenShiftTokenDeletion)))
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -285,6 +285,7 @@ func (s *Server) HTTPHandler() http.Handler {`
`285`	`285`	`handleFunc(authLogoutEndpoint, allowMethod(http.MethodPost, s.handleLogout))`
`286`	`286`	`handleFunc(AuthLoginCallbackEndpoint, s.Authenticator.CallbackFunc(fn))`
`287`	`287`	`handle(requestTokenEndpoint, authHandler(s.handleClusterTokenURL))`
	`288`	`+ // TODO: only add the following in case the auth type is openshift?`
`288`	`289`	`handleFunc(deleteOpenshiftTokenEndpoint, allowMethod(http.MethodPost, authHandlerWithUser(s.handleOpenShiftTokenDeletion)))`
`289`	`290`	`}`
`290`	`291`