terminal: use username if uid is not present

stlaz · stlaz · commit e87dc6fc852d · 2024-01-16T14:39:49.000+01:00
diff --git a/pkg/terminal/proxy.go b/pkg/terminal/proxy.go
@@ -125,11 +125,7 @@ func (p *Proxy) HandleProxy(user *auth.User, w http.ResponseWriter, r *http.Requ
 
 		userId = string(userInfo.Status.UserInfo.UID) // TODO: are we cool rewriting this here?
 		if userId == "" {
-			// uid is missing. it must be kube:admin
-			if userInfo.Status.UserInfo.Username != "kube:admin" {
-				http.Error(w, "User must have UID to proceed authorization", http.StatusInternalServerError)
-				return
-			}
+			userId = userInfo.Status.UserInfo.Username
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -125,11 +125,7 @@ func (p Proxy) HandleProxy(user auth.User, w http.ResponseWriter, r *http.Requ`
`125`	`125`
`126`	`126`	`userId = string(userInfo.Status.UserInfo.UID) // TODO: are we cool rewriting this here?`
`127`	`127`	`if userId == "" {`
`128`		`- // uid is missing. it must be kube:admin`
`129`		`- if userInfo.Status.UserInfo.Username != "kube:admin" {`
`130`		`- http.Error(w, "User must have UID to proceed authorization", http.StatusInternalServerError)`
`131`		`- return`
`132`		`- }`
	`128`	`+ userId = userInfo.Status.UserInfo.Username`
`133`	`129`	`}`
`134`	`130`	`}`
`135`	`131`