Create static secret to replace sycretsync

 - Previously the csi-manila-secrets secret in the
 openshift-manila-csi-driver namespace required secretsync.go to
 generate the secret dynamically. Since we are changing how the
 authentication occurs for the manila driver that process can be
 replaced with a static secret asset.

Author: dkokkino

assets/overlays/openstack-manila/base/config_secret.yaml

@@ -0,0 +1,9 @@
+apiVersion: v1
+kind: Secret
+metadata:
+  name: csi-manila-secrets
+  namespace: openshift-manila-csi-driver
+stringData:
+  os-cloud: openstack
+  os-cloudsFile: /etc/openstack/clouds.yaml
+  os-useClouds: "true"

assets/overlays/openstack-manila/generated/hypershift/config_secret.yaml

@@ -0,0 +1,15 @@
+# Generated file. Do not edit. Update using "make update".
+#
+# Loaded from overlays/openstack-manila/base/config_secret.yaml
+#
+#
+
+apiVersion: v1
+kind: Secret
+metadata:
+  name: csi-manila-secrets
+  namespace: openshift-manila-csi-driver
+stringData:
+  os-cloud: openstack
+  os-cloudsFile: /etc/openstack/clouds.yaml
+  os-useClouds: "true"

assets/overlays/openstack-manila/generated/hypershift/manifests.yaml

@@ -5,6 +5,7 @@ controllerStaticAssetNames:
 - controller_sa.yaml
 - service.yaml
 guestStaticAssetNames:
+- config_secret.yaml
 - csidriver.yaml
 - lease_leader_election_binding.yaml
 - lease_leader_election_role.yaml

assets/overlays/openstack-manila/generated/standalone/config_secret.yaml

@@ -0,0 +1,15 @@
+# Generated file. Do not edit. Update using "make update".
+#
+# Loaded from overlays/openstack-manila/base/config_secret.yaml
+#
+#
+
+apiVersion: v1
+kind: Secret
+metadata:
+  name: csi-manila-secrets
+  namespace: openshift-manila-csi-driver
+stringData:
+  os-cloud: openstack
+  os-cloudsFile: /etc/openstack/clouds.yaml
+  os-useClouds: "true"

assets/overlays/openstack-manila/generated/standalone/manifests.yaml

@@ -10,6 +10,7 @@ controllerStaticAssetNames:
 - service.yaml
 - servicemonitor.yaml
 guestStaticAssetNames:
+- config_secret.yaml
 - csidriver.yaml
 - lease_leader_election_binding.yaml
 - lease_leader_election_role.yaml

pkg/driver/openstack-manila/openstack_manila.go

@@ -16,7 +16,6 @@ import (
 	"github.com/openshift/csi-operator/pkg/driver/common/operator"
 	"github.com/openshift/csi-operator/pkg/generator"
 	"github.com/openshift/csi-operator/pkg/openstack-manila/client"
-	"github.com/openshift/csi-operator/pkg/openstack-manila/secret"
 	"github.com/openshift/csi-operator/pkg/openstack-manila/util"
 	"github.com/openshift/csi-operator/pkg/operator/config"
 	"github.com/openshift/library-go/pkg/controller/factory"
@@ -98,6 +97,7 @@ func GetOpenStackManilaGeneratorConfig() *generator.CSIDriverGeneratorConfig {
 				"overlays/openstack-manila/base/csidriver.yaml",
 				"overlays/openstack-manila/base/volumesnapshotclass.yaml",
 				"overlays/openstack-manila/base/node_nfs.yaml",
+				"overlays/openstack-manila/base/config_secret.yaml",
 			),
 			AssetPatches: commongenerator.DefaultGuestAssetPatches,
 		},
@@ -187,11 +187,7 @@ func GetOpenStackManilaOperatorControllerConfig(ctx context.Context, flavour gen
 	}
 
 	cfg.PreconditionInformers = []factory.Informer{c.GetCSIDriverInformer().Informer(), c.GetStorageClassInformer().Informer()}
-	secretSyncer, err := createSecretSyncer(c)
-	if err != nil {
-		return nil, err
-	}
-	cfg.ExtraControlPlaneControllers = append(cfg.ExtraControlPlaneControllers, configMapSyncer, secretSyncer, nfsCSIDriverController)
+	cfg.ExtraControlPlaneControllers = append(cfg.ExtraControlPlaneControllers, configMapSyncer, nfsCSIDriverController)
 
 	cfg.ExtraReplacementsFunc = func() []string {
 		pairs := []string{}
@@ -324,19 +320,6 @@ func withCABundleDaemonSetHook(c *clients.Clients) (csidrivernodeservicecontroll
 	return hook, informers
 }
 
-func createSecretSyncer(c *clients.Clients) (factory.Controller, error) {
-	secretSyncController := secret.NewSecretSyncController(
-		c.OperatorClient,
-		c.KubeClient,
-		c.ControlPlaneKubeInformers,
-		c.ControlPlaneNamespace,
-		c.GuestNamespace,
-		resyncInterval,
-		c.EventRecorder)
-
-	return secretSyncController, nil
-}
-
 func createConfigMapSyncer(c *clients.Clients) (factory.Controller, error) {
 	// sync config map with OpenStack CA certificate to the operand namespace,
 	// so the driver can get it as a ConfigMap volume.