fix(azure): add resource group scoping and fix Key Vault naming

Add --resource-group parameter to network NSG and VNet list commands the Azure CLI now requires --resource-group for 'az network vnet list', which fixes issue where GetVnetID becomes empty on basic HC creation

Also updated Key Vault name from "${PREFIX}" to "${PREFIX}-kv" so that the KV name isn't just a prefix

Author: georgelipceanu

contrib/managed-azure/create_basic_hosted_cluster.sh

@@ -42,7 +42,7 @@ az group create --name "${CUSTOMER_NSG_RG_NAME}" --location ${LOCATION}
 az network nsg create --resource-group "${CUSTOMER_NSG_RG_NAME}" --name "${CUSTOMER_NSG}"
 
 # Get customer nsg ID
-GetNsgID=$(az network nsg list --query "[?name=='${CUSTOMER_NSG}'].id" -o tsv)
+GetNsgID=$(az network nsg list --resource-group "${CUSTOMER_NSG_RG_NAME}" --query "[?name=='${CUSTOMER_NSG}'].id" -o tsv)
 
 # Create customer vnet in customer resource group
 az network vnet create \
@@ -54,7 +54,7 @@ az network vnet create \
     --nsg "${GetNsgID}"
 
 # Get customer vnet ID
-GetVnetID=$(az network vnet list --query "[?name=='${CUSTOMER_VNET_NAME}'].id" -o tsv)
+GetVnetID=$(az network vnet list --resource-group "${CUSTOMER_VNET_RG_NAME}" --query "[?name=='${CUSTOMER_VNET_NAME}'].id" -o tsv)
 
 # Get customer subnet ID
 GetSubnetID=$(az network vnet subnet show --vnet-name "${CUSTOMER_VNET_NAME}" --name "${CUSTOMER_VNET_SUBNET1}" --resource-group "${CUSTOMER_VNET_RG_NAME}" --query id --output tsv)

contrib/managed-azure/setup_MIv3_kv.sh

@@ -23,7 +23,7 @@ LOCATION=${LOCATION:?"Provide location"}
 CP_OUTPUT_FILE=${CP_OUTPUT_FILE:?"Provide cloud provider output file path"}
 
 # Local.
-KV_NAME="${PREFIX}"
+KV_NAME="${PREFIX}-kv"
 AZURE_DISK_SP_NAME="azure-disk-$PREFIX"
 AZURE_FILE_SP_NAME="azure-file-$PREFIX"