Skip to content

Commit a101e66

Browse files
Merge pull request #8686 from dustman9000/fix/metrics-forwarder-workload-annotation
OCPBUGS-87217: fix: add CPU partitioning workload annotation to control-plane-metrics-forwarder
2 parents ffa9791 + ed4fa90 commit a101e66

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

control-plane-operator/hostedclusterconfigoperator/controllers/resources/monitoring/metricsforwarder.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@ func ReconcileMetricsForwarderDeployment(deployment *appsv1.Deployment, haproxyI
3232
ObjectMeta: metav1.ObjectMeta{
3333
Labels: labels,
3434
Annotations: map[string]string{
35-
"metrics-forwarder-config-checksum": configHash,
35+
"metrics-forwarder-config-checksum": configHash,
36+
"target.workload.openshift.io/management": `{"effect": "PreferredDuringScheduling"}`,
3637
},
3738
},
3839
Spec: corev1.PodSpec{

control-plane-operator/hostedclusterconfigoperator/controllers/resources/monitoring/metricsforwarder_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ func TestReconcileMetricsForwarderDeployment(t *testing.T) {
4040
err := ReconcileMetricsForwarderDeployment(deployment, tt.image, tt.configHash)
4141
g.Expect(err).ToNot(HaveOccurred())
4242
g.Expect(deployment.Spec.Template.Annotations).To(HaveKeyWithValue("metrics-forwarder-config-checksum", tt.configHash))
43+
g.Expect(deployment.Spec.Template.Annotations).To(HaveKeyWithValue("target.workload.openshift.io/management", `{"effect": "PreferredDuringScheduling"}`))
4344
g.Expect(deployment.Spec.Template.Spec.Containers).To(HaveLen(1))
4445
g.Expect(deployment.Spec.Template.Spec.Containers[0].Image).To(Equal(tt.image))
4546
})

0 commit comments

Comments
 (0)