NO-JIRA: fix(ci): use PR base SHA for api-lint diff in GHA

[bryan-cox]

Summary

• Set PULL_BASE_SHA to github.event.pull_request.base.sha in the lint GHA workflow, matching the pattern already used by gitlint.yaml
• Without this, the Makefile defaults PULL_BASE_SHA to origin/main, causing api-lint to diff release-4.22 PRs against main instead of the target branch
• This broke all release-4.22 lint runs after PR CNTRLPLANE-3160: Drop AutoNodeKarpenter feature gate and promote EC2NodeClass to v1 #8166 (merged Apr 30) changed AutoNode/Karpenter fields on main — every lint run since then has failed:
  • PR [release-4.22] OCPBUGS-84841: fix(ingress): set FIPS_ENABLED env var on ingress operator #8388: 2 runs, both failed
  • PR OCPBUGS-84939: [release-4.22] add CP pull-secret watches for in-place propagation #8408: 3 runs, all failed

Root cause

The api-lint target runs --new-from-rev=${PULL_BASE_SHA}. The Makefile defaults:

UPSTREAM_REMOTE ?= $(shell git remote -v | grep 'openshift/hypershift.*fetch' | head -1 | cut -f1)
PULL_BASE_SHA ?= $(if $(UPSTREAM_REMOTE),$(UPSTREAM_REMOTE)/main,main)

In GHA, UPSTREAM_REMOTE resolves to origin, so PULL_BASE_SHA becomes origin/main. For release-4.22 PRs, the diff sees divergent lines as "new" and flags them.

Test plan

• This PR's own lint check should pass (it targets release-4.22, so api-lint will diff against the release-4.22 base SHA instead of origin/main)
• Verify PRs targeting main still work (github.event.pull_request.base.sha resolves to main's HEAD for those PRs)

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: bda105ce-9d6a-47f7-aee8-cb616b7904ea

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [bryan-cox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[enxebre]

/lgtm
/verified by tests @enxebre

[openshift-ci-robot]

@enxebre: This PR has been marked as verified by tests @enxebre.

Details

In response to this:

/lgtm
/verified by tests @enxebre

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@bryan-cox: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

• Set PULL_BASE_SHA to github.event.pull_request.base.sha in the lint GHA workflow, matching the pattern already used by gitlint.yaml
• Without this, the Makefile defaults PULL_BASE_SHA to origin/main, causing api-lint to diff release-4.22 PRs against main instead of the target branch
• This broke all release-4.22 lint runs after PR CNTRLPLANE-3160: Drop AutoNodeKarpenter feature gate and promote EC2NodeClass to v1 #8166 (merged Apr 30) changed AutoNode/Karpenter fields on main — every lint run since then has failed:
• PR [release-4.22] OCPBUGS-84841: fix(ingress): set FIPS_ENABLED env var on ingress operator #8388: 2 runs, both failed
• PR OCPBUGS-84939: [release-4.22] add CP pull-secret watches for in-place propagation #8408: 3 runs, all failed

Root cause

The api-lint target runs --new-from-rev=${PULL_BASE_SHA}. The Makefile defaults:

UPSTREAM_REMOTE ?= $(shell git remote -v | grep 'openshift/hypershift.*fetch' | head -1 | cut -f1)
PULL_BASE_SHA ?= $(if $(UPSTREAM_REMOTE),$(UPSTREAM_REMOTE)/main,main)

In GHA, UPSTREAM_REMOTE resolves to origin, so PULL_BASE_SHA becomes origin/main. For release-4.22 PRs, the diff sees divergent lines as "new" and flags them.

Test plan

• This PR's own lint check should pass (it targets release-4.22, so api-lint will diff against the release-4.22 base SHA instead of origin/main)
• Verify PRs targeting main still work (github.event.pull_request.base.sha resolves to main's HEAD for those PRs)

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[enxebre]

/lgtm