Skip to content

ACM-33601: use the latest ubi9 nginx image#8432

Open
rokej wants to merge 1 commit intoopenshift:mainfrom
rokej:ACM-33601
Open

ACM-33601: use the latest ubi9 nginx image#8432
rokej wants to merge 1 commit intoopenshift:mainfrom
rokej:ACM-33601

Conversation

@rokej
Copy link
Copy Markdown
Contributor

@rokej rokej commented May 5, 2026

What this PR does / why we need it:

It is recommended to use the latest instead of registry.redhat.io/ubi9/nginx-124:1-1767745334 so that the build always stays current with security fixes.

Which issue(s) this PR fixes:

Fixes

Special notes for your reviewer:

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Summary by CodeRabbit

  • Chores
    • Updated container base image to the latest version to ensure current dependencies and improvements are included.

Signed-off-by: Roke Jung <roke@redhat.com>
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 5, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 5, 2026

@rokej: This pull request references ACM-33601 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

It is recommended to use the latest instead of registry.redhat.io/ubi9/nginx-124:1-1767745334 so that the build always stays current with security fixes.

Which issue(s) this PR fixes:

Fixes

Special notes for your reviewer:

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 361b89a9-52ed-44bf-9c4c-6400baa03c92

📥 Commits

Reviewing files that changed from the base of the PR and between 3c3ccfc and 9e86bee.

📒 Files selected for processing (1)
  • Containerfile.cli

📝 Walkthrough

Walkthrough

The base image reference in Containerfile.cli was updated on line 22. The FROM instruction now specifies registry.redhat.io/ubi9/nginx-124:latest instead of the previously pinned version tag registry.redhat.io/ubi9/nginx-124:1-1767745334. All other build configuration, including subsequent stages, copy instructions, and metadata, remains unchanged.


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Stable And Deterministic Test Names ❌ Error PR contains Ginkgo test names with dynamic values that change between runs. Multiple test titles use fmt.Sprintf with workload.Name variable, violating stable test name requirement. Update test titles to use static descriptive strings. Move dynamic values (workload.Name) to test bodies for assertions. Replace fmt.Sprintf patterns with static titles.
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the container base image from a specific version tag to 'latest' for the ubi9 nginx image.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Test Structure And Quality ✅ Passed PR modifies CI configuration files (Containerfile.cli), not test code. The repository uses standard Go testing framework, not Ginkgo, so the custom check on Ginkgo test quality is not applicable.
Microshift Test Compatibility ✅ Passed PR does not add any Ginkgo e2e tests. It only updates a container base image in Containerfile.cli. The MicroShift Test Compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR only updates a Containerfile image tag and does not add any new Ginkgo e2e tests. The SNO Test Compatibility check only applies when new Ginkgo tests are added, so it is not applicable here.
Topology-Aware Scheduling Compatibility ✅ Passed PR only updates container image tag in Containerfile.cli. No deployment manifests, operators, or scheduling constraints are modified, making this check not applicable.
Ote Binary Stdout Contract ✅ Passed Check not applicable. PR only modifies Containerfile.cli (container config), changing base image tag. No Go code, stdout operations, or process setup code modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only modifies Containerfile.cli to update a container image version. No Ginkgo e2e tests were added. The check applies only to new test additions and is not applicable here.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@rokej
Copy link
Copy Markdown
Contributor Author

rokej commented May 5, 2026

/area ci-tooling

@openshift-ci openshift-ci Bot added area/ci-tooling Indicates the PR includes changes for CI or tooling and removed do-not-merge/needs-area labels May 5, 2026
@openshift-ci openshift-ci Bot requested review from clebs and sdminonne May 5, 2026 21:13
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rokej
Once this PR has been reviewed and has the lgtm label, please assign sjenning for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.42%. Comparing base (3c3ccfc) to head (9e86bee).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8432   +/-   ##
=======================================
  Coverage   37.42%   37.42%           
=======================================
  Files         751      751           
  Lines       91853    91853           
=======================================
  Hits        34376    34376           
  Misses      54840    54840           
  Partials     2637     2637           
Flag Coverage Δ
cmd-support 32.56% <ø> (ø)
cpo-hostedcontrolplane 36.48% <ø> (ø)
cpo-other 37.73% <ø> (ø)
hypershift-operator 47.93% <ø> (ø)
other 27.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 5, 2026

@rokej: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rokej
Copy link
Copy Markdown
Contributor Author

rokej commented May 5, 2026

/verified by @rokej

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label May 5, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@rokej: This PR has been marked as verified by @rokej.

Details

In response to this:

/verified by @rokej

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@clebs
Copy link
Copy Markdown
Member

clebs commented May 6, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aks
/test e2e-aws
/test e2e-aws-upgrade-hypershift-operator
/test e2e-azure-self-managed
/test e2e-kubevirt-aws-ovn-reduced
/test e2e-v2-aws

@cwbotbot
Copy link
Copy Markdown

cwbotbot commented May 6, 2026

Test Results

e2e-aws

e2e-aks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci-tooling Indicates the PR includes changes for CI or tooling jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants