OCPBUGS-90085: Fix NodePool reconciliation failure when updating mirrored immutable ConfigMaps by vsolanki12 · Pull Request #8813 · openshift/hypershift

vsolanki12 · 2026-06-23T12:45:51Z

Backport of #8543 to release-4.20.

Adapted cherry-pick to use supportutil.DeleteIfNeededWithPredicate and supportutil.ShortenName instead of k8sutil/netutil which don't exist on the release branch (they were extracted from support/util in a later refactor on main).

Mirrored ConfigMaps created by the NodePool NTO reconciler were set with immutable=true, which prevented Kubernetes from accepting in-place updates when the source ConfigMap data changed. This caused NodePools sharing the same kubelet ConfigMap to get stuck in UpdatingConfig=True with "field is immutable" errors. Remove the immutable flag from mutateMirroredConfig and add a migration helper that uses DeleteIfNeededWithPredicate to safely delete existing immutable mirrored ConfigMaps before CreateOrUpdate recreates them as mutable. The predicate guards deletion to only ConfigMaps with the nto-mirrored-config label belonging to the current NodePool. Signed-off-by: Vimal Solanki <vsolanki@redhat.com>

openshift-merge-bot · 2026-06-23T12:45:54Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot · 2026-06-23T12:45:58Z

@vsolanki12: This pull request references Jira Issue OCPBUGS-85778, which is invalid:

expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "5.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-85778 to depend on a bug targeting a version in 4.21.0, 4.21.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Backport of #8543 to release-4.20.

Adapted cherry-pick to use supportutil.DeleteIfNeededWithPredicate and supportutil.ShortenName instead of k8sutil/netutil which don't exist on the release branch (they were extracted from support/util in a later refactor on main).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-06-23T12:46:01Z

Caution

Review failed

An error occurred during the review process. Please try again later.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

rtheis · 2026-06-23T14:27:21Z

/uncc @rtheis

vsolanki12 · 2026-06-26T03:16:05Z

/retest

openshift-ci · 2026-06-26T05:55:06Z

@vsolanki12: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-06-26T07:54:53Z

@vsolanki12: This pull request references Jira Issue OCPBUGS-90085, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected dependent Jira Issue OCPBUGS-90084 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Backport of #8543 to release-4.20.

Adapted cherry-pick to use supportutil.DeleteIfNeededWithPredicate and supportutil.ShortenName instead of k8sutil/netutil which don't exist on the release branch (they were extracted from support/util in a later refactor on main).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

vsolanki12 · 2026-06-26T08:03:22Z

/jira refresh

openshift-ci-robot · 2026-06-26T08:03:27Z

@vsolanki12: This pull request references Jira Issue OCPBUGS-90085, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected dependent Jira Issue OCPBUGS-90084 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

vsolanki12 · 2026-06-26T08:08:54Z

/jira refresh

openshift-ci-robot · 2026-06-26T08:08:59Z

@vsolanki12: This pull request references Jira Issue OCPBUGS-90085, which is invalid:

expected dependent Jira Issue OCPBUGS-90084 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

vsolanki12 · 2026-06-26T10:41:05Z

/cc @jparrill @csrwng

jparrill · 2026-07-01T15:04:43Z

/approve

openshift-ci · 2026-07-01T15:06:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill, vsolanki12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jparrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

enxebre · 2026-07-09T09:00:02Z

/lgtm

openshift-ci Bot added the do-not-merge/needs-area label Jun 23, 2026

openshift-ci Bot requested review from rtheis and sjenning June 23, 2026 12:47

openshift-ci Bot added area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels Jun 23, 2026

vsolanki12 mentioned this pull request Jun 23, 2026

[release-4.20] OCPBUGS-90085: Fix NodePool reconciliation failure when updating mirrored immutable ConfigMaps #8765

Closed

openshift-ci Bot removed the request for review from rtheis June 23, 2026 14:27

vsolanki12 changed the title ~~OCPBUGS-85778: Fix NodePool reconciliation failure when updating mirrored immutable ConfigMaps~~ OCPBUGS-90085: Fix NodePool reconciliation failure when updating mirrored immutable ConfigMaps Jun 26, 2026

openshift-ci Bot requested review from csrwng and jparrill June 26, 2026 10:41

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2026

enxebre added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 9, 2026

openshift-ci Bot assigned enxebre Jul 9, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2026

Uh oh!

Conversation

vsolanki12 commented Jun 23, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 23, 2026

Uh oh!

openshift-ci-robot commented Jun 23, 2026

Uh oh!

coderabbitai Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Uh oh!

rtheis commented Jun 23, 2026

Uh oh!

vsolanki12 commented Jun 26, 2026

Uh oh!

openshift-ci Bot commented Jun 26, 2026

Uh oh!

openshift-ci-robot commented Jun 26, 2026

Uh oh!

vsolanki12 commented Jun 26, 2026

Uh oh!

openshift-ci-robot commented Jun 26, 2026

Uh oh!

vsolanki12 commented Jun 26, 2026

Uh oh!

openshift-ci-robot commented Jun 26, 2026

Uh oh!

vsolanki12 commented Jun 26, 2026

Uh oh!

jparrill commented Jul 1, 2026

Uh oh!

openshift-ci Bot commented Jul 1, 2026

Uh oh!

enxebre commented Jul 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coderabbitai Bot commented Jun 23, 2026 •

edited

Loading