Use CAPI featuregate for CAPI aws worker machinesets

This removes use of:
* FeatureGateClusterAPIControlPlaneInstall because it is not implemented
  in either installer or CPMS.
* FeatureGateClusterAPIComputeInstall replaced by
  FeatureGateClusterAPIMachineManagementAWS and scoped to AWS only, as
  that is the only platform where it is implemented

The effect of this change is that installer-created worker machinesets
will use CAPI as soon as platform support is promoted.

Also updates the tests to use the feature gates explicitly instead of
assuming inclusion in a particular feature set.

Author: mdbooth

pkg/types/defaults/machinepools.go

@@ -40,18 +40,11 @@ func SetMachinePoolDefaults(p *types.MachinePool, platform *types.Platform, fgat
 		}
 	}
 
-	// Set management to ClusterAPI if the appropriate feature gate is enabled and management is unspecified
-	if p.Management == "" {
-		if p.Name == types.MachinePoolControlPlaneRoleName && fgates.Enabled(features.FeatureGateClusterAPIControlPlaneInstall) {
-			p.Management = types.ClusterAPI
-		}
-		if p.Name == types.MachinePoolComputeRoleName && fgates.Enabled(features.FeatureGateClusterAPIComputeInstall) {
-			p.Management = types.ClusterAPI
-		}
-	}
-
 	switch platform.Name() {
 	case aws.Name:
+		if p.Management == "" && p.Name == types.MachinePoolComputeRoleName && fgates.Enabled(features.FeatureGateClusterAPIMachineManagementAWS) {
+			p.Management = types.ClusterAPI
+		}
 		if p.Platform.AWS == nil && platform.AWS.DefaultMachinePlatform != nil {
 			p.Platform.AWS = &aws.MachinePool{}
 		}

pkg/types/defaults/machinepools_test.go

@@ -7,7 +7,8 @@ import (
 
 	configv1 "github.com/openshift/api/config/v1"
 	"github.com/openshift/installer/pkg/types"
-	"github.com/openshift/installer/pkg/types/gcp"
+	"github.com/openshift/installer/pkg/types/aws"
+	gcp "github.com/openshift/installer/pkg/types/gcp"
 )
 
 func defaultMachinePoolWithReplicaCount(name string, replicaCount int) *types.MachinePool {
@@ -144,61 +145,57 @@ func TestSetMahcinePoolDefaults(t *testing.T) {
 }
 
 func TestSetMachinePoolDefaultsWithFeatureGates(t *testing.T) {
+	awsPlatform := &types.Platform{AWS: &aws.Platform{}}
+
 	cases := []struct {
 		name               string
 		pool               *types.MachinePool
 		platform           *types.Platform
-		featureSet         configv1.FeatureSet
+		featureGates       []string
 		expectedManagement types.MachineManagementAPI
 	}{
 		{
-			name:               "control plane with DevPreviewNoUpgrade feature set",
-			pool:               &types.MachinePool{Name: types.MachinePoolControlPlaneRoleName},
-			platform:           &types.Platform{},
-			featureSet:         configv1.DevPreviewNoUpgrade,
+			name:               "AWS compute sets ClusterAPI management when ClusterAPIMachineManagementAWS enabled",
+			pool:               &types.MachinePool{Name: types.MachinePoolComputeRoleName},
+			platform:           awsPlatform,
+			featureGates:       []string{"ClusterAPIMachineManagementAWS=True"},
 			expectedManagement: types.ClusterAPI,
 		},
 		{
-			name:               "control plane with default feature set",
-			pool:               &types.MachinePool{Name: types.MachinePoolControlPlaneRoleName},
-			platform:           &types.Platform{},
-			featureSet:         configv1.Default,
+			name:               "AWS compute management is unchanged when ClusterAPIMachineManagementAWS disabled",
+			pool:               &types.MachinePool{Name: types.MachinePoolComputeRoleName},
+			platform:           awsPlatform,
+			featureGates:       []string{"ClusterAPIMachineManagementAWS=False"},
 			expectedManagement: "",
 		},
 		{
-			name:               "compute with DevPreviewNoUpgrade feature set",
-			pool:               &types.MachinePool{Name: types.MachinePoolComputeRoleName},
-			platform:           &types.Platform{},
-			featureSet:         configv1.DevPreviewNoUpgrade,
-			expectedManagement: types.ClusterAPI,
+			name:               "AWS control plane is unaffected by ClusterAPIMachineManagementAWS",
+			pool:               &types.MachinePool{Name: types.MachinePoolControlPlaneRoleName},
+			platform:           awsPlatform,
+			featureGates:       []string{"ClusterAPIMachineManagementAWS=True"},
+			expectedManagement: "",
 		},
 		{
-			name:               "compute with default feature set",
+			name:               "non-AWS compute is unaffected by ClusterAPIMachineManagementAWS",
 			pool:               &types.MachinePool{Name: types.MachinePoolComputeRoleName},
 			platform:           &types.Platform{},
-			featureSet:         configv1.Default,
+			featureGates:       []string{"ClusterAPIMachineManagementAWS=True"},
 			expectedManagement: "",
 		},
 		{
-			name:               "control plane with management already set",
-			pool:               &types.MachinePool{Name: types.MachinePoolControlPlaneRoleName, Management: types.MachineAPI},
-			platform:           &types.Platform{},
-			featureSet:         configv1.DevPreviewNoUpgrade,
-			expectedManagement: types.MachineAPI,
-		},
-		{
-			name:               "compute with management already set",
+			name:               "AWS compute management is not overwritten when already set",
 			pool:               &types.MachinePool{Name: types.MachinePoolComputeRoleName, Management: types.MachineAPI},
-			platform:           &types.Platform{},
-			featureSet:         configv1.DevPreviewNoUpgrade,
+			platform:           awsPlatform,
+			featureGates:       []string{"ClusterAPIMachineManagementAWS=True"},
 			expectedManagement: types.MachineAPI,
 		},
 	}
 
 	for _, tc := range cases {
 		t.Run(tc.name, func(t *testing.T) {
 			config := &types.InstallConfig{
-				FeatureSet: tc.featureSet,
+				FeatureSet:   configv1.CustomNoUpgrade,
+				FeatureGates: tc.featureGates,
 			}
 			SetMachinePoolDefaults(tc.pool, tc.platform, config.EnabledFeatureGates())
 			assert.Equal(t, tc.expectedManagement, tc.pool.Management, "unexpected management API")