Skip to content

unit tests: remove stale UserProvisionedDNS feature gate test #10657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
redhat-chai-bot wants to merge 1 commit into from
+0 −11
Closed

unit tests: remove stale UserProvisionedDNS feature gate test #10657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions pkg/types/validation/featuregate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import (
v1 "github.com/openshift/api/config/v1"
"github.com/openshift/installer/pkg/types"
"github.com/openshift/installer/pkg/types/azure"
"github.com/openshift/installer/pkg/types/dns"
"github.com/openshift/installer/pkg/types/vsphere"
)

Expand All @@ -19,16 +18,6 @@ func TestFeatureGates(t *testing.T) {
installConfig *types.InstallConfig
expected string
}{
{
name: "AWS UserProvisionedDNS is not allowed without Feature Gates",
installConfig: func() *types.InstallConfig {
c := validInstallConfig()
c.AWS = validAWSPlatform()
c.AWS.UserProvisionedDNS = dns.UserProvisionedDNSEnabled
return c
}(),
expected: `^platform.aws.userProvisionedDNS: Forbidden: this field is protected by the AWSClusterHostedDNSInstall feature gate which must be enabled through either the TechPreviewNoUpgrade or CustomNoUpgrade feature set$`,
},
{
name: "AWS Sovereign Cloud is not allowed without Feature Gates",
installConfig: func() *types.InstallConfig {
Expand Down