UPSTREAM: <138159>: Tests: Call removeNodeTaint variadically instead of in a loop

I believe there is a sneaky timing/caching issue here. When RemoveTaintsOffNode removes taints one at a time in a loop, each iteration reads the node from the API server cache, removes one taint, and patches. If the cache is stale for any iteration (still reflecting the state before the previous patch's watch event propagated) the patch sends the full stale list minus only the current taint, effectively re-adding the taint that was just removed in the prior step. Since the loop has already moved past that taint, it's never cleaned up. verifyThatTaintIsGone (previously called once per loop) doesn't catch this because it only checks whether the current taint was removed, not whether previously removed taints were re-introduced. The fix is to remove all taints in a single cycle instead of looping, which removeNodeTaint's variadic signature already supports.

Author: jacobsee

test/e2e/framework/node/resource.go

@@ -598,8 +598,14 @@ func CreatePodsPerNodeForSimpleApp(ctx context.Context, c clientset.Interface, n
 // RemoveTaintsOffNode removes a list of taints from the given node
 // It is simply a helper wrapper for RemoveTaintOffNode
 func RemoveTaintsOffNode(ctx context.Context, c clientset.Interface, nodeName string, taints []v1.Taint) {
+	taintPtrs := make([]*v1.Taint, len(taints))
+	for i := range taints {
+		taintPtrs[i] = &taints[i]
+	}
+	err := removeNodeTaint(ctx, c, nodeName, nil, taintPtrs...)
+	gomega.ExpectWithOffset(1, err).NotTo(gomega.HaveOccurred())
 	for _, taint := range taints {
-		RemoveTaintOffNode(ctx, c, nodeName, taint)
+		verifyThatTaintIsGone(ctx, c, nodeName, &taint)
 	}
 }