Remove some unnecessary sig-network test skips by danwinship · Pull Request #2476 · openshift/kubernetes

danwinship · 2025-09-26T20:39:15Z

(see review comments for explanations)

openshift-ci-robot · 2025-09-26T20:39:26Z

@danwinship: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

6cba674|UPSTREAM: : Remove some unnecessary sig-network test skips: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

openshift-ci · 2025-09-26T20:40:11Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danwinship
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-09-28T15:10:20Z

@danwinship: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

4b12cbb|UPSTREAM: : Remove some unnecessary sig-network test skips: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

openshift-ci-robot · 2025-09-29T12:44:52Z

@danwinship: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

dc526f2|UPSTREAM: : Remove some unnecessary sig-network test skips: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

openshift-bot · 2025-12-29T01:01:27Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

The ClusterDns and Firewall tests no longer exist. The Topology Hints test was renamed (`[Feature:Topology Hints]` went away when the feature became GA), and we already have a separate skip rule for the new name. The two service tests that were skipped because they require SSH got rewritten at some point to use a HostNetwork pod instead.

openshift-ci-robot · 2026-01-23T15:44:11Z

@danwinship: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

17c7244|UPSTREAM: : Remove some unnecessary sig-network test skips: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

danwinship · 2026-01-23T15:45:01Z

 			"Firewall rule should have correct firewall rules for e2e cluster", // Upstream-install specific

-			// https://bugzilla.redhat.com/show_bug.cgi?id=2079958
-			"[sig-network] [Feature:Topology Hints] should distribute endpoints evenly",


The test got renamed (removing the Feature tag) when the feature went GA, so this rule no longer matches anything. There's already another rule matching the new name (line 121).

danwinship · 2026-01-23T15:45:58Z

-			"KubeProxy should set TCP CLOSE_WAIT timeout",               // the test require communication to port 11302 in the cluster nodes
-			"should check kube-proxy urls",                              // previously this test was skipped b/c we reported -1 as the number of nodes, now we report proper number and test fails
-			"SSH",                                                       // TRIAGE
-			"should implement service.kubernetes.io/service-proxy-name", // this is an optional test that requires SSH. sig-network


This test got rewritten to not use SSH, and passes fine now. (The rest of this block is just gofmt-ing.)

danwinship · 2026-01-23T15:46:14Z

 			"RuntimeClass should reject",

-			"Services should implement service.kubernetes.io/headless",                    // requires SSH access to function, needs to be refactored
-			"ClusterDns [Feature:Example] should create pod that uses dns",                // doesn't use bindata, not part of kube test binary


test no longer exists

danwinship · 2026-01-23T15:46:33Z


-			"Services should implement service.kubernetes.io/headless",                    // requires SSH access to function, needs to be refactored
-			"ClusterDns [Feature:Example] should create pod that uses dns",                // doesn't use bindata, not part of kube test binary
+			"Services should implement service.kubernetes.io/headless", // test is broken, fixed in 1.36 by https://pr.k8s.io/134623


updating comment; test now fails for a different reason (but will pass starting in 1.36)

danwinship · 2026-01-23T15:46:41Z

 			"[sig-network] Networking Granular Checks: Services should function for pod-Service(hostNetwork)",

-			// https://bugzilla.redhat.com/show_bug.cgi?id=1952460
-			"[sig-network] Firewall rule control plane should not expose well-known ports",


test no longer exists

openshift-ci · 2026-01-23T20:18:20Z

@danwinship: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-techpreview-serial	`dc526f2`	link	false	`/test e2e-aws-ovn-techpreview-serial`
ci/prow/e2e-aws-csi	`dc526f2`	link	false	`/test e2e-aws-csi`
ci/prow/okd-scos-e2e-aws-ovn	`dc526f2`	link	false	`/test okd-scos-e2e-aws-ovn`
ci/prow/e2e-aws-ovn-serial	`dc526f2`	link	true	`/test e2e-aws-ovn-serial`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

danwinship · 2026-01-23T22:39:16Z

/retest-required

openshift-bot · 2026-04-24T09:00:20Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Sep 26, 2025

openshift-ci Bot requested review from jerpeter1 and tkashem September 26, 2025 20:40

danwinship force-pushed the remove-old-skips branch from 6cba674 to 4b12cbb Compare September 28, 2025 15:10

danwinship force-pushed the remove-old-skips branch from 4b12cbb to dc526f2 Compare September 29, 2025 12:44

openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 29, 2025

danwinship force-pushed the remove-old-skips branch from dc526f2 to 17c7244 Compare January 23, 2026 15:44

danwinship commented Jan 23, 2026

View reviewed changes

danwinship removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 23, 2026

openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 24, 2026

Conversation

danwinship commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 26, 2025

Uh oh!

openshift-ci Bot commented Sep 26, 2025

Uh oh!

openshift-ci-robot commented Sep 28, 2025

Uh oh!

openshift-ci-robot commented Sep 29, 2025

Uh oh!

openshift-bot commented Dec 29, 2025

Uh oh!

openshift-ci-robot commented Jan 23, 2026

Uh oh!

danwinship Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

danwinship Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

danwinship Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

danwinship Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

danwinship Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danwinship commented Jan 23, 2026

Uh oh!

openshift-bot commented Apr 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

danwinship commented Sep 26, 2025 •

edited

Loading

openshift-ci Bot commented Jan 23, 2026 •

edited

Loading