OCPBUGS-61465: Add a new field Mapped into openshift-test extension Image struct

[jubittajohn]

The current GetMappedImageConfigs returns the map with only mapped image config. The new func GetImageConfigsWithMappedImage will return original image information along with mapped one.

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Summary by CodeRabbit

Release Notes

• New Features
  • Image-conversion flow now supports mapped images through configurable mirror settings, enabling enhanced image handling and flexibility.

[openshift-ci-robot]

@jubittajohn: This pull request references Jira Issue OCPBUGS-61465, which is invalid:

• expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "4.21.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The current GetMappedImageConfigs returns the map with only mapped image config. The new func GetImageConfigsWithMappedImage will return original image information along with mapped one.

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@jubittajohn: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 558aeaa|UPSTREAM: : Update openshift-tests-extension dependency: does not specify an upstream backport in the commit message
• b2f86b9|UPSTREAM: : Add a new field Mapped into openshift-test extension Image struct: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[openshift-ci-robot]

@jubittajohn: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 36bb3ac|UPSTREAM: : Update openshift-tests-extension dependency: does not specify an upstream backport in the commit message
• 9529602|UPSTREAM: : Add a new field Mapped into openshift-test extension Image struct: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[openshift-ci-robot]

@jubittajohn: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 36bb3ac|UPSTREAM: : Update openshift-tests-extension dependency: does not specify an upstream backport in the commit message
• 5d2cca9|UPSTREAM: : Add a new field Mapped into openshift-test extension Image struct: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[jubittajohn]

/test e2e-metal-ipi-ovn-ipv6

[jubittajohn]

/retest

[jubittajohn]

/retest

[openshift-ci-robot]

@jubittajohn: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 81e11ad|UPSTREAM: : Add a new field Mapped into openshift-test extension Image struct: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7015ac1d-c735-4f1e-aff4-23f7de2eb082

📥 Commits

Reviewing files that changed from the base of the PR and between 2447118 and 81e11ad.

📒 Files selected for processing (1)

• openshift-hack/cmd/k8s-tests-ext/k8s-tests.go

---

Walkthrough

The image-conversion flow in the k8s-tests tool now supports mapped images sourced from a configurable mirror. The registration loop reads TEST_IMAGE_MIRROR environment variable, derives mapped image configurations, converts both original and mapped variants, and attaches the mapped result to image objects. The convertToImage function now accepts an explicit index parameter.

Changes

Cohort / File(s)	Summary
Mapped Image Support openshift-hack/cmd/k8s-tests-ext/k8s-tests.go	Added mapped image configuration support with mirror-based image derivation. Registration loop now reads TEST_IMAGE_MIRROR (defaults to quay.io/openshift/community-e2e-images), processes both original and mapped image configs through conversion pipeline, and attaches mapped result via image.Mapped. Updated convertToImage to accept explicit index parameter instead of setting it after conversion.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

---

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 warning, 3 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Single Node Openshift (Sno) Test Compatibility	❓ Inconclusive	Cannot verify without actual git diff output showing changes to k8s-tests.go file.	Please provide the git diff output to verify the specific changes made to the file.
Ote Binary Stdout Contract	❓ Inconclusive	The specific file openshift-hack/cmd/k8s-tests-ext/k8s-tests.go could not be located in the repository for examination.	Provide access to the actual file or verify the repository is checked out to the correct branch containing the PR changes.
Ipv6 And Disconnected Network Test Compatibility	❓ Inconclusive	Unable to locate or examine the actual code changes in the repository to assess IPv6 and disconnected network compatibility.	Provide direct access to modified file contents or run investigation in accessible repository environment.

✅ Passed checks (8 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding a 'Mapped' field to the Image struct in the openshift-test extension. This aligns with the code changes and PR objectives.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The pull request does not introduce or modify any Ginkgo test files or test names. All changes are confined to a command-line utility file with no test definitions.
Test Structure And Quality	✅ Passed	The modified file is a command-line configuration tool with no Ginkgo test blocks, test fixtures, or assertions. The Ginkgo test code quality check is not applicable.
Microshift Test Compatibility	✅ Passed	PR does not add any new Ginkgo e2e tests; only modifies image conversion utility functions.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only test utility code in openshift-hack/cmd/k8s-tests-ext/k8s-tests.go with no changes to deployment manifests, operator code, or scheduling constraints.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Review rate limit: 9/10 reviews remaining, refill in 6 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jubittajohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [jubittajohn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@jubittajohn: This pull request references Jira Issue OCPBUGS-61465, which is invalid:

• expected the bug to target either version "5.0." or "openshift-5.0.", but it targets "4.22" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

The current GetMappedImageConfigs returns the map with only mapped image config. The new func GetImageConfigsWithMappedImage will return original image information along with mapped one.

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Summary by CodeRabbit

Release Notes

• New Features
• Image-conversion flow now supports mapped images through configurable mirror settings, enabling enhanced image handling and flexibility.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@jubittajohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-techpreview-serial-2of2	81e11ad	link	false	/test e2e-aws-ovn-techpreview-serial-2of2
ci/prow/unit	81e11ad	link	true	/test unit
ci/prow/e2e-aws-ovn-crun	81e11ad	link	true	/test e2e-aws-ovn-crun
ci/prow/e2e-aws-ovn-hypershift	81e11ad	link	true	/test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-ovn-runc	81e11ad	link	false	/test e2e-aws-ovn-runc

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.