OCPBUGS-77243: test: skip private registry test#2621
OCPBUGS-77243: test: skip private registry test#2621haircommander wants to merge 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
backports/unvalidated-commits
|
@haircommander: This pull request references Jira Issue OCPBUGS-77243, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@haircommander: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughReplaces an existing disabled test entry with a more specific, tagged variant for the Container Runtime private registry pull test in SpecialConfig, referencing OCPBUGS-77243; no functional logic or signatures changed. (Lines changed: +4 / -6) Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@haircommander: This pull request references Jira Issue OCPBUGS-77243, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
openshift-hack/cmd/k8s-tests-ext/disabled_tests.go (1)
180-181:⚠️ Potential issue | 🟡 MinorDuplicate entry — test already added to SpecialConfig (line 67).
This test string is identical to the one added at line 67 in the "SpecialConfig" section. Since
filterOutDisabledSpecscollects all disabled tests into a single set regardless of category, this duplication is functionally redundant.More importantly, there's a category mismatch:
- SpecialConfig: For tests requiring special configuration not supported OOTB (permanent)
- RebaseInProgress: For tests temporarily disabled during rebase (temporary)
The PR description indicates this requires CRI-O to be configured for insecure registries, which sounds like a permanent configuration requirement, not a temporary rebase issue. Consider removing this entry from "RebaseInProgress" and keeping only the entry in "SpecialConfig" to avoid confusion about when this test should be re-enabled.
Suggested fix
// tests that need to be temporarily disabled while the rebase is in progress. "RebaseInProgress": { // https://issues.redhat.com/browse/OCPBUGS-61515 "[sig-scheduling] SchedulerPreemption [Serial] validates various priority Pods preempt expectedly with the async preemption [Feature:SchedulerAsyncPreemption] [FeatureGate:SchedulerAsyncPreemption] [Beta]", // https://issues.redhat.com/browse/OCPBUGS-61378 "[sig-network] Conntrack should be able to cleanup conntrack entries when UDP service target port changes for a NodePort service", - - // https://issues.redhat.com/browse/OCPBUGS-77243 - "[sig-node] Container Runtime blackbox test when running a container with a new image [Serial] should be able to pull from private registry with secret [NodeConformance]", },🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@openshift-hack/cmd/k8s-tests-ext/disabled_tests.go` around lines 180 - 181, Remove the duplicate test entry from the RebaseInProgress list: the string "[sig-node] Container Runtime blackbox test when running a container with a new image [Serial] should be able to pull from private registry with secret [NodeConformance]" is already present in SpecialConfig (see SpecialConfig section) and should not be listed under RebaseInProgress; update the RebaseInProgress slice/variable in disabled_tests.go to delete that string so filterOutDisabledSpecs only sees it once and the categorization (SpecialConfig vs RebaseInProgress) correctly reflects the permanent special-configuration requirement.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@openshift-hack/cmd/k8s-tests-ext/disabled_tests.go`:
- Around line 180-181: Remove the duplicate test entry from the RebaseInProgress
list: the string "[sig-node] Container Runtime blackbox test when running a
container with a new image [Serial] should be able to pull from private registry
with secret [NodeConformance]" is already present in SpecialConfig (see
SpecialConfig section) and should not be listed under RebaseInProgress; update
the RebaseInProgress slice/variable in disabled_tests.go to delete that string
so filterOutDisabledSpecs only sees it once and the categorization
(SpecialConfig vs RebaseInProgress) correctly reflects the permanent
special-configuration requirement.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: cfddc314-fdc2-4739-acdd-c46b087b74d3
📒 Files selected for processing (1)
openshift-hack/cmd/k8s-tests-ext/disabled_tests.go
as it requires CRI-O be setup to allow insecure registries Signed-off-by: Peter Hunt <pehunt@redhat.com>
haircommander
force-pushed
the
skip-private
branch
from
1afc027 to
7ef18c2
Compare
|
@haircommander: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@haircommander: This pull request references Jira Issue OCPBUGS-77243, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
/retest-required |
|
/approved |
openshift-ci-robot
added
the
verified
|
@rphillips: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, jacobsee, rphillips The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/remove-label backports/unvalidated-commits |
|
@rphillips: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
mrunalp
removed
the
backports/unvalidated-commits
|
/retest |
1 similar comment
|
/retest |
|
/hold Revision 7ef18c2 was retested 3 times: holding |
|
@haircommander: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5 participants
as it requires CRI-O be setup to allow insecure registries
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR is related to:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Summary by CodeRabbit