OCPBUGS-63132: disabled_tests: add flaky InPlacePodVerticalScaling tests#2642
OCPBUGS-63132: disabled_tests: add flaky InPlacePodVerticalScaling tests#2642dgrisonnet wants to merge 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
backports/unvalidated-commits
|
@dgrisonnet: This pull request references Jira Issue OCPBUGS-63132, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@dgrisonnet: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughUpdated disabled-tests list in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 11 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (11 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 6 minutes and 40 seconds.Comment |
dgrisonnet
force-pushed
the
disable-flaky-ipvs-tests
branch
from
e0fa38e to
0a8ca47
Compare
|
@dgrisonnet: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dgrisonnet The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/validate-backports |
|
@dgrisonnet: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
openshift-hack/cmd/k8s-tests-ext/disabled_tests.go (1)
166-177: Move these new entries fromBrokentoFlakyfor accurate triage taxonomy.These additions are described as flaky in the PR objective, but they’re currently filed under
Broken. That makes future cleanup/reporting noisier and obscures stabilization status.Suggested diff
@@ - // https://redhat.atlassian.net/browse/OCPBUGS-63132 - "[sig-node] [Serial] Pod InPlace Resize Container (deferred-resizes) [FeatureGate:InPlacePodVerticalScaling] pod-resize-retry-deferred-test-3", - "[sig-node] [Serial] Pod InPlace Resize Container (scheduler-focused) [FeatureGate:InPlacePodVerticalScaling] [Beta] pod-resize-scheduler-tests" - - // https://redhat.atlassian.net/browse/OCPBUGS-77990 - "[sig-node] [Serial] Pod InPlace Resize Container (deferred-resizes) [FeatureGate:InPlacePodVerticalScaling] pod-resize-retry-deferred-test-2" - - // https://redhat.atlassian.net/browse/OCPBUGS-64847 - "[sig-node] Pod InPlace Resize Container [FeatureGate:InPlacePodVerticalScaling] [Beta] Burstable QoS pod, one container with cpu & memory requests + limits - decrease memory requests and increase memory limits" - - // https://redhat.atlassian.net/browse/OCPBUGS-82071 - "[sig-node] Pod InPlace Resize Container burstable pods - 1 container with all requests & limits set and resize policy mem restart resizing cpu requests" - "[sig-node] PodRejectionStatus Kubelet should reject pod when the node didn't have enough resource" @@ "Flaky": { "Job should run a job to completion when tasks sometimes fail and are not locally restarted", // seems flaky, also may require too many resources + // https://redhat.atlassian.net/browse/OCPBUGS-63132 + "[sig-node] [Serial] Pod InPlace Resize Container (deferred-resizes) [FeatureGate:InPlacePodVerticalScaling] pod-resize-retry-deferred-test-3", + "[sig-node] [Serial] Pod InPlace Resize Container (scheduler-focused) [FeatureGate:InPlacePodVerticalScaling] [Beta] pod-resize-scheduler-tests", + // https://redhat.atlassian.net/browse/OCPBUGS-77990 + "[sig-node] [Serial] Pod InPlace Resize Container (deferred-resizes) [FeatureGate:InPlacePodVerticalScaling] pod-resize-retry-deferred-test-2", + // https://redhat.atlassian.net/browse/OCPBUGS-64847 + "[sig-node] Pod InPlace Resize Container [FeatureGate:InPlacePodVerticalScaling] [Beta] Burstable QoS pod, one container with cpu & memory requests + limits - decrease memory requests and increase memory limits", + // https://redhat.atlassian.net/browse/OCPBUGS-82071 + "[sig-node] Pod InPlace Resize Container burstable pods - 1 container with all requests & limits set and resize policy mem restart resizing cpu requests", + "[sig-node] PodRejectionStatus Kubelet should reject pod when the node didn't have enough resource", },As per coding guidelines, "Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@openshift-hack/cmd/k8s-tests-ext/disabled_tests.go` around lines 166 - 177, The listed test names currently placed under the Broken list should be moved to the Flaky list to match the PR intent: remove the entries for the Pod InPlace Resize Container and PodRejectionStatus tests (the three deferred/rescheduler/scheduler-focused strings and the Burstable/QoS/resizing entries shown in the diff) from the Broken collection and add them to the Flaky collection; preserve the surrounding Jira comment lines (OCPBUGS-77990, OCPBUGS-64847, OCPBUGS-82071) and maintain ordering/formatting in the Flaky slice so triage reflects these tests as flaky rather than broken.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@openshift-hack/cmd/k8s-tests-ext/disabled_tests.go`:
- Around line 166-177: The listed test names currently placed under the Broken
list should be moved to the Flaky list to match the PR intent: remove the
entries for the Pod InPlace Resize Container and PodRejectionStatus tests (the
three deferred/rescheduler/scheduler-focused strings and the
Burstable/QoS/resizing entries shown in the diff) from the Broken collection and
add them to the Flaky collection; preserve the surrounding Jira comment lines
(OCPBUGS-77990, OCPBUGS-64847, OCPBUGS-82071) and maintain ordering/formatting
in the Flaky slice so triage reflects these tests as flaky rather than broken.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9d38d350-1207-414b-99ff-e2a880ad480d
📒 Files selected for processing (1)
openshift-hack/cmd/k8s-tests-ext/disabled_tests.go
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@openshift-hack/cmd/k8s-tests-ext/disabled_tests.go`:
- Around line 167-177: The multiline []string composite literal in
disabled_tests.go has several string entries missing trailing commas (the
elements like "[sig-node] [Serial] Pod InPlace Resize Container
(scheduler-focused) ...", "[sig-node] [Serial] Pod InPlace Resize Container
(deferred-resizes) ...", "[sig-node] Pod InPlace Resize Container ...",
"[sig-node] Pod InPlace Resize Container burstable pods ...", and "[sig-node]
PodRejectionStatus Kubelet should reject pod ...") which breaks Go parsing; fix
by adding a trailing comma after each string element in that slice literal
(ensure every line in the []string block ends with a comma, including the final
element) and run gofmt/go vet to confirm formatting and syntax correctness.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d2ef4e62-b3ad-40ec-9611-17acebf38535
📒 Files selected for processing (1)
openshift-hack/cmd/k8s-tests-ext/disabled_tests.go
dgrisonnet
force-pushed
the
disable-flaky-ipvs-tests
branch
from
0a8ca47 to
2545e4d
Compare
|
@dgrisonnet: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@pacevedom I added the bug you are working on to this list, in case your port doesn't make it in time for 4.22. Please let me know if it makes sense to you |
|
/retest |
dgrisonnet
force-pushed
the
disable-flaky-ipvs-tests
branch
from
2545e4d to
0728b36
Compare
|
@dgrisonnet: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
openshift-ci-robot
added
jira/invalid-bug
|
@dgrisonnet: This pull request references Jira Issue OCPBUGS-63132, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@dgrisonnet: This pull request references Jira Issue OCPBUGS-63132, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (cmaurya@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
…g tests Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
dgrisonnet
force-pushed
the
disable-flaky-ipvs-tests
branch
from
0728b36 to
962706d
Compare
|
@dgrisonnet: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/cherry-pick release-4.22 |
|
@dgrisonnet: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dgrisonnet: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
Since the InPlacePodVerticalScaling feature became beta and on by default in 1.33/4.20, its tests have been flaky both upstream and downstream.
This PR disables the tests known to flake to reduce the impact on component readiness until the tests are stabilized upstream.
Summary by CodeRabbit