OCPBUGS-93896: Rebase v1.33.13 in release-4.20#2706
Conversation
Accessing svc.Spec.IPFamilies[0] without a bounds check panics when a service reaches the controller with an empty IPFamilies field. This can happen via watch events: the apiserver's defaultOnRead decorator populates IPFamilies on GET/LIST but not on watch (cachingObject wrapping bypasses the type assertion). Restore the inference logic removed in kubernetes#130101: fall back to ClusterIP for headful services and pod IP for headless services. Signed-off-by: Rahul <rahulbabu95@gmail.com>
…y-pick-of-#138736-upstream-release-1.33 Automated cherry pick of kubernetes#138736: fix: avoid panic on services with empty IPFamilies
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
…l133 [release-1.33] [go] Bump images and versions to go 1.25.11 and distroless iptables
Kubernetes official release v1.33.13
|
@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-93896, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@redhat-chai-bot: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/lgtm |
|
@dusk125: This pull request references Jira Issue OCPBUGS-93896, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@redhat-chai-bot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dusk125, jacobsee, redhat-chai-bot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
CHANGELOG https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.33.md#v13313