fix go vet format string violations for Go 1.26

Signed-off-by: jubittajohn <jujohn@redhat.com>

Author: jubittajohn

pkg/operator/apiserver/controller/apiservice/apigroup.go

@@ -78,7 +78,7 @@ func checkDiscoveryForByAPIServices(ctx context.Context, recorder events.Recorde
 		err := checkDiscoveryForAPIService(ctx, restclient, apiService)
 		if err != nil {
 			groupVersionString := fmt.Sprintf("%s.%s", apiService.Spec.Group, apiService.Spec.Version)
-			recorder.Warningf("OpenShiftAPICheckFailed", fmt.Sprintf("%q failed with %v", groupVersionString, err))
+			recorder.Warningf("OpenShiftAPICheckFailed", "%s failed with %v", groupVersionString, err)
 			missingMessages = append(missingMessages, fmt.Sprintf("%q is not ready: %v", groupVersionString, err))
 		}
 	}

pkg/operator/certrotation/client_cert_rotation_controller.go

@@ -126,7 +126,7 @@ func (c CertRotationController) Sync(ctx context.Context, syncCtx factory.SyncCo
 		return updateErr
 	}
 	if updated && syncErr != nil {
-		syncCtx.Recorder().Warningf("RotationError", syncErr.Error())
+		syncCtx.Recorder().Warningf("RotationError", "%s", syncErr.Error())
 	}
 
 	return syncErr

pkg/operator/configobserver/etcd/observe_etcd_endpoints.go

@@ -218,7 +218,7 @@ func innerObserveStorageURLsFromOldEndPoint(genericListers configobserver.Lister
 		}
 	} else {
 		err := fmt.Errorf("endpoints/%s in the %s namespace: no etcd endpoint addresses found, falling back to default etcd service", EtcdEndpointName, EtcdEndpointNamespace)
-		recorder.Warningf("ObserveStorageFallback", err.Error())
+		recorder.Warningf("ObserveStorageFallback", "%s", err.Error())
 		errs = append(errs, err)
 	}
 

pkg/operator/configobserver/oauth/observe_tokenconfig.go

@@ -61,7 +61,7 @@ func ObserveAccessTokenMaxAgeSeconds(genericlisters configobserver.Listers, reco
 	}
 
 	if existingAccessTokenMaxAgeSeconds != observedAccessTokenMaxAgeSeconds {
-		recorder.Eventf("ObserveAccessTokenMaxAgeSeconds", "%s changed from %d to %d", fieldAccessTokenMaxAgeSeconds,
+		recorder.Eventf("ObserveAccessTokenMaxAgeSeconds", "%s changed from %f to %f", fieldAccessTokenMaxAgeSeconds,
 			existingAccessTokenMaxAgeSeconds,
 			observedAccessTokenMaxAgeSeconds)
 	}

pkg/operator/encryption/controllers/state_controller.go

@@ -153,7 +153,7 @@ func (c *stateController) generateAndApplyCurrentEncryptionConfigSecret(ctx cont
 		currentEncryptionConfig, _ := encryptiondata.ToEncryptionState(currentConfig, encryptionSecrets)
 		if actionEvents := eventsFromEncryptionConfigChanges(currentEncryptionConfig, desiredEncryptionState); len(actionEvents) > 0 {
 			for _, event := range actionEvents {
-				recorder.Eventf(event.reason, event.message)
+				recorder.Eventf(event.reason, "%s", event.message)
 			}
 		}
 	}

pkg/operator/staticpod/certsyncpod/certsync_controller.go

@@ -66,7 +66,7 @@ func NewCertSyncController(targetDir, targetNamespace string, configmaps, secret
 
 func (c *CertSyncController) sync(ctx context.Context, syncCtx factory.SyncContext) error {
 	if err := os.RemoveAll(getStagingDir(c.destinationDir)); err != nil {
-		c.eventRecorder.Warningf("CertificateUpdateFailed", fmt.Sprintf("Failed to prune staging directory: %v", err))
+		c.eventRecorder.Warningf("CertificateUpdateFailed", "%s", fmt.Sprintf("Failed to prune staging directory: %v", err))
 		return err
 	}
 

pkg/operator/staticpod/controller/guard/guard_controller_test.go

@@ -904,11 +904,11 @@ func TestRenderGuardPodPortChanged(t *testing.T) {
 
 		// The port is expected to be set to 99999 by the guard controller
 		if probe.Port.IntValue() != 99999 {
-			t.Errorf("unexpected port in ReadinessProbe in the guard, expected %q, got %q instead", ctrl.readyzPort, probe.Port.IntValue())
+			t.Errorf("unexpected port in ReadinessProbe in the guard, expected %q, got %d instead", ctrl.readyzPort, probe.Port.IntValue())
 		}
 		// The port is expected to be different from the one initially set in the guard pod readiness probe
 		if originalProbe.Port.IntValue() == probe.Port.IntValue() {
-			t.Errorf("unexpected port in ReadinessProbe in the guard, expected it to be different from %q, got %q", originalProbe.Port.IntValue(), probe.Port.IntValue())
+			t.Errorf("unexpected port in ReadinessProbe in the guard, expected it to be different from %d, got %d", originalProbe.Port.IntValue(), probe.Port.IntValue())
 		}
 
 		// The path is expected to be set to healthz by the guard controller

pkg/operator/staticpod/controller/installer/installer_controller.go

@@ -1119,7 +1119,7 @@ func (c InstallerController) ensureRequiredResourcesExist(ctx context.Context, r
 	for _, err := range aggregatedErr.Errors() {
 		eventMessages = append(eventMessages, err.Error())
 	}
-	c.eventRecorder.Warningf("RequiredInstallerResourcesMissing", strings.Join(eventMessages, ", "))
+	c.eventRecorder.Warningf("RequiredInstallerResourcesMissing", "%s", strings.Join(eventMessages, ", "))
 	return fmt.Errorf("missing required resources: %v", aggregatedErr)
 }
 

pkg/operator/staticpod/controller/installerstate/installer_state_controller.go

@@ -185,7 +185,7 @@ func (c *InstallerStateController) handlePendingInstallerPodsNetworkEvents(ctx c
 				Message: fmt.Sprintf("Pod %q on node %q observed degraded networking: %s", pod.Name, pod.Spec.NodeName, event.Message),
 			}
 			conditions = append(conditions, condition)
-			recorder.Warningf(condition.Reason, condition.Message)
+			recorder.Warningf(condition.Reason, "%s", condition.Message)
 		}
 	}
 	return conditions, nil
@@ -204,7 +204,7 @@ func (c *InstallerStateController) handlePendingInstallerPods(recorder events.Re
 				Message: fmt.Sprintf("Pod %q on node %q is Pending since %s because %s", pod.Name, pod.Spec.NodeName, pod.Status.StartTime.Time, pod.Status.Message),
 			}
 			conditions = append(conditions, condition)
-			recorder.Warningf(condition.Reason, condition.Message)
+			recorder.Warningf(condition.Reason, "%s", condition.Message)
 		}
 
 		// one or more containers are in waiting state for longer than maxToleratedPodPendingDuration, report the reason and message
@@ -227,7 +227,7 @@ func (c *InstallerStateController) handlePendingInstallerPods(recorder events.Re
 					Message: message,
 				}
 				conditions = append(conditions, condition)
-				recorder.Warningf(condition.Reason, condition.Message)
+				recorder.Warningf(condition.Reason, "%s", condition.Message)
 			}
 		}
 	}

pkg/operator/staticpod/controller/node/node_controller.go

@@ -182,7 +182,7 @@ func (c *NodeController) sync(ctx context.Context, syncCtx factory.SyncContext)
 
 	oldNodeDegradedCondition := v1helpers.FindOperatorCondition(originalOperatorStatus.Conditions, condition.NodeControllerDegradedConditionType)
 	if oldNodeDegradedCondition == nil || oldNodeDegradedCondition.Message != *degradedCondition.Message {
-		syncCtx.Recorder().Eventf("MasterNodesReadyChanged", *degradedCondition.Message)
+		syncCtx.Recorder().Eventf("MasterNodesReadyChanged", "%s", *degradedCondition.Message)
 	}
 	return nil
 }