fix: truncate proposal name in label values to 63 chars

The operator uses proposal.Name directly as a Kubernetes label value
(agentic.openshift.io/proposal) when creating result CRs, RBAC
resources, sandbox pods, and SandboxClaim CRs. Kubernetes label values
are limited to 63 characters, so names exceeding this limit cause
resource creation failures.

Apply truncateK8sName() to proposalName in all four label-setting
locations as defense in depth.

Signed-off-by: Tomáš Remeš <tremes@redhat.com>
Assisted-by: Claude Code:claude-opus-4-6

Author: tremes

controller/proposal/bare_pod_manager.go

@@ -72,7 +72,7 @@ func (m *BarePodManager) Claim(ctx context.Context, proposalName, step, _ string
 			Name:      podName,
 			Namespace: m.Namespace,
 			Labels: map[string]string{
-				LabelProposal: proposalName,
+				LabelProposal: truncateK8sName(proposalName),
 				LabelStep:     step,
 			},
 		},

controller/proposal/rbac.go

@@ -228,7 +228,7 @@ func clusterRoleName(proposalName string) string {
 
 func rbacLabels(proposalName, component string) map[string]string {
 	return map[string]string{
-		LabelProposal:  proposalName,
+		LabelProposal:  truncateK8sName(proposalName),
 		LabelComponent: component,
 	}
 }

controller/proposal/results.go

@@ -36,7 +36,7 @@ func proposalOwnerRef(proposal *agenticv1alpha1.Proposal) metav1.OwnerReference
 
 func resultLabels(proposalName, step string) map[string]string {
 	return map[string]string{
-		LabelProposal: proposalName,
+		LabelProposal: truncateK8sName(proposalName),
 		LabelStep:     step,
 	}
 }

controller/proposal/sandbox.go

@@ -80,7 +80,7 @@ func (m *SandboxManager) buildClaim(claimName, proposalName, step, templateName
 				"name":      claimName,
 				"namespace": m.Namespace,
 				"labels": map[string]any{
-					LabelProposal: proposalName,
+					LabelProposal: truncateK8sName(proposalName),
 					LabelStep:     step,
 				},
 			},