Skip to content

PF5: Tests: Replace all console-image flags with the PR image#1870

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:pattern-fly-5from
kyoto:pf5-tests-fix-console-image
Apr 24, 2026
Merged

PF5: Tests: Replace all console-image flags with the PR image#1870
openshift-merge-bot[bot] merged 1 commit intoopenshift:pattern-fly-5from
kyoto:pf5-tests-fix-console-image

Conversation

@kyoto
Copy link
Copy Markdown
Member

@kyoto kyoto commented Apr 24, 2026

Manual cherry pick of #1868

When running tests in CI, replace all console images with the image for the PR being tested. This ensures the PR image is always used regardless of the OCP version being used.

Made-with: Cursor

Summary by CodeRabbit

  • Tests
    • Refined console image argument handling in test suite to more accurately target and update configuration parameters.

When running tests in CI, replace all console images with the image for
the PR being tested. This ensures the PR image is always used regardless
of the OCP version being used.

Made-with: Cursor
@kyoto kyoto added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 24, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1911bf34-9178-4c02-8b9f-ee6135d74c5d

📥 Commits

Reviewing files that changed from the base of the PR and between 6b08894 and a357476.

📒 Files selected for processing (1)
  • tests/tests/lightspeed-install.cy.ts

📝 Walkthrough

Walkthrough

A test file update that refines console image argument patching logic to target the generic --console-image argument name instead of the specific --console-image-pf5 flag, and adjusts the replacement method to modify the value portion directly rather than reconstructing the flag.

Changes

Cohort / File(s) Summary
Test Console Image Arg Patching
tests/tests/lightspeed-install.cy.ts
Modified CSV arg patching logic to target --console-image generically and update the value portion via = substitution instead of flag reconstruction.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐰 A test gets trimmed with care so fine,
Arguments patched in ways more divine,
Generic flags now catch the light,
Where values swap in simple might!
Hop hop, the tests align just right! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating test logic to replace console-image flags with the PR image for testing purposes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from JoaoFula and syedriko April 24, 2026 09:39
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 24, 2026

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 24, 2026

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 676cb7c into openshift:pattern-fly-5 Apr 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant