OLS-3221 Reduce app server liveness probe failureThreshold to 3

Lowers the liveness probe failureThreshold from 15 to 3, giving the pod
90 seconds to self-heal before Kubernetes restarts it. This enables
auto-recovery after PostgreSQL restart once the service-side liveness
endpoint checks DB health.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: sriroopar

internal/controller/appserver/assets_test.go

@@ -1623,6 +1623,8 @@ user_data_collector_config: {}
 			Expect(dep.Spec.Template.Spec.Containers[0].LivenessProbe).ToNot(BeNil())
 			Expect(dep.Spec.Template.Spec.Containers[0].LivenessProbe.HTTPGet.Port).To(Equal(intstr.FromString("https")))
 			Expect(dep.Spec.Template.Spec.Containers[0].LivenessProbe.HTTPGet.Path).To(Equal("/liveness"))
+			Expect(dep.Spec.Template.Spec.Containers[0].LivenessProbe.FailureThreshold).To(Equal(int32(3)))
+			Expect(dep.Spec.Template.Spec.Containers[0].LivenessProbe.PeriodSeconds).To(Equal(int32(30)))
 			Expect(dep.Spec.Template.Spec.Containers[0].ReadinessProbe).ToNot(BeNil())
 			Expect(dep.Spec.Template.Spec.Containers[0].ReadinessProbe.HTTPGet.Port).To(Equal(intstr.FromString("https")))
 			Expect(dep.Spec.Template.Spec.Containers[0].ReadinessProbe.HTTPGet.Path).To(Equal("/readiness"))

internal/controller/appserver/deployment.go

@@ -438,7 +438,7 @@ func GenerateOLSDeployment(r reconciler.Reconciler, cr *olsv1alpha1.OLSConfig) (
 								InitialDelaySeconds: 30,
 								PeriodSeconds:       30,
 								TimeoutSeconds:      30,
-								FailureThreshold:    15,
+								FailureThreshold:    3,
 							},
 						},
 					},

internal/controller/appserver/deployment_test.go

@@ -273,6 +273,8 @@ var _ = Describe("App server deployment generation", func() {
 			Expect(dep.Spec.Selector.MatchLabels).To(Equal(utils.GenerateAppServerSelectorLabels()))
 			Expect(dep.Spec.Template.Spec.Containers[0].LivenessProbe).ToNot(BeNil())
 			Expect(dep.Spec.Template.Spec.Containers[0].LivenessProbe.HTTPGet.Port).To(Equal(intstr.FromString("https")))
+			Expect(dep.Spec.Template.Spec.Containers[0].LivenessProbe.FailureThreshold).To(Equal(int32(3)))
+			Expect(dep.Spec.Template.Spec.Containers[0].LivenessProbe.PeriodSeconds).To(Equal(int32(30)))
 			Expect(dep.Spec.Template.Spec.Containers[0].ReadinessProbe).ToNot(BeNil())
 			Expect(dep.Spec.Template.Spec.Containers[0].ReadinessProbe.HTTPGet.Port).To(Equal(intstr.FromString("https")))
 		})