Skip to content

Commit eb2611c

Browse files
Merge pull request #5884 from pablintino/ocpbugs-84332
OCPBUGS-84332: Fix ssh and password rollbacks
2 parents 25df36b + 3d98512 commit eb2611c

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

pkg/daemon/update.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1242,7 +1242,7 @@ func (dn *Daemon) update(oldConfig, newConfig *mcfgv1.MachineConfig, skipCertifi
12421242

12431243
defer func() {
12441244
if retErr != nil {
1245-
if err := dn.updateSSHKeys(newIgnConfig.Passwd.Users, oldIgnConfig.Passwd.Users); err != nil {
1245+
if err := dn.updateSSHKeys(oldIgnConfig.Passwd.Users, newIgnConfig.Passwd.Users); err != nil {
12461246
errs := kubeErrs.NewAggregate([]error{err, retErr})
12471247
retErr = fmt.Errorf("error rolling back SSH keys updates: %w", errs)
12481248
return
@@ -1258,7 +1258,7 @@ func (dn *Daemon) update(oldConfig, newConfig *mcfgv1.MachineConfig, skipCertifi
12581258

12591259
defer func() {
12601260
if retErr != nil {
1261-
if err := dn.SetPasswordHash(newIgnConfig.Passwd.Users, oldIgnConfig.Passwd.Users); err != nil {
1261+
if err := dn.SetPasswordHash(oldIgnConfig.Passwd.Users, newIgnConfig.Passwd.Users); err != nil {
12621262
errs := kubeErrs.NewAggregate([]error{err, retErr})
12631263
retErr = fmt.Errorf("error rolling back password hash updates: %w", errs)
12641264
return

0 commit comments

Comments
 (0)