NO-JIRA: Remove unconditional KubeVirt nmstate templates#5893
NO-JIRA: Remove unconditional KubeVirt nmstate templates#5893qinqon wants to merge 1 commit intoopenshift:mainfrom
Conversation
Remove the KubeVirt-specific nmstate configuration files that were applied unconditionally to all KubeVirt-hosted clusters: - 001-nmstate-disable-ipv6-autoconf.yaml (disabled IPv6 SLAAC) - 002-nmstate-arp-proxy-ipv6-gw.yaml (set fe80::1 IPv6 gateway) These configurations are only correct for KubeVirt VMs using the default pod network (OVN-Kubernetes) where IPv6 is assigned via DHCPv6 stateful. When multus is used as the primary network, these break SLAAC and prevent IPv6 address assignment. The HyperShift KubeVirt provider now generates these configurations conditionally based on whether the NodePool uses the default pod network or multus. See openshift/hypershift#8365. Signed-off-by: Enrique Llorente <ellorent@redhat.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@qinqon: This pull request references Jira Issue OCPBUGS-77307, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
WalkthroughTwo nmstate configuration template files are deleted. The first disabled IPv6 autoconfiguration on Ethernet interfaces, and the second configured IPv6 routing via a default gateway on the first captured Ethernet NIC. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Comment |
|
@qinqon: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
- What I did
Removed the KubeVirt-specific nmstate configuration files from
templates/common/kubevirt/files/that were applied unconditionally to all KubeVirt-hosted clusters:001-nmstate-disable-ipv6-autoconf.yaml(disabled IPv6 SLAAC, forced DHCPv6)002-nmstate-arp-proxy-ipv6-gw.yaml(set default IPv6 route viafe80::1ARP proxy)These configurations are only correct for KubeVirt VMs using the default pod network (OVN-Kubernetes). When multus is used as the primary network, they break SLAAC and prevent IPv6 address assignment in dual-stack setups.
The HyperShift KubeVirt provider now owns this configuration and generates it conditionally based on the NodePool's network topology. See the paired PR: openshift/hypershift#8365.
Depends-On: openshift/hypershift#8365
- How to verify it
AttachDefaultNetwork=false)ipv6.method: auto)ipv6.method: dhcpwith autoconf disabled (existing behavior preserved)- Description for the changelog
KubeVirt nmstate network configuration is no longer unconditionally applied; it is now managed conditionally by the HyperShift KubeVirt provider, fixing IPv6 SLAAC failures on multus-based clusters.
Fixes: https://issues.redhat.com/browse/OCPBUGS-77307
Summary by CodeRabbit
Revert