Skip to content

NO-JIRA: Remove unconditional KubeVirt nmstate templates#5893

Draft
qinqon wants to merge 1 commit intoopenshift:mainfrom
qinqon:OCPBUGS-77307-remove-kubevirt-nmstate-templates
Draft

NO-JIRA: Remove unconditional KubeVirt nmstate templates#5893
qinqon wants to merge 1 commit intoopenshift:mainfrom
qinqon:OCPBUGS-77307-remove-kubevirt-nmstate-templates

Conversation

@qinqon
Copy link
Copy Markdown
Contributor

@qinqon qinqon commented Apr 29, 2026

- What I did

Removed the KubeVirt-specific nmstate configuration files from templates/common/kubevirt/files/ that were applied unconditionally to all KubeVirt-hosted clusters:

  • 001-nmstate-disable-ipv6-autoconf.yaml (disabled IPv6 SLAAC, forced DHCPv6)
  • 002-nmstate-arp-proxy-ipv6-gw.yaml (set default IPv6 route via fe80::1 ARP proxy)

These configurations are only correct for KubeVirt VMs using the default pod network (OVN-Kubernetes). When multus is used as the primary network, they break SLAAC and prevent IPv6 address assignment in dual-stack setups.

The HyperShift KubeVirt provider now owns this configuration and generates it conditionally based on the NodePool's network topology. See the paired PR: openshift/hypershift#8365.

Depends-On: openshift/hypershift#8365

- How to verify it

  1. Deploy a dual-stack HCP on KubeVirt with multus as the primary network (AttachDefaultNetwork=false)
  2. Verify nodes get IPv6 addresses via SLAAC (ipv6.method: auto)
  3. Deploy a dual-stack HCP on KubeVirt with the default pod network
  4. Verify nodes still use ipv6.method: dhcp with autoconf disabled (existing behavior preserved)

- Description for the changelog

KubeVirt nmstate network configuration is no longer unconditionally applied; it is now managed conditionally by the HyperShift KubeVirt provider, fixing IPv6 SLAAC failures on multus-based clusters.

Fixes: https://issues.redhat.com/browse/OCPBUGS-77307

Summary by CodeRabbit

Revert

  • Removed IPv6 autoconfiguration management configuration that previously controlled interface-level IPv6 settings
  • Removed IPv6 gateway routing configuration that previously established default IPv6 routes for network interfaces

Remove the KubeVirt-specific nmstate configuration files that were
applied unconditionally to all KubeVirt-hosted clusters:
- 001-nmstate-disable-ipv6-autoconf.yaml (disabled IPv6 SLAAC)
- 002-nmstate-arp-proxy-ipv6-gw.yaml (set fe80::1 IPv6 gateway)

These configurations are only correct for KubeVirt VMs using the
default pod network (OVN-Kubernetes) where IPv6 is assigned via
DHCPv6 stateful. When multus is used as the primary network, these
break SLAAC and prevent IPv6 address assignment.

The HyperShift KubeVirt provider now generates these configurations
conditionally based on whether the NodePool uses the default pod
network or multus. See openshift/hypershift#8365.

Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 29, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@qinqon: This pull request references Jira Issue OCPBUGS-77307, which is invalid:

  • expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

- What I did

Removed the KubeVirt-specific nmstate configuration files from templates/common/kubevirt/files/ that were applied unconditionally to all KubeVirt-hosted clusters:

  • 001-nmstate-disable-ipv6-autoconf.yaml (disabled IPv6 SLAAC, forced DHCPv6)
  • 002-nmstate-arp-proxy-ipv6-gw.yaml (set default IPv6 route via fe80::1 ARP proxy)

These configurations are only correct for KubeVirt VMs using the default pod network (OVN-Kubernetes). When multus is used as the primary network, they break SLAAC and prevent IPv6 address assignment in dual-stack setups.

The HyperShift KubeVirt provider now owns this configuration and generates it conditionally based on the NodePool's network topology. See the paired PR: openshift/hypershift#8365.

Depends-On: openshift/hypershift#8365

- How to verify it

  1. Deploy a dual-stack HCP on KubeVirt with multus as the primary network (AttachDefaultNetwork=false)
  2. Verify nodes get IPv6 addresses via SLAAC (ipv6.method: auto)
  3. Deploy a dual-stack HCP on KubeVirt with the default pod network
  4. Verify nodes still use ipv6.method: dhcp with autoconf disabled (existing behavior preserved)

- Description for the changelog

KubeVirt nmstate network configuration is no longer unconditionally applied; it is now managed conditionally by the HyperShift KubeVirt provider, fixing IPv6 SLAAC failures on multus-based clusters.

Fixes: https://issues.redhat.com/browse/OCPBUGS-77307

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 29, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 29, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026

Walkthrough

Two nmstate configuration template files are deleted. The first disabled IPv6 autoconfiguration on Ethernet interfaces, and the second configured IPv6 routing via a default gateway on the first captured Ethernet NIC.

Changes

Cohort / File(s) Summary
Nmstate Configuration Removal
templates/common/kubevirt/files/001-nmstate-disable-ipv6-autoconf.yaml, templates/common/kubevirt/files/002-nmstate-arp-proxy-ipv6-gw.yaml
Deleted two nmstate inline YAML configuration templates that managed IPv6 settings on Ethernet interfaces, including IPv6 autoconfiguration disabling and IPv6 routing configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This PR removes KubeVirt nmstate YAML configuration files, not Ginkgo test definitions, so the test stability check is not applicable.
Test Structure And Quality ✅ Passed The custom check is designed to assess Ginkgo test code quality, but this PR only removes KubeVirt nmstate template configuration files and does not modify any test code.
Microshift Test Compatibility ✅ Passed This PR only modifies YAML template files in templates/common/kubevirt/files/, removing two nmstate configuration files. No new Ginkgo e2e tests or Go test code are added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR only removes two YAML template configuration files from the KubeVirt templates directory. No new Ginkgo e2e tests are added, making the SNO test compatibility check not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR removes nmstate network configuration files for KubeVirt VMs with no Kubernetes pod scheduling constraints.
Ote Binary Stdout Contract ✅ Passed No Go source code modifications detected in this PR. Only YAML template files were removed, therefore the OTE Binary Stdout Contract check does not apply.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR removes KubeVirt nmstate configuration files without adding new Ginkgo e2e tests, so IPv6 and disconnected network compatibility check conditions do not apply.
Title check ✅ Passed The title accurately describes the main change: removing two unconditional KubeVirt nmstate template files from the codebase.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Comment @coderabbitai help to get the list of available commands and usage tips.

@qinqon qinqon changed the title OCPBUGS-77307: Remove unconditional KubeVirt nmstate templates NO-JIRA: Remove unconditional KubeVirt nmstate templates Apr 29, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@qinqon: This pull request explicitly references no jira issue.

Details

In response to this:

- What I did

Removed the KubeVirt-specific nmstate configuration files from templates/common/kubevirt/files/ that were applied unconditionally to all KubeVirt-hosted clusters:

  • 001-nmstate-disable-ipv6-autoconf.yaml (disabled IPv6 SLAAC, forced DHCPv6)
  • 002-nmstate-arp-proxy-ipv6-gw.yaml (set default IPv6 route via fe80::1 ARP proxy)

These configurations are only correct for KubeVirt VMs using the default pod network (OVN-Kubernetes). When multus is used as the primary network, they break SLAAC and prevent IPv6 address assignment in dual-stack setups.

The HyperShift KubeVirt provider now owns this configuration and generates it conditionally based on the NodePool's network topology. See the paired PR: openshift/hypershift#8365.

Depends-On: openshift/hypershift#8365

- How to verify it

  1. Deploy a dual-stack HCP on KubeVirt with multus as the primary network (AttachDefaultNetwork=false)
  2. Verify nodes get IPv6 addresses via SLAAC (ipv6.method: auto)
  3. Deploy a dual-stack HCP on KubeVirt with the default pod network
  4. Verify nodes still use ipv6.method: dhcp with autoconf disabled (existing behavior preserved)

- Description for the changelog

KubeVirt nmstate network configuration is no longer unconditionally applied; it is now managed conditionally by the HyperShift KubeVirt provider, fixing IPv6 SLAAC failures on multus-based clusters.

Fixes: https://issues.redhat.com/browse/OCPBUGS-77307

Summary by CodeRabbit

Revert

  • Removed IPv6 autoconfiguration management configuration that previously controlled interface-level IPv6 settings
  • Removed IPv6 gateway routing configuration that previously established default IPv6 routes for network interfaces

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants