Skip to content

ROSA-745: boilerplate-update and enable MintMaker gomod#359

Closed
MitaliBhalla wants to merge 1 commit into
openshift:masterfrom
MitaliBhalla:rosa-745-mintmaker-gomod
Closed

ROSA-745: boilerplate-update and enable MintMaker gomod#359
MitaliBhalla wants to merge 1 commit into
openshift:masterfrom
MitaliBhalla:rosa-745-mintmaker-gomod

Conversation

@MitaliBhalla

@MitaliBhalla MitaliBhalla commented Jun 12, 2026

Copy link
Copy Markdown

Summary

  • make boilerplate-update (includes boilerplate #748 dependabot template)
  • .github/renovate.jsonenabledManagers: [tekton, gomod] for MintMaker gomod PRs

Test plan

  • CI green

Jira: ROSA-745

Summary by CodeRabbit

  • Chores
    • Expanded Renovate settings to cover additional dependency managers, helping keep more project dependencies up to date automatically.
    • Cleaned up the configuration structure for improved consistency.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 12, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 12, 2026

Copy link
Copy Markdown

@MitaliBhalla: This pull request references ROSA-745 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the initiative to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • make boilerplate-update (includes boilerplate #748 dependabot template)
  • .github/renovate.jsonenabledManagers: [tekton, gomod] for MintMaker gomod PRs

Test plan

  • CI green

Jira: ROSA-745

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0970f3c9-6e33-49be-8e8b-4f6ec7c27293

📥 Commits

Reviewing files that changed from the base of the PR and between a386e12 and 5b769b9.

📒 Files selected for processing (1)
  • .github/renovate.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/renovate.json

Walkthrough

The pull request modifies the Renovate configuration file to add an enabledManagers array that explicitly enables the tekton and gomod managers, following a proper closure of the existing extends array.

Changes

Renovate Configuration Update

Layer / File(s) Summary
Enable tekton and gomod managers
.github/renovate.json
Closes the extends array and adds a new enabledManagers array configuring Renovate to enable the tekton and gomod managers.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Related PRs: None identified.

Suggested labels: dependencies, configuration

Suggested reviewers: None identified.


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Ote Binary Stdout Contract ❌ Error fips.go adds init() stdout via fmt.Println, which violates the JSON-on-stdout contract for process-level code. Move the banner to os.Stderr or remove it; avoid any stdout writes in init/main/suite setup.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the PR’s main changes: boilerplate update and enabling gomod for MintMaker.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only .github/renovate.json changed; no Ginkgo test titles were added or edited, so the stable-title rule is unaffected.
Test Structure And Quality ✅ Passed Only .github/renovate.json changed versus origin/master; no Ginkgo test files or test logic were modified, so the check is not applicable.
Microshift Test Compatibility ✅ Passed Only .github/renovate.json changed; no new Ginkgo e2e tests or MicroShift-unsafe APIs were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only .github/renovate.json changed; no Ginkgo/e2e tests were added, so SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only .github/renovate.json changed; no deployment manifests, operator code, or controllers were modified, so no new scheduling constraints were introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new e2e test code was added; the only Ginkgo/It snippets are documentation in TESTING.md, and the PR’s functional change is Renovate config.
No-Weak-Crypto ✅ Passed The only relevant change is .github/renovate.json, which adds Renovate managers and contains no crypto code or weak-cipher usage.
Container-Privileges ✅ Passed Changed manifests and repo-wide scans show no privileged, hostPID/Network/IPC, allowPrivilegeEscalation, SYS_ADMIN, or root-user settings.
No-Sensitive-Data-In-Logs ✅ Passed Only .github/renovate.json was changed, and it contains no log statements or sensitive literals.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MitaliBhalla
Once this PR has been reviewed and has the lgtm label, please assign clcollins for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 13.05%. Comparing base (f7710a9) to head (a386e12).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #359   +/-   ##
=======================================
  Coverage   13.05%   13.05%           
=======================================
  Files          15       15           
  Lines        1141     1141           
=======================================
  Hits          149      149           
  Misses        979      979           
  Partials       13       13           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MitaliBhalla

Copy link
Copy Markdown
Author

/retest-required

@MitaliBhalla MitaliBhalla force-pushed the rosa-745-mintmaker-gomod branch from 02a815b to a386e12 Compare June 12, 2026 09:50
@MitaliBhalla

Copy link
Copy Markdown
Author

/retest-required

@MitaliBhalla

Copy link
Copy Markdown
Author

/test pull-ci-openshift-managed-velero-operator-master-coverage

@MitaliBhalla

Copy link
Copy Markdown
Author

/test coverage

Add enabledManagers tekton/gomod in renovate.json; boilerplate-update
when no equivalent upstream PR is already open.
@MitaliBhalla MitaliBhalla force-pushed the rosa-745-mintmaker-gomod branch from a386e12 to 5b769b9 Compare July 1, 2026 06:49
@MitaliBhalla

MitaliBhalla commented Jul 1, 2026

Copy link
Copy Markdown
Author

Refreshed branch: minimal ROSA-745 diff (renovate enabledManagers; boilerplate-update only if no parallel boilerplate PR).

@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

@MitaliBhalla: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@MitaliBhalla

MitaliBhalla commented Jul 1, 2026

Copy link
Copy Markdown
Author

Closing ROSA-745 fleet PR — superseded by corrected rollout plan.

Problem: these PRs bundled redundant repo-root enabledManagers (already inherited via extends openshift/boilerplate #748), unnecessary boilerplate churn, and PKO/fixture noise. A fresh minimal PR per repo will follow the correct model.

Jira: ROSA-745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants