-
Notifications
You must be signed in to change notification settings - Fork 453
OCPEDGE-2416: Add oc adm transition topology command for SNO to HA transitions #2295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jaypoulz
wants to merge
2
commits into
openshift:main
Choose a base branch
from
jaypoulz:OCPEDGE-2416-oc-adm-transition
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| package transition | ||
|
|
||
| import ( | ||
| configv1 "github.com/openshift/api/config/v1" | ||
| ) | ||
|
|
||
| // Kubernetes and OpenShift resource names | ||
| const ( | ||
| // InfrastructureResourceName is the name of the cluster-scoped Infrastructure resource | ||
| InfrastructureResourceName = "cluster" | ||
|
|
||
| // EtcdOperatorResourceName is the name of the cluster-scoped Etcd operator resource | ||
| EtcdOperatorResourceName = "cluster" | ||
|
|
||
| // EtcdNamespace is the namespace where etcd resources are located | ||
| EtcdNamespace = "openshift-etcd" | ||
|
|
||
| // EtcdEndpointsConfigMapName is the name of the ConfigMap containing etcd endpoints | ||
| EtcdEndpointsConfigMapName = "etcd-endpoints" | ||
| ) | ||
|
|
||
| // ClusterOperator condition types | ||
| const ( | ||
| // ClusterOperatorAvailable indicates the operand is available | ||
| ClusterOperatorAvailable configv1.ClusterStatusConditionType = configv1.OperatorAvailable | ||
|
|
||
| // ClusterOperatorProgressing indicates the operand is being updated | ||
| ClusterOperatorProgressing configv1.ClusterStatusConditionType = configv1.OperatorProgressing | ||
|
|
||
| // ClusterOperatorDegraded indicates the operand is degraded | ||
| ClusterOperatorDegraded configv1.ClusterStatusConditionType = configv1.OperatorDegraded | ||
| ) | ||
|
|
||
| // Etcd operator condition types | ||
| const ( | ||
| // EtcdMembersAvailableCondition indicates etcd has quorum | ||
| EtcdMembersAvailableCondition = "EtcdMembersAvailable" | ||
| ) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Add a unit test for the feature-gated command registration.
This branch decides whether
oc adm topologyexists at all, so it should have a small table-drivenNewCommandAdmintest covering the gate enabled/disabled cases. As per coding guidelines, "Write unit tests for every change."🤖 Prompt for AI Agents
Source: Coding guidelines