CQA for authentication

Author: jc-berger

authentication/assuming-an-aws-iam-role-for-a-service-account.adoc

@@ -1,6 +1,6 @@
 :_mod-docs-content-type: ASSEMBLY
 [id="assuming-an-aws-iam-role-for-a-service-account"]
-= Assuming an AWS IAM role for a service account
+= Assume an AWS IAM role for a service account
 
 include::_attributes/common-attributes.adoc[]
 ifdef::openshift-rosa,openshift-dedicated,openshift-rosa-hcp[]
@@ -34,7 +34,7 @@ include::modules/deploying-a-pod-that-includes-an-aws-sdk.adoc[leveloffset=+2]
 include::modules/verifying-the-assumed-iam-role-in-your-pod.adoc[leveloffset=+2]
 
 [role="_additional-resources"]
-[id="additional-resources_configuring-alert-notifications"]
+[id="additional-resources_{context}"]
 == Additional resources
 
 * link:https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts.html[AWS documentation on IAM roles for service accounts]

authentication/osd-admin-roles.adoc

@@ -1,6 +1,6 @@
 :_mod-docs-content-type: ASSEMBLY
 [id="osd-admin-roles"]
-= Managing administration roles and users
+= Manage administration roles and users
 include::_attributes/attributes-openshift-dedicated.adoc[]
 
 :context: osd-admin-roles

authentication/osd-revoking-cluster-privileges.adoc

@@ -1,6 +1,6 @@
 :_mod-docs-content-type: ASSEMBLY
 [id="osd-revoking-cluster-privileges"]
-= Revoking privileges and access to an {product-title} cluster
+= Revoke privileges and access to an {product-title} cluster
 
 include::_attributes/attributes-openshift-dedicated.adoc[]
 :context: osd-revoking-cluster-privileges

authentication/sd-configuring-identity-providers.adoc

@@ -26,7 +26,7 @@ include::modules/config-htpasswd-idp-webui.adoc[leveloffset=+2]
 include::modules/config-htpasswd-idp-from-file.adoc[leveloffset=+2]
 ifdef::openshift-rosa-hcp,openshift-rosa[]
 include::modules/rosa-config-htpasswd-idp-cli.adoc[leveloffset=+2]
-include::modules/rosa-config-htpasswd-idp-cli-file.adoc[leveloffset=+3]
+include::modules/rosa-config-htpasswd-idp-cli-file.adoc[leveloffset=+2]
 include::modules/config-htpasswd-idp-terraform.adoc[leveloffset=+2]
 endif::openshift-rosa-hcp,openshift-rosa[]
 ifdef::openshift-dedicated[]
@@ -43,5 +43,5 @@ ifdef::openshift-rosa[]
 * xref:../rosa_getting_started/rosa-sts-getting-started-workflow.adoc#rosa-sts-understanding-the-deployment-workflow[Understanding the ROSA with STS deployment workflow]
 endif::openshift-rosa[]
 * link:https://httpd.apache.org/docs/current/misc/password_encryptions.html[Apache Password Formats]
-* link:https://developers.google.com/identity/protocols/OpenIDConnect[Google's OpenID Connect integration]
-* link:http://openid.net/specs/openid-connect-core-1_0.html#CodeFlowAuth[Authorization Code Flow]
+* link:https://developers.google.com/identity/protocols/OpenIDConnect[Google OpenID Connect integration]
+* link:https://openid.net/specs/openid-connect-core-1_0.html#CodeFlowAuth[Authorization Code Flow]

cloud_experts_tutorials/cloud-experts-getting-started/cloud-experts-getting-started-idp.adoc

@@ -8,7 +8,7 @@ include::_attributes/attributes-openshift-dedicated.adoc[]
 toc::[]
 
 [role="_abstract"]
-To log in to your cluster, set up an identity provider (IDP). This tutorial uses GitHub as an example IDP. See the full list of xref:../../rosa_install_access_delete_clusters/rosa-sts-config-identity-providers.adoc#understanding-idp-supported_rosa-sts-config-identity-providers[IDPs supported by ROSA].
+To log in to your cluster, set up an identity provider (IDP). This tutorial uses GitHub as an example IDP. See the full list of xref:../../rosa_install_access_delete_clusters/rosa-sts-config-identity-providers.adoc#understanding-idp_rosa-sts-config-identity-providers[IDPs supported by ROSA].
 
 
 include::modules/cloud-experts-getting-started-idp-creating.adoc[leveloffset=+1]

modules/assuming-an-aws-iam-role-in-your-own-pods.adoc

@@ -4,7 +4,7 @@
 
 :_mod-docs-content-type: CONCEPT
 [id="assuming-an-aws-iam-role-in-your-own-pods_{context}"]
-= Assuming an AWS IAM role in your own pods
+= About assuming AWS IAM roles in your own pods
 
 [role="_abstract"]
 You can enable a service account to assume an AWS Identity and Access Management (IAM) role in a pod deployed in a user-defined project.

modules/authentication-overview.adoc

@@ -26,7 +26,7 @@ If you do not present a valid access token or certificate, your request is unaut
 ====
 
 ifdef::openshift-dedicated,openshift-rosa,openshift-rosa-hcp[]
-An administrator can configure authentication by configuring an identity provider. You can define any xref:../authentication/sd-configuring-identity-providers.adoc#understanding-idp-supported_sd-configuring-identity-providers[supported identity provider in {product-title}] and add it to your cluster.
+An administrator can configure authentication by configuring an identity provider. You can define any xref:../authentication/sd-configuring-identity-providers.adoc#understanding-idp_sd-configuring-identity-providers[supported identity provider in {product-title}] and add it to your cluster.
 endif::openshift-dedicated,openshift-rosa,openshift-rosa-hcp[]
 
 ifndef::openshift-dedicated,openshift-rosa,openshift-rosa-hcp[]

modules/config-github-idp.adoc

@@ -5,10 +5,10 @@
 
 :_mod-docs-content-type: PROCEDURE
 [id="config-github-idp_{context}"]
-= Configuring a GitHub identity provider
+= Configure a GitHub identity provider
 
 [role="_abstract"]
-Configure a GitHub identity provider to validate user names and passwords against GitHub or GitHub Enterprise's OAuth authentication server and access your {product-title} cluster. OAuth facilitates a token exchange flow between {product-title} and GitHub or GitHub Enterprise.
+Configure a GitHub identity provider to validate user names and passwords against the GitHub or GitHub Enterprise OAuth authentication server and access your {product-title} cluster. OAuth facilitates a token exchange flow between {product-title} and GitHub or GitHub Enterprise.
 
 [WARNING]
 ====
@@ -17,7 +17,7 @@ Configuring GitHub authentication allows users to log in to {product-title} with
 
 .Prerequisites
 
-* The OAuth application must be created directly within the GitHub link:https://docs.github.com/en/github/setting-up-and-managing-organizations-and-teams/managing-organization-settings[organization settings] by the GitHub organization administrator.
+* The OAuth application is created directly within the GitHub link:https://docs.github.com/en/github/setting-up-and-managing-organizations-and-teams/managing-organization-settings[organization settings] by the GitHub organization administrator.
 * link:https://docs.github.com/en/github/setting-up-and-managing-organizations-and-teams[GitHub organizations or teams] are set up in your GitHub account.
 
 .Procedure
@@ -30,13 +30,13 @@ Configuring GitHub authentication allows users to log in to {product-title} with
 +
 [NOTE]
 ====
-You can also click the *Add Oauth configuration* link in the warning message displayed after cluster creation to configure your identity providers.
+You can also click the *Add OAuth configuration* link in the warning message displayed after cluster creation to configure your identity providers.
 ====
 
 . Select *GitHub* from the drop-down menu.
 
 . Enter a unique name for the identity provider. This name cannot be changed later.
-** An *OAuth callback URL* is automatically generated in the provided field. You will use this to register the GitHub application.
+** An *OAuth callback URL* is automatically generated in the provided field. Use this URL to register the GitHub application.
 +
 ----
 https://oauth-openshift.apps.<cluster_name>.<cluster_domain>/oauth2callback/<idp_provider_name>

modules/config-gitlab-idp.adoc

@@ -5,14 +5,14 @@
 
 :_mod-docs-content-type: PROCEDURE
 [id="config-gitlab-idp_{context}"]
-= Configuring a GitLab identity provider
+= Configure a GitLab identity provider
 
 [role="_abstract"]
-Configure a GitLab identity provider to use link:https://gitlab.com/[GitLab.com] or any other GitLab instance as an identity provider.
+Configure a GitLab identity provider to use `gitlab.com` or any other GitLab instance so that users can log in to your cluster with their GitLab credentials.
 
 .Prerequisites
 
-- If you use GitLab version 7.7.0 to 11.0, you connect using the link:http://doc.gitlab.com/ce/integration/oauth_provider.html[OAuth integration]. If you use GitLab version 11.1 or later, you can use link:https://docs.gitlab.com/ce/integration/openid_connect_provider.html[OpenID Connect] (OIDC) to connect instead of OAuth.
+* If you use GitLab version 7.7.0 to 11.0, you connect using the link:https://docs.gitlab.com/ee/integration/oauth_provider.html[OAuth integration]. If you use GitLab version 11.1 or later, you can use link:https://docs.gitlab.com/ee/integration/openid_connect_provider.html[OpenID Connect] (OIDC) to connect instead of OAuth.
 
 .Procedure
 
@@ -24,13 +24,13 @@ Configure a GitLab identity provider to use link:https://gitlab.com/[GitLab.com]
 +
 [NOTE]
 ====
-You can also click the *Add Oauth configuration* link in the warning message displayed after cluster creation to configure your identity providers.
+You can also click the *Add OAuth configuration* link in the warning message displayed after cluster creation to configure your identity providers.
 ====
 
 . Select *GitLab* from the drop-down menu.
 
 . Enter a unique name for the identity provider. This name cannot be changed later.
-** An *OAuth callback URL* is automatically generated in the provided field. You will provide this URL to GitLab.
+** An *OAuth callback URL* is automatically generated in the provided field. Provide this URL to GitLab.
 +
 ifndef::openshift-rosa-hcp[]
 ----

modules/config-google-idp.adoc

@@ -5,16 +5,14 @@
 
 :_mod-docs-content-type: PROCEDURE
 [id="config-google-idp_{context}"]
-= Configuring a Google identity provider
+= Configure a Google identity provider
 
 [role="_abstract"]
 Configure a Google identity provider to allow users to authenticate with their Google credentials.
 
 [WARNING]
 ====
-Using Google as an identity provider allows any Google user to authenticate to your server.
-You can limit authentication to members of a specific hosted domain with the
-`hostedDomain` configuration attribute.
+Using Google as an identity provider allows any Google user to authenticate to your server. You can limit authentication to members of a specific hosted domain with the `hostedDomain` configuration attribute.
 ====
 
 .Procedure
@@ -27,13 +25,13 @@ You can limit authentication to members of a specific hosted domain with the
 +
 [NOTE]
 ====
-You can also click the *Add Oauth configuration* link in the warning message displayed after cluster creation to configure your identity providers.
+You can also click the *Add OAuth configuration* link in the warning message displayed after cluster creation to configure your identity providers.
 ====
 
 . Select *Google* from the drop-down menu.
 
 . Enter a unique name for the identity provider. This name cannot be changed later.
-** An *OAuth callback URL* is automatically generated in the provided field. You will provide this URL to Google.
+** An *OAuth callback URL* is automatically generated in the provided field. Provide this URL to Google.
 +
 ifndef::openshift-rosa-hcp[]
 ----
@@ -52,7 +50,7 @@ For example:
 https://oauth-openshift.apps.openshift-cluster.example.com/oauth2callback/google
 ----
 
-. Configure a Google identity provider using link:https://developers.google.com/identity/protocols/OpenIDConnect[Google's OpenID Connect integration].
+. Configure a Google identity provider using link:https://developers.google.com/identity/protocols/OpenIDConnect[Google OpenID Connect integration].
 
 . Return to {product-title} and select a mapping method from the drop-down menu. *Claim* is recommended in most cases.