Skip to content

Commit fbafe83

Browse files
authored
Merge pull request #112922 from sbeskin-redhat/CNV_78861_CD_ROM_eject_inject_as_GA_feature
CNV-78861: CD-ROM eject/insert is GA
2 parents 52677ec + 432f76f commit fbafe83

4 files changed

Lines changed: 9 additions & 11 deletions

modules/virt-inserting-a-cd-rom-in-a-vm-by-using-the-command-line.adoc

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@ To make data on a CD-ROM storage device available to a running virtual machine (
1515
Setting up a virtual CD-ROM drive requires rebooting the VM, but afterwards, you can insert and eject ISO images in the drive while the VM is running.
1616
// See https://kubevirt.io/user-guide/storage/hotplug_volumes/#inject-cd-rom for upstream info
1717

18-
:FeatureName: Inserting and ejecting CD-ROMs in running VMs
19-
include::snippets/technology-preview.adoc[]
20-
2118
.Prerequisites
2219

2320
include::snippets/virt-cdrom-feature-gate-requirements.adoc[]

modules/virt-inserting-a-cd-rom-in-a-vm-by-using-the-web-console.adoc

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,6 @@ To make data on a CD-ROM storage device available to a running virtual machine (
1414

1515
Setting up a virtual CD-ROM drive requires rebooting the VM, but you can insert and eject ISO images in the drive while the VM is running.
1616

17-
:FeatureName: Inserting and ejecting CD-ROMs in running VMs
18-
include::snippets/technology-preview.adoc[]
19-
2017
.Prerequisites
2118

2219
include::snippets/virt-cdrom-feature-gate-requirements.adoc[]

snippets/virt-cdrom-feature-gate-requirements.adoc

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
:_mod-docs-content-type: SNIPPET
77

8-
* The `DeclarativeHotplugVolumes` feature gate must be enabled. To ensure this, the `HyperConverged` CR must contain the `declarativeHotplugVolumes: true` line in the `spec.featureGates` configuration section:
8+
* The `DeclarativeHotplugVolumes` feature gate is enabled. To ensure this, the `HyperConverged` CR must contain the `declarativeHotplugVolumes: true` line in the `spec.featureGates` configuration section:
99
+
1010
[source,yaml,subs="attributes+"]
1111
----
@@ -18,8 +18,13 @@ spec:
1818
featureGates:
1919
declarativeHotplugVolumes: true
2020
----
21+
+
22+
[NOTE]
23+
====
24+
The `DeclarativeHotplugVolumes` feature gate does not support hot plugging ephemeral volumes.
25+
====
2126
22-
* The `HotplugVolumes` feature gate must be disabled. This feature gate is required for using ephemeral volumes, but is incompatible with `DeclarativeHotplugVolumes`.
27+
* The `HotplugVolumes` feature gate is disabled. It is incompatible with `DeclarativeHotplugVolumes` and is deprecated.
2328
+
2429
[source,yaml,subs="attributes+"]
2530
----
@@ -32,3 +37,5 @@ spec:
3237
featureGates:
3338
HotplugVolumes: false
3439
----
40+
41+

virt/managing_vms/virtual_disks/virt-inserting-cd-roms-in-virtual-machines.adoc

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@ To attach a storage device to a virtual machine (VM) without rebooting the VM, y
1515

1616
This also makes it possible to install an operating system from a CD-ROM in the VM.
1717

18-
:FeatureName: Inserting and ejecting CD-ROMs in running VMs
19-
include::snippets/technology-preview.adoc[]
20-
2118
include::modules/virt-inserting-a-cd-rom-in-a-vm-by-using-the-command-line.adoc[leveloffset=+1]
2219

2320
include::modules/virt-inserting-a-cd-rom-in-a-vm-by-using-the-web-console.adoc[leveloffset=+1]

0 commit comments

Comments
 (0)