Skip to content

OSDOCS-18730 [NETOBSERV] Fix new Vale rule: ConceptLink#108337

Open
gwynnemonahan wants to merge 1 commit intoopenshift:mainfrom
gwynnemonahan:OSDOCS-18730
Open

OSDOCS-18730 [NETOBSERV] Fix new Vale rule: ConceptLink#108337
gwynnemonahan wants to merge 1 commit intoopenshift:mainfrom
gwynnemonahan:OSDOCS-18730

Conversation

@gwynnemonahan
Copy link
Copy Markdown
Contributor

@gwynnemonahan gwynnemonahan commented Mar 13, 2026

OSDOCS-18730 [NETOBSERV] Fix new Vale rule: ConceptLink

Version(s):
4.16+ as it is migration related

Issue:
https://issues.redhat.com/browse/OSDOCS-18730

Link to docs preview:

QE review:
QE is not required for this PR.

Additional information:

  • modules/network-observability-creating-metrics-network-events.adoc will fail on 4.16, 4.19+ because it only applies to 4.17 and 4.18. For some reason, the change is not reflected in main when it was made.

@openshift-ci openshift-ci Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 13, 2026
Comment thread observability/network_observability/network-observability-health-rules.adoc Outdated
@openshift-ci openshift-ci Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 20, 2026
Comment thread modules/network-observability-important-flowcollector-considerations.adoc Outdated
Comment thread modules/network-observability-important-flowcollector-considerations.adoc Outdated
Comment thread modules/network-observability-important-flowcollector-considerations.adoc Outdated
Comment thread modules/network-observability-important-flowcollector-considerations.adoc Outdated
Comment thread modules/network-observability-important-flowcollector-considerations.adoc Outdated
Comment thread modules/network-observability-important-flowcollector-considerations.adoc Outdated
Comment thread modules/network-observability-important-flowcollector-considerations.adoc Outdated
Comment thread modules/network-observability-important-flowcollector-considerations.adoc Outdated
Comment thread modules/network-observability-important-flowcollector-considerations.adoc Outdated
Comment thread modules/network-observability-important-flowcollector-considerations.adoc Outdated
Comment thread modules/network-observability-important-flowcollector-considerations.adoc Outdated
@gwynnemonahan
Copy link
Copy Markdown
Contributor Author

This may be on hold.

@gwynnemonahan
Copy link
Copy Markdown
Contributor Author

Rebased 04/23/2026

@gwynnemonahan
Copy link
Copy Markdown
Contributor Author

Rebase 04/23/2026 to pick up changes from #109361

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 23, 2026

@gwynnemonahan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants