Skip to content

OSSM 9894_DNS capture#110676

Merged
briandooley merged 1 commit intoopenshift:service-mesh-docs-3.0from
lhite8041:OSSM_9894_DNS
Apr 24, 2026
Merged

OSSM 9894_DNS capture#110676
briandooley merged 1 commit intoopenshift:service-mesh-docs-3.0from
lhite8041:OSSM_9894_DNS

Conversation

@lhite8041
Copy link
Copy Markdown

@lhite8041 lhite8041 commented Apr 23, 2026 •
edited
Loading

OSSM-9894: behavior change between OSSM 2.x and 3.x

PEER REVIEWER: Please note that this new module follows an established pattern in a migration guide that probably doesn't have a very long shelf life.

Version(s):
service-mesh-docs-3.0

Issue:
https://redhat.atlassian.net/browse/OSSM-9894

Link to docs preview:
https://110676--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/migrating/checklists/ossm-migrating-read-me.html#ossm-migrating-read-me-dns-capture-configuration_ossm-migrating-read-me

QE review:

  • QE has approved this change.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 23, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 23, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 23, 2026
@lhite8041 lhite8041 marked this pull request as ready for review April 23, 2026 12:33
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 23, 2026
@ocpdocs-previewbot
Copy link
Copy Markdown

ocpdocs-previewbot commented Apr 23, 2026 •
edited
Loading

🤖 Fri Apr 24 12:48:32 - Prow CI generated the docs preview:

https://110676--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/migrating/checklists/ossm-migrating-read-me.html

sridhargaddam
sridhargaddam reviewed Apr 23, 2026
View reviewed changes
Comment thread modules/ossm-migrating-read-me-dns-capture-configuration.adoc Outdated
rh-tokeefe
rh-tokeefe reviewed Apr 23, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@rh-tokeefe rh-tokeefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks pretty good, @lhite8041. You might want to consider updating the short description.

https://redhat-documentation.github.io/supplementary-style-guide/#shortdesc

Comment thread modules/ossm-migrating-read-me-dns-capture-configuration.adoc Outdated
sridhargaddam
sridhargaddam approved these changes Apr 24, 2026
View reviewed changes
Copy link
Copy Markdown

@sridhargaddam sridhargaddam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you @lhite8041

@lhite8041 @claude
Document DNS capture configuration for ServiceEntry resources
11b14de 
Added new module documenting the requirement to explicitly configure
DNS capture when migrating from Service Mesh 2.6 to 3.0 if using
ServiceEntry resources for external services.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 24, 2026

@lhite8041: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@briandooley briandooley merged commit 7af5dda into openshift:service-mesh-docs-3.0 Apr 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rh-tokeefe rh-tokeefe rh-tokeefe left review comments

+2 more reviewers

@dgn dgn dgn approved these changes

@sridhargaddam sridhargaddam sridhargaddam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lhite8041 @ocpdocs-previewbot @dgn @sridhargaddam @rh-tokeefe @briandooley