add time out for request.get()#113712
Open
jldohmann wants to merge 1 commit into
Open
Conversation
openshift-ci
Bot
added
the
size/XS
|
🤖 Fri Jun 19 00:47:20 - Prow CI generated the docs preview: |
|
@jldohmann: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version(s): at least 4.22+
Issue: https://redhat.atlassian.net/browse/OSDOCS-20123
Additional information: this PR adds a 30s timeout to
requests.get()to prevent indefinite hangs when fetching remote GH includes when dealing with slow or broken IPv6 connectivity. without this, the script hangs unless interrupted. this is affecting ROSA classic docs builds that, since releasing 4.22, require fetching multiple remote files sequentially in the same.adocfile