Skip to content

OSDOCS-16411 [ROSA & OSD]: CQA for authentication - #116731

Merged
jldohmann merged 1 commit into
openshift:mainfrom
jc-berger:jcberger-cqa-authentication
Aug 3, 2026
Merged

OSDOCS-16411 [ROSA & OSD]: CQA for authentication#116731
jldohmann merged 1 commit into
openshift:mainfrom
jc-berger:jcberger-cqa-authentication

Conversation

@openshift-ci openshift-ci Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 28, 2026
@ocpdocs-previewbot

ocpdocs-previewbot commented Jul 28, 2026

Copy link
Copy Markdown

🤖 Fri Jul 31 14:44:05 - Prow CI generated the docs preview:
https://116731--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@jc-berger jc-berger changed the title OSDOCS-16411 [ROSA]: CQA for authentication OSDOCS-16411 [ROSA & OSD]: CQA for authentication Jul 28, 2026
@jc-berger
jc-berger force-pushed the jcberger-cqa-authentication branch 3 times, most recently from 2ba3f97 to 1f40a5c Compare July 30, 2026 15:32
Comment thread authentication/assuming-an-aws-iam-role-for-a-service-account.adoc Outdated
Comment thread modules/config-github-idp.adoc Outdated
@jc-berger
jc-berger force-pushed the jcberger-cqa-authentication branch from 4f90641 to 825d62b Compare July 30, 2026 19:42
Comment thread modules/config-gitlab-idp.adoc Outdated
Comment thread modules/deploying-a-pod-that-includes-an-aws-sdk.adoc Outdated
Comment thread modules/deploying-a-pod-that-includes-an-aws-sdk.adoc Outdated
Comment thread modules/creating-an-example-aws-sdk-container-image.adoc Outdated
Comment thread modules/deploying-a-pod-that-includes-an-aws-sdk.adoc Outdated
Comment thread modules/verifying-the-assumed-iam-role-in-your-pod.adoc Outdated
Comment thread modules/verifying-the-assumed-iam-role-in-your-pod.adoc Outdated
Comment thread modules/understanding-idp.adoc Outdated
Comment thread modules/understanding-idp.adoc Outdated
Comment thread modules/understanding-admin-roles.adoc Outdated
Comment thread modules/config-ldap-idp.adoc Outdated
Comment thread modules/config-ldap-idp.adoc Outdated
Comment thread modules/assuming-an-aws-iam-role-in-your-own-pods.adoc Outdated
Comment thread modules/sd-config-htpasswd-idp-cli.adoc Outdated
Comment thread modules/sd-config-htpasswd-idp-cli.adoc Outdated
Comment thread modules/config-google-idp.adoc Outdated
Comment thread modules/understanding-idp.adoc Outdated
@otikhomi

Copy link
Copy Markdown
Contributor

@jc-berger Done. Thank for the epic and clean work. Most suggestions are minor, optional and abbreviations/attributes-related which are nice-to-haves at the moment.

In general, I believe, there're more abbreviations that aren't expanded on the first use, I haven't checked that thoroughly, only commented on random ones I saw. And I know that AI often misses those. Up to you whether you prefer to search for these now or later, with the Quality tab updates.

I'm surprised that the local Vale bot hasn't suggested using {cluster-manager}, I remember it usually told me to do so.

Comment thread modules/understanding-idp.adoc Outdated
@jc-berger
jc-berger force-pushed the jcberger-cqa-authentication branch from 4340273 to 092d7ec Compare July 31, 2026 14:34

[role="_abstract"]
To log in to your cluster, set up an identity provider (IDP). This tutorial uses GitHub as an example IDP. See the full list of xref:../../rosa_install_access_delete_clusters/rosa-sts-config-identity-providers.adoc#understanding-idp-supported_rosa-sts-config-identity-providers[IDPs supported by ROSA].
To log in to your cluster, set up an identity provider (IDP). This tutorial uses GitHub as an example IDP. See the full list of xref:../../rosa_install_access_delete_clusters/rosa-sts-config-identity-providers.adoc#understanding-idp_rosa-sts-config-identity-providers[IDPs supported by ROSA].

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] AsciiDocDITA.ConceptLink: Move all links and cross references to Additional resources.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's from Classic Tutorials, we haven't CQA-ed them yet but will fix this soon.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this preview? i would like to ensure the xref works but this tutorial doesn't seem to be listed in the tutorials section and isn't in any of the previews

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread modules/authentication-overview.adoc
@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown

@jc-berger: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jldohmann jldohmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! LGTM, but i would like to check one xref that i didn't see a preview link for the file its in. see comment below


[role="_abstract"]
To log in to your cluster, set up an identity provider (IDP). This tutorial uses GitHub as an example IDP. See the full list of xref:../../rosa_install_access_delete_clusters/rosa-sts-config-identity-providers.adoc#understanding-idp-supported_rosa-sts-config-identity-providers[IDPs supported by ROSA].
To log in to your cluster, set up an identity provider (IDP). This tutorial uses GitHub as an example IDP. See the full list of xref:../../rosa_install_access_delete_clusters/rosa-sts-config-identity-providers.adoc#understanding-idp_rosa-sts-config-identity-providers[IDPs supported by ROSA].

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this preview? i would like to ensure the xref works but this tutorial doesn't seem to be listed in the tutorials section and isn't in any of the previews

@jldohmann jldohmann added this to the Continuous Release milestone Aug 1, 2026
@jldohmann
jldohmann merged commit 2f112ee into openshift:main Aug 3, 2026
2 checks passed
@jldohmann

Copy link
Copy Markdown
Contributor

/cherrypick enterprise-5.0

@jldohmann

Copy link
Copy Markdown
Contributor

/cherrypick enterprise-4.22

@jldohmann

Copy link
Copy Markdown
Contributor

/cherrypick enterprise-4.21

@jldohmann

Copy link
Copy Markdown
Contributor

/cherrypick enterprise-4.20

@openshift-cherrypick-robot

Copy link
Copy Markdown

@jldohmann: new pull request created: #117191

Details

In response to this:

/cherrypick enterprise-5.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

Copy link
Copy Markdown

@jldohmann: new pull request created: #117192

Details

In response to this:

/cherrypick enterprise-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

Copy link
Copy Markdown

@jldohmann: new pull request created: #117193

Details

In response to this:

/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

Copy link
Copy Markdown

@jldohmann: #116731 failed to apply on top of branch "enterprise-4.20":

Applying: CQA for authentication
Using index info to reconstruct a base tree...
M	authentication/assuming-an-aws-iam-role-for-a-service-account.adoc
M	authentication/osd-admin-roles.adoc
M	authentication/osd-revoking-cluster-privileges.adoc
M	authentication/sd-configuring-identity-providers.adoc
M	cloud_experts_tutorials/cloud-experts-getting-started/cloud-experts-getting-started-idp.adoc
M	modules/assuming-an-aws-iam-role-in-your-own-pods.adoc
M	modules/config-github-idp.adoc
M	modules/config-gitlab-idp.adoc
M	modules/config-google-idp.adoc
A	modules/config-htpasswd-idp-terraform.adoc
M	modules/config-ldap-idp.adoc
M	modules/config-openid-idp.adoc
M	modules/creating-a-service-account-in-your-project.adoc
M	modules/creating-an-example-aws-sdk-container-image.adoc
M	modules/deploying-a-pod-that-includes-an-aws-sdk.adoc
M	modules/identity-provider-parameters.adoc
M	modules/managing-dedicated-administrators.adoc
M	modules/osd-revoke-admin-privileges.adoc
M	modules/osd-revoke-user-access.adoc
A	modules/rosa-config-htpasswd-idp-cli-file.adoc
A	modules/rosa-config-htpasswd-idp-cli.adoc
A	modules/sd-config-htpasswd-idp-cli.adoc
M	modules/setting-up-an-aws-iam-role-a-service-account.adoc
M	modules/understanding-admin-roles.adoc
M	modules/understanding-idp.adoc
M	modules/verifying-the-assumed-iam-role-in-your-pod.adoc
M	rosa_learning/creating_cluster_workshop/learning-getting-started-idp.adoc
Falling back to patching base and 3-way merge...
Auto-merging authentication/assuming-an-aws-iam-role-for-a-service-account.adoc
CONFLICT (content): Merge conflict in authentication/assuming-an-aws-iam-role-for-a-service-account.adoc
Auto-merging authentication/osd-admin-roles.adoc
Auto-merging authentication/osd-revoking-cluster-privileges.adoc
CONFLICT (content): Merge conflict in authentication/osd-revoking-cluster-privileges.adoc
Auto-merging authentication/sd-configuring-identity-providers.adoc
CONFLICT (content): Merge conflict in authentication/sd-configuring-identity-providers.adoc
Auto-merging cloud_experts_tutorials/cloud-experts-getting-started/cloud-experts-getting-started-idp.adoc
CONFLICT (content): Merge conflict in cloud_experts_tutorials/cloud-experts-getting-started/cloud-experts-getting-started-idp.adoc
Auto-merging modules/assuming-an-aws-iam-role-in-your-own-pods.adoc
Auto-merging modules/config-github-idp.adoc
CONFLICT (content): Merge conflict in modules/config-github-idp.adoc
Auto-merging modules/config-gitlab-idp.adoc
CONFLICT (content): Merge conflict in modules/config-gitlab-idp.adoc
Auto-merging modules/config-google-idp.adoc
CONFLICT (modify/delete): modules/config-htpasswd-idp-terraform.adoc deleted in HEAD and modified in CQA for authentication.  Version CQA for authentication of modules/config-htpasswd-idp-terraform.adoc left in tree.
Auto-merging modules/config-ldap-idp.adoc
Auto-merging modules/config-openid-idp.adoc
CONFLICT (content): Merge conflict in modules/config-openid-idp.adoc
Auto-merging modules/creating-a-service-account-in-your-project.adoc
Auto-merging modules/creating-an-example-aws-sdk-container-image.adoc
Auto-merging modules/deploying-a-pod-that-includes-an-aws-sdk.adoc
Auto-merging modules/identity-provider-parameters.adoc
Auto-merging modules/managing-dedicated-administrators.adoc
CONFLICT (content): Merge conflict in modules/managing-dedicated-administrators.adoc
Auto-merging modules/osd-revoke-admin-privileges.adoc
Auto-merging modules/osd-revoke-user-access.adoc
CONFLICT (modify/delete): modules/rosa-config-htpasswd-idp-cli-file.adoc deleted in HEAD and modified in CQA for authentication.  Version CQA for authentication of modules/rosa-config-htpasswd-idp-cli-file.adoc left in tree.
CONFLICT (modify/delete): modules/rosa-config-htpasswd-idp-cli.adoc deleted in HEAD and modified in CQA for authentication.  Version CQA for authentication of modules/rosa-config-htpasswd-idp-cli.adoc left in tree.
CONFLICT (modify/delete): modules/sd-config-htpasswd-idp-cli.adoc deleted in HEAD and modified in CQA for authentication.  Version CQA for authentication of modules/sd-config-htpasswd-idp-cli.adoc left in tree.
Auto-merging modules/setting-up-an-aws-iam-role-a-service-account.adoc
Auto-merging modules/understanding-admin-roles.adoc
CONFLICT (content): Merge conflict in modules/understanding-admin-roles.adoc
Auto-merging modules/understanding-idp.adoc
CONFLICT (content): Merge conflict in modules/understanding-idp.adoc
Auto-merging modules/verifying-the-assumed-iam-role-in-your-pod.adoc
Auto-merging rosa_learning/creating_cluster_workshop/learning-getting-started-idp.adoc
CONFLICT (content): Merge conflict in rosa_learning/creating_cluster_workshop/learning-getting-started-idp.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 CQA for authentication

Details

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants