OSDOCS-16411 [ROSA & OSD]: CQA for authentication - #116731
Conversation
|
🤖 Fri Jul 31 14:44:05 - Prow CI generated the docs preview: |
2ba3f97 to
1f40a5c
Compare
4f90641 to
825d62b
Compare
|
@jc-berger Done. Thank for the epic and clean work. Most suggestions are minor, optional and abbreviations/attributes-related which are nice-to-haves at the moment. In general, I believe, there're more abbreviations that aren't expanded on the first use, I haven't checked that thoroughly, only commented on random ones I saw. And I know that AI often misses those. Up to you whether you prefer to search for these now or later, with the Quality tab updates. I'm surprised that the local Vale bot hasn't suggested using {cluster-manager}, I remember it usually told me to do so. |
4340273 to
092d7ec
Compare
|
|
||
| [role="_abstract"] | ||
| To log in to your cluster, set up an identity provider (IDP). This tutorial uses GitHub as an example IDP. See the full list of xref:../../rosa_install_access_delete_clusters/rosa-sts-config-identity-providers.adoc#understanding-idp-supported_rosa-sts-config-identity-providers[IDPs supported by ROSA]. | ||
| To log in to your cluster, set up an identity provider (IDP). This tutorial uses GitHub as an example IDP. See the full list of xref:../../rosa_install_access_delete_clusters/rosa-sts-config-identity-providers.adoc#understanding-idp_rosa-sts-config-identity-providers[IDPs supported by ROSA]. |
There was a problem hiding this comment.
🤖 [error] AsciiDocDITA.ConceptLink: Move all links and cross references to Additional resources.
There was a problem hiding this comment.
That's from Classic Tutorials, we haven't CQA-ed them yet but will fix this soon.
There was a problem hiding this comment.
where is this preview? i would like to ensure the xref works but this tutorial doesn't seem to be listed in the tutorials section and isn't in any of the previews
There was a problem hiding this comment.
@jldohmann thank you! Here is the preview link for it: https://116731--ocpdocs-pr.netlify.app/openshift-rosa/latest/cloud_experts_tutorials/cloud-experts-getting-started/cloud-experts-getting-started-idp.html
|
@jc-berger: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
jldohmann
left a comment
There was a problem hiding this comment.
nice work! LGTM, but i would like to check one xref that i didn't see a preview link for the file its in. see comment below
|
|
||
| [role="_abstract"] | ||
| To log in to your cluster, set up an identity provider (IDP). This tutorial uses GitHub as an example IDP. See the full list of xref:../../rosa_install_access_delete_clusters/rosa-sts-config-identity-providers.adoc#understanding-idp-supported_rosa-sts-config-identity-providers[IDPs supported by ROSA]. | ||
| To log in to your cluster, set up an identity provider (IDP). This tutorial uses GitHub as an example IDP. See the full list of xref:../../rosa_install_access_delete_clusters/rosa-sts-config-identity-providers.adoc#understanding-idp_rosa-sts-config-identity-providers[IDPs supported by ROSA]. |
There was a problem hiding this comment.
where is this preview? i would like to ensure the xref works but this tutorial doesn't seem to be listed in the tutorials section and isn't in any of the previews
|
/cherrypick enterprise-5.0 |
|
/cherrypick enterprise-4.22 |
|
/cherrypick enterprise-4.21 |
|
/cherrypick enterprise-4.20 |
|
@jldohmann: new pull request created: #117191 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jldohmann: new pull request created: #117192 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jldohmann: new pull request created: #117193 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jldohmann: #116731 failed to apply on top of branch "enterprise-4.20": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.21+
Issue:
https://redhat.atlassian.net/browse/OSDOCS-16411
Link to docs preview:
Preview links to the assemblies by TOCs:
OSD
ROSA HCP
ROSA Classic
QE review:
Additional information: