Wipe agent token on inspection completion to fix cleaning failures#434
Open
elfosardo wants to merge 1 commit into
Open
Wipe agent token on inspection completion to fix cleaning failures#434elfosardo wants to merge 1 commit into
elfosardo wants to merge 1 commit into
Conversation
Author
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
The backport of f734efb ("Set node alive when inspection finished") causes a regression in 4.15 where ironic-inspector is still used. The patch makes nodes appear fast-trackable after inspection when the agent is dead and boot media is detached, causing the AgentConnectionFailed handler to park nodes in clean wait indefinitely. This happens because 4.15 uses ironic-inspector, which powers off the node after inspection. The f734efb fix was designed for 4.16 where built-in agent inspection keeps IPA running across the inspection-to-cleaning transition. Revert 0feaa17 and instead fix the root cause: the agent_secret_token persists from inspection into cleaning. When IPA reboots for cleaning, it cannot get a new token because Ironic refuses to generate one when one already exists, causing repeated lookup loops without heartbeats until clean_callback_timeout fires. The fix adds wipe_token_and_url() when inspection finishes successfully, both in the synchronous path (inspect_hardware) and the ironic-inspector callback path (continue_inspection). This follows the same pattern already used on inspection start and abort.
elfosardo
force-pushed
the
fix-token-wipe-4.15
branch
from
829b319 to
0bcb667
Compare
|
@elfosardo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backport of f734efb ("Set node alive when inspection finished") causes a regression in 4.15 where ironic-inspector is still used. The patch makes nodes appear fast-trackable after inspection when the agent is dead and boot media is detached, causing the AgentConnectionFailed handler to park nodes in clean wait indefinitely.
This happens because 4.15 uses ironic-inspector, which powers off the node after inspection. The f734efb fix was designed for 4.16 where built-in agent inspection keeps IPA running across the inspection-to-cleaning transition.
Revert 0feaa17 and instead fix the root cause: the agent_secret_token persists from inspection into cleaning. When IPA reboots for cleaning, it cannot get a new token because Ironic refuses to generate one when one already exists, causing repeated lookup loops without heartbeats until clean_callback_timeout fires.
The fix adds wipe_token_and_url() when inspection finishes successfully, both in the synchronous path (inspect_hardware) and the ironic-inspector callback path (continue_inspection). This follows the same pattern already used on inspection start and abort.