Skip to content

OPRUN-4212: [OTE]: Add webhook cleanup validation on extension uninstall#542

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
camilamacedo86:webhook-new-test
Nov 6, 2025
Merged

OPRUN-4212: [OTE]: Add webhook cleanup validation on extension uninstall#542
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
camilamacedo86:webhook-new-test

Conversation

@camilamacedo86
Copy link
Copy Markdown
Contributor

@camilamacedo86 camilamacedo86 commented Nov 4, 2025

No description provided.

@openshift-ci openshift-ci Bot requested review from dtfranz and thetechnick November 4, 2025 16:23
@camilamacedo86 camilamacedo86 changed the title Validate that webhooks are not left behind and are cleanup by OLM OPRUN-4212: [OTE]: Add webhook cleanup validation on extension uninstall Nov 4, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 4, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Nov 4, 2025 •
edited by openshift-ci Bot
Loading

@camilamacedo86: This pull request references OPRUN-4212 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jianzhangbjz
Copy link
Copy Markdown
Contributor

jianzhangbjz commented Nov 4, 2025

/assign @bandrade

@camilamacedo86
Copy link
Copy Markdown
Contributor Author

camilamacedo86 commented Nov 5, 2025

/test okd-scos-e2e-aws-ovn

@tmshort
Copy link
Copy Markdown
Contributor

tmshort commented Nov 5, 2025

/hold
Hold until #546 merges, or this will cause another manual merge to occur!

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2025
@tmshort
Copy link
Copy Markdown
Contributor

tmshort commented Nov 5, 2025

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2025
@tmshort
Copy link
Copy Markdown
Contributor

tmshort commented Nov 6, 2025

/unhold
#546 merged

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2025
@bandrade
Copy link
Copy Markdown
Contributor

bandrade commented Nov 6, 2025

/verified by @bandrade
/label qe-approved

@openshift-ci openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Nov 6, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Nov 6, 2025 •
edited by openshift-ci Bot
Loading

@camilamacedo86: This pull request references OPRUN-4212 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 6, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Nov 6, 2025

@bandrade: This PR has been marked as verified by @bandrade.

Details

In response to this:

/verified by @bandrade
/label qe-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@perdasilva
Copy link
Copy Markdown
Contributor

perdasilva commented Nov 6, 2025

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, perdasilva, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 6, 2025

@camilamacedo86: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 5706dc9 into openshift:main Nov 6, 2025
13 checks passed
@camilamacedo86 camilamacedo86 deleted the webhook-new-test branch November 7, 2025 01:36
stbenjam added a commit to stbenjam/operator-framework-operator-controller that referenced this pull request Nov 11, 2025
@stbenjam
Revert "Merge pull request openshift#542 from camilamacedo86/webhook-…
2785aa2 
…new-test"

This reverts commit 5706dc9, reversing
changes made to 99e740d.
@stbenjam stbenjam mentioned this pull request Nov 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtfranz dtfranz Awaiting requested review from dtfranz

@thetechnick thetechnick Awaiting requested review from thetechnick

1 more reviewer

@perdasilva perdasilva perdasilva approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bandrade bandrade

@perdasilva perdasilva

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@camilamacedo86 @openshift-ci-robot @jianzhangbjz @tmshort @bandrade @perdasilva