Merge pull request #6270 from Miciah/set_connection_hook_env_vars-log-errs-write_environment_variables-skip-bad-lines

Merged by openshift-bot

Author: OpenShift Bot

node/lib/openshift-origin-node/model/v2_cart_model.rb

@@ -720,8 +720,13 @@ def write_environment_variables(path, hash, prefix = true)
             name = "OPENSHIFT_#{name}"
           end
 
-          File.open(PathUtils.join(path, name), 'w', 0666) do |f|
-            f.write(v)
+          pathname = PathUtils.join(path, name)
+          begin
+            File.open(pathname, 'w', 0666) do |f|
+              f.write(v)
+            end
+          rescue Exception => e
+            logger.warn "Got #{e.class} exception writing #{pathname}: #{e.message}"
           end
         end
       end
@@ -1222,6 +1227,8 @@ def set_connection_hook_env_vars(cart_name, pub_cart_name, args)
         pairs = args[3].values[0].split("\n")
 
         pairs.each do |pair|
+          next if not pair.include? '='
+
           k, v    = pair.strip.split("=")
           envs[k] = v
         end