Skip to content

Commit 05c80ba

Browse files
Merge pull request #31145 from rikatz/remove-sail-exception
NO-JIRA: Clarify why Envoy pods have no CPU or memory limit
2 parents 95613d1 + 6acfc4f commit 05c80ba

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

test/extended/operators/resources.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,10 @@ var _ = g.Describe("[sig-arch] Managed cluster", func() {
5757
"batch/v1/Job/openshift-monitoring/<batch_job>/container/osd-rebalance-infra-nodes/request[cpu]": "https://issues.redhat.com/browse/OSD-21708",
5858
"batch/v1/Job/openshift-monitoring/<batch_job>/container/osd-rebalance-infra-nodes/request[memory]": "https://issues.redhat.com/browse/OSD-21708",
5959

60-
// Istio pods
60+
// Istio (Envoy) Proxy Pods
61+
// Removing Envoy limits is not a good idea. Envoy will try to use the whole amount
62+
// of existing CPUs, and on a cluster with many CPUs this can have bad outcomes
63+
// Some reference: https://github.com/istio/istio/issues/51456#issuecomment-2155220061
6164
"apps/v1/Deployment/openshift-ingress/gateway/container/istio-proxy/limit[cpu]": "https://issues.redhat.com/browse/OCPBUGS-55050",
6265
"apps/v1/Deployment/openshift-ingress/gateway/container/istio-proxy/limit[memory]": "https://issues.redhat.com/browse/OCPBUGS-55050",
6366

0 commit comments

Comments
 (0)