Skip to content

Commit 0bc62f3

Browse files
Merge pull request #31329 from gcs278/fix-isNoOLMFeatureGateEnabled-version
OCPBUGS-91956: Fix isNoOLMFeatureGateEnabled to check only the current cluster version
2 parents 7d471e8 + 8039855 commit 0bc62f3

1 file changed

Lines changed: 11 additions & 1 deletion

File tree

test/extended/router/gatewayapicontroller.go

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -643,18 +643,28 @@ func isIPv6OrDualStack(oc *exutil.CLI) (bool, error) {
643643
}
644644

645645
func isNoOLMFeatureGateEnabled(oc *exutil.CLI) (bool, error) {
646+
cv, err := oc.AdminConfigClient().ConfigV1().ClusterVersions().Get(context.TODO(), "version", metav1.GetOptions{})
647+
if err != nil {
648+
return false, fmt.Errorf("failed to get ClusterVersion: %v", err)
649+
}
650+
currentVersion := cv.Status.Desired.Version
651+
646652
fgs, err := oc.AdminConfigClient().ConfigV1().FeatureGates().Get(context.TODO(), "cluster", metav1.GetOptions{})
647653
if err != nil {
648654
return false, fmt.Errorf("failed to get cluster FeatureGates: %v", err)
649655
}
650656
for _, fg := range fgs.Status.FeatureGates {
657+
if fg.Version != currentVersion {
658+
continue
659+
}
651660
for _, enabledFG := range fg.Enabled {
652661
if enabledFG.Name == "GatewayAPIWithoutOLM" {
653-
e2e.Logf("GatewayAPIWithoutOLM featuregate is enabled")
662+
e2e.Logf("GatewayAPIWithoutOLM featuregate is enabled for version %s", currentVersion)
654663
return true, nil
655664
}
656665
}
657666
}
667+
e2e.Logf("GatewayAPIWithoutOLM featuregate is not enabled for version %s", currentVersion)
658668
return false, nil
659669
}
660670

0 commit comments

Comments
 (0)