Skip to content

Commit 295f2db

Browse files
Merge pull request #31289 from xueqzhan/wait-after-upgrade
OCPBUGS-85782: Add extra wait after mco and cvo considers upgrade complete
2 parents 88018a6 + 74903bf commit 295f2db

1 file changed

Lines changed: 9 additions & 3 deletions

File tree

test/e2e/upgrade/upgrade.go

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ import (
3838
"k8s.io/kubernetes/test/e2e/upgrades/apps"
3939
"k8s.io/kubernetes/test/e2e/upgrades/node"
4040

41+
"github.com/openshift/origin/pkg/clioptions/clusterinfo"
4142
e2e_analysis "github.com/openshift/origin/pkg/e2eanalysis"
4243
"github.com/openshift/origin/test/e2e/upgrade/adminack"
4344
"github.com/openshift/origin/test/e2e/upgrade/dns"
@@ -192,9 +193,14 @@ var _ = g.Describe("[sig-arch][Feature:ClusterUpgrade]", func() {
192193
clusterUpgrade(f, client, dynamicClient, config, upgCtx.Versions[i]),
193194
fmt.Sprintf("during upgrade to %s", upgCtx.Versions[i].NodeImage))
194195
}
195-
// Sleep to give some time to the workloads on the last upgraded
196-
// node to restart.
197-
time.Sleep(5 * time.Second)
196+
// Wait for all operators to stabilize after upgrade. MCO may
197+
// report upgrade complete before the last worker node finishes
198+
// rebooting, and workloads need additional time to start after
199+
// nodes become Ready.
200+
framework.Logf("Waiting for cluster to stabilize after upgrade")
201+
if _, waitErr := clusterinfo.WaitForStableCluster(context.Background(), config); waitErr != nil {
202+
framework.Logf("WARNING: cluster did not stabilize within timeout after upgrade: %v", waitErr)
203+
}
198204
},
199205
)
200206
})

0 commit comments

Comments
 (0)