fix: address coderabbit review comments

Author: fracappa

test/extended/edge_topologies/utils/apis/baremetalhost.go

@@ -46,13 +46,37 @@ func FindFencingCredentialsByNodeName(oc *exutil.CLI, nodeName string) (*Fencing
 		return nil, fmt.Errorf("list secrets in %s: %w", FencingCredentialsNamespace, err)
 	}
 
+	expected := map[string]struct{}{
+		fencingCredentialsPrefix + shortName: {},
+		fencingCredentialsPrefix + nodeName:  {},
+	}
+
 	for _, secret := range list.Items {
-		if strings.HasPrefix(secret.Name, fencingCredentialsPrefix) && strings.Contains(secret.Name, shortName) {
+		if _, ok := expected[secret.Name]; ok {
+			getRequired := func(key string) (string, error) {
+				v, exists := secret.Data[key]
+				if !exists || len(v) == 0 {
+					return "", fmt.Errorf("secret %s missing required key %q", secret.Name, key)
+				}
+				return string(v), nil
+			}
+			address, err := getRequired("address")
+			if err != nil {
+				return nil, err
+			}
+			username, err := getRequired("username")
+			if err != nil {
+				return nil, err
+			}
+			password, err := getRequired("password")
+			if err != nil {
+				return nil, err
+			}
 			return &FencingCredentials{
 				SecretName:              secret.Name,
-				Address:                 string(secret.Data["address"]),
-				Username:                string(secret.Data["username"]),
-				Password:                string(secret.Data["password"]),
+				Address:                 address,
+				Username:                username,
+				Password:                password,
 				CertificateVerification: string(secret.Data["certificateVerification"]),
 			}, nil
 		}

test/extended/edge_topologies/utils/apis/redfish.go

@@ -14,6 +14,9 @@ import (
 // ParseRedfishAddress parses a Redfish address into its components.
 // Input format: "redfish+https://host:port/redfish/v1/Systems/1" (IPv6 uses bracket notation).
 func ParseRedfishAddress(address string) (host, port, path string, err error) {
+	if !strings.HasPrefix(address, "redfish+") {
+		return "", "", "", fmt.Errorf("invalid Redfish address: %q: missing redfish+ prefix", address)
+	}
 	stripped := strings.TrimPrefix(address, "redfish+")
 	parsed, err := url.Parse(stripped)
 	if err != nil {