Skip to content

Commit de9c335

Browse files
Fixed flakiness in oc extract image ref
addressed review comments
1 parent dad4ce8 commit de9c335

1 file changed

Lines changed: 17 additions & 5 deletions

File tree

test/extended/cli/admin.go

Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import (
1515
"k8s.io/apiserver/pkg/storage/names"
1616
"k8s.io/kubernetes/test/e2e/framework"
1717

18-
"github.com/openshift/origin/test/extended/testdata"
1918
exutil "github.com/openshift/origin/test/extended/util"
2019
)
2120

@@ -547,10 +546,23 @@ var _ = g.Describe("[sig-cli] oc adm", func() {
547546
})
548547

549548
g.It("release extract image-references", func() {
550-
expected := string(testdata.MustAsset("test/extended/testdata/cli/test-release-image-references.json"))
551-
out, err := oc.Run("adm", "release", "extract").Args("--file", "image-references", "quay.io/openshift-release-dev/ocp-release:4.13.0-rc.0-x86_64").Output()
552-
o.Expect(err).NotTo(o.HaveOccurred())
553-
o.Expect(out).To(o.Equal(expected))
549+
payloadImage, err := oc.AsAdmin().Run("get").Args("clusterversion", "version", "-o", "jsonpath={.status.desired.image}").Output()
550+
o.Expect(err).NotTo(o.HaveOccurred(), "Failed to get current payload image from clusterversion")
551+
payloadImage = strings.TrimSpace(payloadImage)
552+
o.Expect(payloadImage).NotTo(o.BeEmpty())
553+
cleanup, regArgs, err := exutil.PrepareImagePullSecretAndCABundle(ocns)
554+
if cleanup != nil {
555+
defer cleanup()
556+
}
557+
o.Expect(err).NotTo(o.HaveOccurred(), "PrepareImagePullSecretAndCABundle failed")
558+
args := append([]string{"--file", "image-references"}, regArgs...)
559+
args = append(args, payloadImage)
560+
out, err := oc.AsAdmin().Run("adm", "release", "extract").Args(args...).Output()
561+
o.Expect(err).NotTo(o.HaveOccurred(), "oc adm release extract failed with error")
562+
563+
o.Expect(out).To(o.ContainSubstring(`"kind": "ImageStream"`))
564+
o.Expect(out).To(o.ContainSubstring(`"apiVersion": "image.openshift.io/v1"`))
565+
o.Expect(out).To(o.MatchRegexp(`"name": ".*"`), "Output should contain a valid name field")
554566
})
555567

556568
// TODO (soltysh): sync with Standa and figure out if we can get these

0 commit comments

Comments
 (0)