Skip to content

NE-2131: Remove dualstack e2e tests migrated to cluster-ingress-operator#30968

Closed
lihongan wants to merge 1 commit intoopenshift:mainfrom
lihongan:remove-dualstack-tests
Closed

NE-2131: Remove dualstack e2e tests migrated to cluster-ingress-operator#30968
lihongan wants to merge 1 commit intoopenshift:mainfrom
lihongan:remove-dualstack-tests

Conversation

@lihongan
Copy link
Copy Markdown

@lihongan lihongan commented Apr 7, 2026

follow up: openshift/cluster-ingress-operator#1412

These tests have been migrated to the cluster-ingress-operator tests-extension (OTE) framework. The test names are preserved exactly for Sippy continuity.

These tests have been migrated to the cluster-ingress-operator
tests-extension (OTE) framework. The test names are preserved
exactly for Sippy continuity.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci-robot
Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci bot requested review from knobunc and miheer April 7, 2026 09:49
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 7, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lihongan
Once this PR has been reviewed and has the lgtm label, please assign knobunc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a2f43c8a-ace8-44a6-bb80-c6e94c9d9019

📥 Commits

Reviewing files that changed from the base of the PR and between c77ff4a and 31dff46.

📒 Files selected for processing (1)
  • test/extended/router/dualstack.go
💤 Files with no reviewable changes (1)
  • test/extended/router/dualstack.go

Walkthrough

A test suite for OpenShift router dual-stack networking on AWS was completely removed from the repository. The deleted file contained test scenarios validating IPv4+IPv6 and IPv4-only reachability checks via different load balancer types, along with associated helper functions for resource creation and condition polling.

Changes

Cohort / File(s) Summary
Dual-stack Router Test Suite Removal
test/extended/router/dualstack.go
Complete removal of 350-line test file containing two end-to-end test scenarios for dual-stack router behavior on AWS and helper functions for setup, polling, and cleanup operations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lihongan
Copy link
Copy Markdown
Author

lihongan commented Apr 7, 2026

/testwith openshift/installer/main/e2e-aws-ovn-dualstack-ipv6-primary-techpreview openshift/cluster-ingress-operator#1412

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 7, 2026

@lihongan, testwith: could not generate prow job. ERROR:

no ref for requested test included in command. The org, repo, and branch containing the requested test need to be targeted by at least one of the included PRs

@openshift-ci-robot
Copy link
Copy Markdown

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 7, 2026

@lihongan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lihongan
Copy link
Copy Markdown
Author

lihongan commented Apr 7, 2026

/testwith openshift/installer/main/e2e-aws-ovn-dualstack-ipv4-primary-techpreview openshift/cluster-ingress-operator#1412 openshift/installer#10467

@lihongan lihongan changed the title Remove dualstack e2e tests migrated to cluster-ingress-operator NE-2131: Remove dualstack e2e tests migrated to cluster-ingress-operator Apr 8, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 8, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 8, 2026

@lihongan: This pull request references NE-2131 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

follow up: openshift/cluster-ingress-operator#1412

These tests have been migrated to the cluster-ingress-operator tests-extension (OTE) framework. The test names are preserved exactly for Sippy continuity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lihongan
Copy link
Copy Markdown
Author

lihongan commented Apr 9, 2026

/close

@openshift-ci openshift-ci bot closed this Apr 9, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 9, 2026

@lihongan: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants