Skip to content

OCPBUGS-82039: Fix DCM ingress tests to support IPv6-only clusters#30972

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
mkowalski:fix-router-ipv6
Apr 8, 2026
Merged

OCPBUGS-82039: Fix DCM ingress tests to support IPv6-only clusters#30972
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
mkowalski:fix-router-ipv6

Conversation

@mkowalski
Copy link
Copy Markdown
Contributor

Replace hardcoded 127.0.0.1 loopback address with dynamic detection based on the router pod's IP family. On IPv6-only clusters, 127.0.0.1 is unavailable, so ::1 must be used instead. Also bracket the IPv6 address in the metrics curl URL via exutil.IPUrl().

Replace hardcoded 127.0.0.1 loopback address with dynamic detection
based on the router pod's IP family. On IPv6-only clusters, 127.0.0.1
is unavailable, so ::1 must be used instead. Also bracket the IPv6
address in the metrics curl URL via exutil.IPUrl().

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci-robot
Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9f758e80-6908-42f9-ad4a-d1e6ce076091

📥 Commits

Reviewing files that changed from the base of the PR and between f183253 and 6833ac3.

📒 Files selected for processing (1)
  • test/extended/router/config_manager_ingress.go

Walkthrough

This change adds IPv-family-aware loopback address selection for a router exec pod, automatically choosing between 127.0.0.1 and ::1 based on the pod's detected IP address family. The metrics-curl command is updated to use exutil.IPUrl() for proper IP address formatting in curl's --resolve target.

Changes

Cohort / File(s) Summary
IPv-family-aware loopback selection
test/extended/router/config_manager_ingress.go
Added conditional logic to detect IPv6 pods via Status.PodIP inspection and assign the appropriate loopback address (IPv4: 127.0.0.1, IPv6: ::1) to execPod.ipAddress. Updated metrics-curl command construction to wrap the IP address with exutil.IPUrl() for correct --resolve target formatting when querying HAProxy metrics at :1936/metrics.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@mkowalski
Copy link
Copy Markdown
Contributor Author

/payload e2e-metal-ipi-ovn-ipv6-techpreview

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 7, 2026

@mkowalski: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@mkowalski
Copy link
Copy Markdown
Contributor Author

/payload-job e2e-metal-ipi-ovn-ipv6-techpreview

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 7, 2026

@mkowalski: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • e2e-metal-ipi-ovn-ipv6-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/024ae290-3284-11f1-9472-ab680068a736-0

@mkowalski mkowalski changed the title Fix DCM ingress tests to support IPv6-only clusters OCPBUGS-82039: Fix DCM ingress tests to support IPv6-only clusters Apr 7, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 7, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@mkowalski: This pull request references Jira Issue OCPBUGS-82039, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Replace hardcoded 127.0.0.1 loopback address with dynamic detection based on the router pod's IP family. On IPv6-only clusters, 127.0.0.1 is unavailable, so ::1 must be used instead. Also bracket the IPv6 address in the metrics curl URL via exutil.IPUrl().

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mkowalski
Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 7, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@mkowalski: This pull request references Jira Issue OCPBUGS-82039, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from lihongan April 7, 2026 13:19
@jcmoraisjr
Copy link
Copy Markdown
Member

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2026
@gcs278
Copy link
Copy Markdown
Contributor

gcs278 commented Apr 7, 2026

Preemptively assigning Joao since you will have the most context here:
/assign @jcmoraisjr

@gcs278
Copy link
Copy Markdown
Contributor

gcs278 commented Apr 7, 2026

And I'll keep an eye on this:
/assign @gcs278

@openshift-ci-robot
Copy link
Copy Markdown

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@gcs278
Copy link
Copy Markdown
Contributor

gcs278 commented Apr 7, 2026

e2e-metal-ipi-ovn-ipv6-techpreview is passing, which tells me this is the correct fix.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gcs278, jcmoraisjr, mkowalski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gcs278
Copy link
Copy Markdown
Contributor

gcs278 commented Apr 7, 2026

Unrelated failures
/retest

@jcmoraisjr
Copy link
Copy Markdown
Member

/test e2e-gcp-ovn

@openshift-trt
Copy link
Copy Markdown

openshift-trt bot commented Apr 8, 2026

Job Failure Risk Analysis for sha: 6833ac3

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6 Low
[Jira:Node][sig-node] Node non-cnv swap configuration should reject user override of swap settings via KubeletConfig API [OCP-86395] [Suite:openshift/conformance/parallel]
This test has passed 31.82% of 330 runs on release 5.0 [Overall] in the last week.
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi Low
[Jira:Node][sig-node] Node non-cnv swap configuration should reject user override of swap settings via KubeletConfig API [OCP-86395] [Suite:openshift/conformance/parallel]
This test has passed 31.82% of 330 runs on release 5.0 [Overall] in the last week.

@ShudiLi
Copy link
Copy Markdown
Contributor

ShudiLi commented Apr 8, 2026

/verified by e2e

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 8, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@ShudiLi: This PR has been marked as verified by e2e.

Details

In response to this:

/verified by e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 8, 2026

@mkowalski: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 94bfa20 into openshift:main Apr 8, 2026
21 checks passed
@openshift-ci-robot
Copy link
Copy Markdown

@mkowalski: Jira Issue Verification Checks: Jira Issue OCPBUGS-82039
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-82039 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Replace hardcoded 127.0.0.1 loopback address with dynamic detection based on the router pod's IP family. On IPv6-only clusters, 127.0.0.1 is unavailable, so ::1 must be used instead. Also bracket the IPv6 address in the metrics curl URL via exutil.IPUrl().

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lihongan
Copy link
Copy Markdown

lihongan commented Apr 8, 2026

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

@lihongan: Jira Issue OCPBUGS-82039 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mkowalski mkowalski deleted the fix-router-ipv6 branch April 8, 2026 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants