OCPBUGS-82039: Fix DCM ingress tests to support IPv6-only clusters#30972
Conversation
Replace hardcoded 127.0.0.1 loopback address with dynamic detection based on the router pod's IP family. On IPv6-only clusters, 127.0.0.1 is unavailable, so ::1 must be used instead. Also bracket the IPv6 address in the metrics curl URL via exutil.IPUrl(). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis change adds IPv-family-aware loopback address selection for a router exec pod, automatically choosing between Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/payload e2e-metal-ipi-ovn-ipv6-techpreview |
|
@mkowalski: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
|
/payload-job e2e-metal-ipi-ovn-ipv6-techpreview |
|
@mkowalski: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/024ae290-3284-11f1-9472-ab680068a736-0 |
|
@mkowalski: This pull request references Jira Issue OCPBUGS-82039, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@mkowalski: This pull request references Jira Issue OCPBUGS-82039, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
Preemptively assigning Joao since you will have the most context here: |
|
And I'll keep an eye on this: |
|
Scheduling required tests: |
|
e2e-metal-ipi-ovn-ipv6-techpreview is passing, which tells me this is the correct fix. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gcs278, jcmoraisjr, mkowalski The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Unrelated failures |
|
/test e2e-gcp-ovn |
|
Job Failure Risk Analysis for sha: 6833ac3
|
|
/verified by e2e |
|
@ShudiLi: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@mkowalski: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@mkowalski: Jira Issue Verification Checks: Jira Issue OCPBUGS-82039 Jira Issue OCPBUGS-82039 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@lihongan: Jira Issue OCPBUGS-82039 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Replace hardcoded 127.0.0.1 loopback address with dynamic detection based on the router pod's IP family. On IPv6-only clusters, 127.0.0.1 is unavailable, so ::1 must be used instead. Also bracket the IPv6 address in the metrics curl URL via exutil.IPUrl().