[release-4.21] OCPBUGS-82064: Assert CNI version greater than equal to 1.0.0 by arkadeepsen · Pull Request #30977 · openshift/origin

arkadeepsen · 2026-04-07T15:02:48Z

This PR asserts CNI version is greater than equal to 1.0.0 in the 4.21 branch. The related tests on the 4.22 -> 4.21 branch sync PR is failing due to the CNI version mismatch: openshift/ovn-kubernetes#3087

coderabbitai · 2026-04-07T15:02:58Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: fd67b8f1-9c85-44d3-96df-97f34d965e67

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

arkadeepsen · 2026-04-07T15:03:26Z

/jira cherrypick OCPBUGS-82046

openshift-ci-robot · 2026-04-07T15:04:37Z

@arkadeepsen: Jira Issue OCPBUGS-82046 has been cloned as Jira Issue OCPBUGS-82064. Will retitle bug to link to clone.
/retitle OCPBUGS-82064: Bump CNI version to 1.1.0

Details

In response to this:

/jira cherrypick OCPBUGS-82046

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-04-07T15:04:50Z

@arkadeepsen: This pull request references Jira Issue OCPBUGS-82064, which is invalid:

expected dependent Jira Issue OCPBUGS-82046 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR bumps the CNI version to 1.1.0 in the 4.21 branch. The related tests on the 4.22 -> 4.21 branch sync PR is failing due to the CNI version mismatch: openshift/ovn-kubernetes#3087

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-04-07T15:31:08Z

@arkadeepsen: This PR was included in a payload test run from openshift/ovn-kubernetes#3087
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-ci-4.21-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ca6b0310-3296-11f1-953a-3eec175873ae-0

arkadeepsen · 2026-04-07T15:56:47Z

/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

arkadeepsen · 2026-04-08T01:58:20Z

/skip

openshift-ci · 2026-04-08T02:02:09Z

@arkadeepsen: This PR was included in a payload test run from openshift/ovn-kubernetes#3087
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-ci-4.21-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f0f99610-32ee-11f1-9ea2-b6c28c658aa1-0

arkadeepsen · 2026-04-08T03:13:03Z

The following tests are failing in e2e-aws-ovn-fips, e2e-gcp-ovn, e2e-vsphere-ovn, e2e-vsphere-ovn-upi due to the CNI version mismatch. It is expecting 1.1.0 but the current openshift/ovn-kubernetes@release-4.21 branch is having a version of 1.0.0.

: [sig-network][OCPFeatureGate:NetworkSegmentation][Feature:UserDefinedPrimaryNetworks] when using openshift ovn-kubernetes UserDefinedNetwork CRD controller should create NetworkAttachmentDefinition according to spec [Suite:openshift/conformance/parallel]
: [sig-network][OCPFeatureGate:NetworkSegmentation][Feature:UserDefinedPrimaryNetworks] when using openshift ovn-kubernetes ClusterUserDefinedNetwork CRD Controller should create NAD according to spec in each target namespace and report active namespaces [Suite:openshift/conformance/parallel]
: [sig-network][OCPFeatureGate:NetworkSegmentation][Feature:UserDefinedPrimaryNetworks] when using openshift ovn-kubernetes ClusterUserDefinedNetwork CRD Controller should create NAD in new created namespaces that apply to namespace-selector [Suite:openshift/conformance/parallel]
: [sig-network][OCPFeatureGate:NetworkSegmentation][Feature:UserDefinedPrimaryNetworks] when using openshift ovn-kubernetes ClusterUserDefinedNetwork CRD Controller when namespace-selector is mutated should create NAD in namespaces that apply to mutated namespace-selector [Suite:openshift/conformance/parallel]

The payload job ran with openshift/ovn-kubernetes#3087 was successful since the branch sync PR is bumping the CNI version to 1.1.0.

arkadeepsen · 2026-04-08T03:13:38Z

/test e2e-gcp-ovn-upgrade

openshift-ci · 2026-04-08T17:16:40Z

@arkadeepsen: This PR was included in a payload test run from openshift/ovn-kubernetes#3087
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-ci-4.21-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b24e2180-336e-11f1-8eef-893f056ce8e5-0

openshift-ci · 2026-04-10T17:02:54Z

@arkadeepsen: This PR was included in a payload test run from openshift/ovn-kubernetes#3087
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-ci-4.21-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1aba7c50-34ff-11f1-8881-f5621743b1c0-0

jluhrsen · 2026-04-11T17:18:30Z

/verified by running with these two PRs openshift/ovn-kubernetes#3087 openshift/multus-cni#284

openshift-ci-robot · 2026-04-11T17:18:41Z

@jluhrsen: This PR has been marked as verified by running with these two PRs https://github.com/openshift/ovn-kubernetes/pull/3087 https://github.com/openshift/multus-cni/pull/284.

Details

In response to this:

/verified by running with these two PRs openshift/ovn-kubernetes#3087 openshift/multus-cni#284

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

arkadeepsen · 2026-04-13T06:07:15Z

/jira refresh

openshift-ci-robot · 2026-04-13T06:07:23Z

@arkadeepsen: This pull request references Jira Issue OCPBUGS-82064, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.z) matches configured target version for branch (4.21.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-82046 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-82046 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-04-13T09:33:03Z

@arkadeepsen: This PR was included in a payload test run from openshift/ovn-kubernetes#3087
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-ci-4.21-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c1cb8020-371b-11f1-8314-beaf8a27bf87-0

arkadeepsen · 2026-04-13T10:33:18Z

/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

arkadeepsen · 2026-04-13T13:24:22Z

/retest-required

arkadeepsen · 2026-04-13T14:07:00Z

/verified by https://pr-payload-tests.ci.openshift.org/runs/ci/c1cb8020-371b-11f1-8314-beaf8a27bf87-0

openshift-ci-robot · 2026-04-13T14:07:28Z

@arkadeepsen: This PR has been marked as verified by https://pr-payload-tests.ci.openshift.org/runs/ci/c1cb8020-371b-11f1-8314-beaf8a27bf87-0.

Details

In response to this:

/verified by https://pr-payload-tests.ci.openshift.org/runs/ci/c1cb8020-371b-11f1-8314-beaf8a27bf87-0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-04-13T14:10:07Z

@arkadeepsen: This pull request references Jira Issue OCPBUGS-82064, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.z) matches configured target version for branch (4.21.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-82046 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-82046 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR asserts CNI version is greater than equal to 1.0.0 in the 4.21 branch. The related tests on the 4.22 -> 4.21 branch sync PR is failing due to the CNI version mismatch: openshift/ovn-kubernetes#3087

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

arkadeepsen · 2026-04-13T14:16:18Z

/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

openshift-ci · 2026-04-13T18:29:03Z

@arkadeepsen: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

kyrtapz · 2026-04-14T08:08:53Z

/lgtm

kyrtapz · 2026-04-14T08:09:46Z

+	err := json.Unmarshal([]byte(nad.Spec.Config), &cniConfig)
+	Expect(err).NotTo(HaveOccurred())
+
+	Expect(cniversion.GreaterThanOrEqualTo(cniConfig.CNIVersion, "1.0.0")).To(BeTrue())


A non actionable note: This isn't really necessary considering we do an exact cniVersion match below, right?

Added the line to verify if the CNI version is supported or not. It similar to this line: https://github.com/openshift/multus-cni/pull/284/changes#diff-f73ae23ad49258f5cdb5ffb37a1ccd4ace837549e44905f1a9ef2c5d5b0e9d37R508

kyrtapz · 2026-04-14T08:19:32Z

@arkadeepsen you will need an approve from TRT: https://github.com/openshift/origin/blob/release-4.21/OWNERS

mkowalski · 2026-04-14T08:53:50Z

/approve

smg247 · 2026-04-14T09:54:20Z

/approve

openshift-ci · 2026-04-14T09:59:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkadeepsen, kyrtapz, mkowalski, smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [smg247]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2026-04-14T10:02:00Z

@arkadeepsen: Jira Issue Verification Checks: Jira Issue OCPBUGS-82064
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-82064 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This PR asserts CNI version is greater than equal to 1.0.0 in the 4.21 branch. The related tests on the 4.22 -> 4.21 branch sync PR is failing due to the CNI version mismatch: openshift/ovn-kubernetes#3087

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2026-04-14T22:01:25Z

Fix included in release 4.21.0-0.nightly-2026-04-14-123546

openshift-ci bot requested review from kyrtapz and miheer April 7, 2026 15:03

openshift-ci bot changed the title ~~Bump CNI version to 1.1.0~~ OCPBUGS-82064: Bump CNI version to 1.1.0 Apr 7, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 7, 2026

arkadeepsen changed the title ~~OCPBUGS-82064: Bump CNI version to 1.1.0~~ [release-4.21] OCPBUGS-82064: Bump CNI version to 1.1.0 Apr 7, 2026

arkadeepsen mentioned this pull request Apr 7, 2026

OCPBUGS-83566: Branch Sync release-4.22 to release-4.21 [03-25-2026] openshift/ovn-kubernetes#3087

Merged

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 11, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 13, 2026

openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Apr 13, 2026

openshift-ci bot added the vendor-update Touching vendor dir or related files label Apr 13, 2026

arkadeepsen force-pushed the bump-cni-version-4.21 branch from 9a93376 to 6800234 Compare April 13, 2026 09:09

Assert CNI version greater than equal to 1.0.0

d91bdef

arkadeepsen force-pushed the bump-cni-version-4.21 branch from 6800234 to d91bdef Compare April 13, 2026 14:06

arkadeepsen changed the title ~~[release-4.21] OCPBUGS-82064: Bump CNI version to 1.1.0~~ [release-4.21] OCPBUGS-82064: Assert CNI version greater than equal to 1.0.0 Apr 13, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 13, 2026

openshift-ci-robot mentioned this pull request Apr 13, 2026

[release-4.21] OCPBUGS-82064: Bump CNI version to 1.1.0 openshift/multus-cni#284

Merged

kyrtapz reviewed Apr 14, 2026

View reviewed changes

openshift-ci bot assigned kyrtapz Apr 14, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2026

mkowalski approved these changes Apr 14, 2026

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2026

openshift-merge-bot bot merged commit e6cd3ea into openshift:release-4.21 Apr 14, 2026
21 checks passed

arkadeepsen deleted the bump-cni-version-4.21 branch April 14, 2026 10:53

Conversation

arkadeepsen commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

arkadeepsen commented Apr 7, 2026

Uh oh!

openshift-ci-robot commented Apr 7, 2026

Uh oh!

openshift-ci-robot commented Apr 7, 2026

Uh oh!

openshift-ci bot commented Apr 7, 2026

Uh oh!

arkadeepsen commented Apr 7, 2026

Uh oh!

arkadeepsen commented Apr 8, 2026

Uh oh!

openshift-ci bot commented Apr 8, 2026

Uh oh!

arkadeepsen commented Apr 8, 2026

Uh oh!

arkadeepsen commented Apr 8, 2026

Uh oh!

openshift-ci bot commented Apr 8, 2026

Uh oh!

openshift-ci bot commented Apr 10, 2026

Uh oh!

jluhrsen commented Apr 11, 2026

Uh oh!

openshift-ci-robot commented Apr 11, 2026

Uh oh!

arkadeepsen commented Apr 13, 2026

Uh oh!

openshift-ci-robot commented Apr 13, 2026

Uh oh!

openshift-ci bot commented Apr 13, 2026

Uh oh!

arkadeepsen commented Apr 13, 2026

Uh oh!

arkadeepsen commented Apr 13, 2026

Uh oh!

arkadeepsen commented Apr 13, 2026

Uh oh!

openshift-ci-robot commented Apr 13, 2026

Uh oh!

openshift-ci-robot commented Apr 13, 2026

Uh oh!

arkadeepsen commented Apr 13, 2026

Uh oh!

openshift-ci bot commented Apr 13, 2026

Uh oh!

kyrtapz commented Apr 14, 2026

Uh oh!

kyrtapz Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

arkadeepsen Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

kyrtapz commented Apr 14, 2026

Uh oh!

mkowalski commented Apr 14, 2026

Uh oh!

smg247 commented Apr 14, 2026

Uh oh!

openshift-ci bot commented Apr 14, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 14, 2026

Uh oh!

openshift-merge-robot commented Apr 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

arkadeepsen commented Apr 7, 2026 •

edited

Loading

coderabbitai bot commented Apr 7, 2026 •

edited

Loading