Skip to content

OSASINFRA-4209: Add openstack-test OTE#31214

Open
mandre wants to merge 1 commit into
openshift:mainfrom
shiftstack:openstack-test-ote
Open

OSASINFRA-4209: Add openstack-test OTE#31214
mandre wants to merge 1 commit into
openshift:mainfrom
shiftstack:openstack-test-ote

Conversation

@mandre
Copy link
Copy Markdown
Member

@mandre mandre commented May 26, 2026

Depends on openshift/openstack-test#262

Summary by CodeRabbit

  • Tests
    • Added a new extension test binary entry for enhanced testing capabilities.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 26, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 26, 2026

@mandre: This pull request references OSASINFRA-4209 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Depends on openshift/openstack-test#262

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0f50370a-a72a-46ef-9026-d181295981f6

📥 Commits

Reviewing files that changed from the base of the PR and between 1325193 and 454ad7c.

📒 Files selected for processing (1)
  • pkg/test/extensions/binary.go

Walkthrough

A new test binary entry is added to the extensionBinaries registry for the openstack-test image tag, pointing to the corresponding tar.gz archive path used by the extension binary testing infrastructure.

Changes

Test Binary Extension Configuration

Layer / File(s) Summary
OpenStack test extension binary entry
pkg/test/extensions/binary.go
The extensionBinaries registry is extended with a TestBinary configuration for the openstack-test image tag and its tar.gz archive path.

🎯 1 (Trivial) | ⏱️ ~2 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Ote Binary Stdout Contract ❓ Inconclusive PR only adds registry entry; actual binary code in openstack-test/pull/262 (external repo, not available here). Review openstack-test binary source for stdout writes in main(), init(), TestMain(), BeforeSuite(), AfterSuite(), or init code.
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title specifically references adding an openstack-test OTE (external extension test binary), which matches the primary change in the pull request that adds a new external extension test binary entry for the openstack-test image tag.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR adds only static configuration data to extensionBinaries registry; no Ginkgo test definitions created or modified, and no dynamic naming patterns introduced.
Test Structure And Quality ✅ Passed PR adds a data entry to a binary registry, not Ginkgo test code. The custom check targets test structure and applies only to test files with Ginkgo test definitions.
Microshift Test Compatibility ✅ Passed The PR adds only a registry entry for an external test binary, not Ginkgo test definitions. No new e2e tests with potentially MicroShift-incompatible APIs are defined in this file.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR adds one new Ginkgo e2e test (config_admission_test.go) that validates APIServer configuration through API calls only, with no multi-node cluster assumptions. SNO guards are not required.
Topology-Aware Scheduling Compatibility ✅ Passed Change is a test framework registry entry for a test binary, not deployment manifests, operator code, or controllers with scheduling constraints. No topology-aware scheduling concerns apply.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR adds only a registry entry for an external test binary, not Ginkgo e2e tests. The check requires "new Ginkgo e2e tests" which this PR does not contain.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label May 26, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@stephenfin
Copy link
Copy Markdown

/lgtm
/approve
/hold

Change itself looks fine. Obviously we need the dependent PRs to merge first though

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 26, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mandre, stephenfin
Once this PR has been reviewed and has the lgtm label, please assign petr-muller for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mandre
Copy link
Copy Markdown
Member Author

mandre commented May 27, 2026

/retest-required

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 27, 2026

@mandre: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial-1of2 454ad7c link true /test e2e-aws-ovn-serial-1of2
ci/prow/e2e-aws-ovn-microshift 454ad7c link true /test e2e-aws-ovn-microshift
ci/prow/e2e-aws-csi 454ad7c link true /test e2e-aws-csi
ci/prow/e2e-vsphere-ovn 454ad7c link true /test e2e-vsphere-ovn
ci/prow/e2e-aws-ovn-fips 454ad7c link true /test e2e-aws-ovn-fips
ci/prow/e2e-gcp-ovn 454ad7c link true /test e2e-gcp-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6 454ad7c link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-gcp-ovn-upgrade 454ad7c link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-aws-ovn-microshift-serial 454ad7c link true /test e2e-aws-ovn-microshift-serial
ci/prow/e2e-vsphere-ovn-upi 454ad7c link true /test e2e-vsphere-ovn-upi
ci/prow/e2e-gcp-csi 454ad7c link true /test e2e-gcp-csi
ci/prow/e2e-aws-ovn-serial-2of2 454ad7c link true /test e2e-aws-ovn-serial-2of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt
Copy link
Copy Markdown

openshift-trt Bot commented May 27, 2026

Job Failure Risk Analysis for sha: 454ad7c

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-csi IncompleteTests
Tests for this run (82) are below the historical average (2112): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-fips IncompleteTests
Tests for this run (81) are below the historical average (3816): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift IncompleteTests
Tests for this run (28) are below the historical average (1801): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial IncompleteTests
Tests for this run (29) are below the historical average (947): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 IncompleteTests
Tests for this run (82) are below the historical average (2110): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-2of2 IncompleteTests
Tests for this run (82) are below the historical average (2164): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-csi IncompleteTests
Tests for this run (79) are below the historical average (2110): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-ovn IncompleteTests
Tests for this run (79) are below the historical average (3898): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-ovn-upgrade IncompleteTests
Tests for this run (79) are below the historical average (2065): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6 IncompleteTests
Tests for this run (73) are below the historical average (2586): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-vsphere-ovn IncompleteTests
Tests for this run (76) are below the historical average (3690): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi IncompleteTests
Tests for this run (75) are below the historical average (3246): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants