Skip to content

Add CNO test extension binary#31218

Open
anuragthehatter wants to merge 1 commit into
openshift:mainfrom
anuragthehatter:cno-test-extension
Open

Add CNO test extension binary#31218
anuragthehatter wants to merge 1 commit into
openshift:mainfrom
anuragthehatter:cno-test-extension

Conversation

@anuragthehatter
Copy link
Copy Markdown

@anuragthehatter anuragthehatter commented May 27, 2026

Summary

  • Register the cluster-network-operator OTE binary in openshift-tests so it can discover and run CNO-specific e2e tests from the payload.

Based on openshift/cluster-network-operator#3015

Test plan

  • Verify openshift-tests discovers the CNO extension binary
  • Verify CNO e2e tests are listed and runnable

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Tests
    • Extended test infrastructure to support additional binary extraction from cluster-network-operator release payloads, improving test coverage capabilities.

Register the cluster-network-operator OTE binary so openshift-tests
can discover and run CNO-specific e2e tests from the payload.

Based on openshift/cluster-network-operator#3015

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 49b0d9b7-d7ea-4caf-98aa-d22f480f7f36

📥 Commits

Reviewing files that changed from the base of the PR and between 355916d and a289233.

📒 Files selected for processing (1)
  • pkg/test/extensions/binary.go

Walkthrough

This PR extends the external test binary registry in the test extensions module by adding a new mapping for the cluster-network-operator image, enabling extraction and processing of its test extension binary from the release payload.

Changes

Extension Binary Registry Update

Layer / File(s) Summary
cluster-network-operator test binary registration
pkg/test/extensions/binary.go
Added a TestBinary entry for cluster-network-operator that maps to the test extension binary path /usr/bin/cluster-network-operator-tests-ext.gz in the extensionBinaries registry.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add CNO test extension binary' directly and concisely describes the main change: registering a new external test binary mapping for the cluster-network-operator image.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR adds a static test binary registry entry with no Ginkgo test definitions. The change contains no dynamic test names or test code that could violate stability requirements.
Test Structure And Quality ✅ Passed The PR modifies test infrastructure configuration (a binary mapping registry), not Ginkgo test code. The custom check reviews test code quality patterns, which is not applicable here.
Microshift Test Compatibility ✅ Passed PR only registers external test binary; no Ginkgo e2e tests defined in this file, test code is external and loaded at runtime.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR adds binary mapping for CNO test extraction, not Ginkgo test code. Custom check requires "new Ginkgo e2e tests" (It/Describe/Context/When), which are not present in this PR.
Topology-Aware Scheduling Compatibility ✅ Passed Test binary mapping addition to test framework infrastructure. No deployment manifests, operators, controllers, or scheduling constraints—topology-aware check not applicable.
Ote Binary Stdout Contract ✅ Passed PR adds only a data structure declaration (TestBinary entry) with no init() functions, stdout writes, or process-level code that could corrupt OTE JSON output.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR adds a configuration entry to registry mapping image tag to test binary path. No Ginkgo test code is added in this file.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anuragthehatter
Once this PR has been reviewed and has the lgtm label, please assign sosiouxme for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from deads2k and sjenning May 27, 2026 02:30
@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label May 27, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 27, 2026

@anuragthehatter: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-csi a289233 link true /test e2e-gcp-csi
ci/prow/e2e-metal-ipi-ovn-ipv6 a289233 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-ovn-serial-1of2 a289233 link true /test e2e-aws-ovn-serial-1of2
ci/prow/e2e-aws-csi a289233 link true /test e2e-aws-csi
ci/prow/e2e-gcp-ovn a289233 link true /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-fips a289233 link true /test e2e-aws-ovn-fips
ci/prow/e2e-gcp-ovn-upgrade a289233 link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-aws-ovn-serial-2of2 a289233 link true /test e2e-aws-ovn-serial-2of2
ci/prow/e2e-aws-ovn-microshift a289233 link true /test e2e-aws-ovn-microshift
ci/prow/e2e-aws-ovn-microshift-serial a289233 link true /test e2e-aws-ovn-microshift-serial
ci/prow/e2e-vsphere-ovn-upi a289233 link true /test e2e-vsphere-ovn-upi
ci/prow/e2e-vsphere-ovn a289233 link true /test e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pperiyasamy
Copy link
Copy Markdown
Member

@anuragthehatter are you planning to test this PR with /testwith ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants