[release-4.21] Fix isNoOLMFeatureGateEnabled to check only the current cluster version

[gcs278]

Summary

• isNoOLMFeatureGateEnabled was iterating all version entries in status.featureGates, which after an upgrade includes entries for both old and new cluster versions
• This caused the function to incorrectly return true by finding GatewayAPIWithoutOLM enabled in the pre-upgrade version's entry, even when the current version has it disabled
• Fix: look up the current cluster version from ClusterVersion.status.desired.version and only check the matching featureGates entry
• Fixes the e2e-upgrade-out-of-change test failure for [release-4.21] OCPBUGS-88295, OCPBUGS-88297, OCPBUGS-82146, OCPBUGS-78330, OCPBUGS-85550: NE-2480: Promote GatewayAPIWithoutOLM feature gate to Default api#2865 where the test expected a sail finalizer that the CIO had already removed during the downgrade path

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0a27db01-6493-46e0-b798-cc753124a955

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gcs278

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• test/extended/router/OWNERS [gcs278]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gcs278]

Using the cherry-pick command just to be clean
/close

[openshift-ci]

@gcs278: Closed this PR.

Details

In response to this:

Using the cherry-pick command just to be clean
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.