ROSAENG-15779: New osdctl rhobs alerts subcommand (#923)

* ROSAENG-15779: making sure that json content retrieved from RHOBS is preserved

This allows json output format to view content not supported by the other output formats
Also making sure that the command original context is forwarded where needed

* ROSAENG-15779: most of the content of the cmd/rhobs/requests.go has been moved in the other files of the package in order to reduce the file size

* ROSAENG-15779: renaming some files in order standardize the file names in the package

* ROSAENG-15779: new `osdctl rhobs alerts` subcommand

* ROSAENG-15779: making sure the help is displayed for 'osdctl rhobs' commands on invalid arguments and flags

* ROSAENG-15779: there is now a default vault config for the 'osdctl rhobs' commands

Author: Nikokolas3270

cmd/rhobs/alerts_cmd.go

@@ -2,9 +2,7 @@ package rhobs
 
 import (
 	"fmt"
-	"os"
 
-	log "github.com/sirupsen/logrus"
 	"github.com/spf13/cobra"
 )
 
@@ -13,19 +11,12 @@ func newCmdCell() *cobra.Command {
 		Use:   "cell",
 		Short: "Get the RHOBS cell for a given cluster",
 		Args:  cobra.NoArgs,
-		Run: func(cmd *cobra.Command, args []string) {
-			cmd.SilenceUsage = true
-
-			metricsRhobsFetcher, logsRhobsFetcher, err := CreateMetricsAndLogsRhobsFetchers(commonOptions.clusterId, commonOptions.hiveOcmUrl)
-			if err != nil {
-				log.Errorf("Error while computing RHOBS cells: %v", err)
-				os.Exit(1)
-			}
-
+		RunE: func(cmd *cobra.Command, args []string) error {
+			metricsRhobsFetcher, logsRhobsFetcher, err := CreateMetricsAndLogsRhobsFetchers(cmd.Context(), commonOptions.clusterId, commonOptions.hiveOcmUrl)
 			if metricsRhobsFetcher != nil {
 				if logsRhobsFetcher != nil && metricsRhobsFetcher.RhobsCell == logsRhobsFetcher.RhobsCell {
 					fmt.Println("Metrics & logs RHOBS cell:", metricsRhobsFetcher.RhobsCell)
-					return
+					return err
 				}
 
 				fmt.Println("Metrics RHOBS cell:", metricsRhobsFetcher.RhobsCell)
@@ -34,6 +25,8 @@ func newCmdCell() *cobra.Command {
 			if logsRhobsFetcher != nil {
 				fmt.Println("Logs RHOBS cell   :", logsRhobsFetcher.RhobsCell)
 			}
+
+			return err
 		},
 	}