Merge pull request #370 from sdodson/fail_on_puppet_lint_warnings

Make puppet-lint warnings failures

Author: sdodson

Rakefile

@@ -4,7 +4,7 @@ require 'puppet-syntax/tasks/puppet-syntax'
 
 # puppet-lint parameters per puppet approved criteria
 # https://forge.puppetlabs.com/approved/criteria#validation
-PuppetLint.configuration.fail_on_warnings
+PuppetLint.configuration.fail_on_warnings = true
 PuppetLint.configuration.send("disable_80chars")
 PuppetLint.configuration.send("relative")
 # http://puppet-lint.com/checks/class_inherits_from_params_class/

manifests/register_dns.pp

@@ -48,8 +48,8 @@
       }
     }
   } elsif $::openshift_origin::register_host_with_nameserver and $::openshift_origin::bind_krb_principal != '' {
-    warning "You cannot use register_host_with_nameserver when using GSS-TSIG DNS updates"
-    fail "You cannot use register_host_with_nameserver when using GSS-TSIG DNS updates"
+    warning 'You cannot use register_host_with_nameserver when using GSS-TSIG DNS updates'
+    fail 'You cannot use register_host_with_nameserver when using GSS-TSIG DNS updates'
   }
 
 }