Refactor openshift e2e aws capi workflow (#78001)

* Add openshift-oc-wait-for-stable-cluster step to step-registry

Configurable wrapper around oc adm wait-for-stable-cluster for use as a
reusable step in CI workflows. Supports MINIMUM_STABLE_PERIOD and TIMEOUT
env vars. Intended for use after cluster state changes such as enabling
FeatureSets post-install.

* Update openshift-e2e-aws-capi workflow to use shared steps

Replace capi-conf-apply-feature-gate with ipi-install-post-featureset
and openshift-oc-wait-for-stable-cluster. This uses the standard
post-install FeatureSet enablement step and a proper cluster stability
check instead of a custom script with hand-rolled operator waits.

* Rename openshift-e2e-aws-capi workflow to openshift-e2e-aws-techpreview-post-install

The old name implied this was CAPI-specific, but the workflow actually
tests the day-1 TechPreview enablement path on a standard AWS cluster.
The new name clearly distinguishes it from the day-0 variant
(openshift-e2e-aws-techpreview) which installs with TechPreview from
the start.

* Rename cluster-machine-approver e2e-aws-capi-techpreview to e2e-aws-techpreview-post-install

Align the job name with the renamed workflow. The test enables
TechPreview post-install, not CAPI specifically.

* Keep openshift-e2e-aws-capi workflow for releases 4.11-4.13

Releases 4.11-4.13 use a CLI that may not include oc adm
wait-for-stable-cluster, so keep them on the original
openshift-e2e-aws-capi workflow with capi-conf-apply-feature-gate.

Also add a runtime check to openshift-oc-wait-for-stable-cluster to
fail gracefully when the subcommand is not available.

Author: damdo

ci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.14.yaml

@@ -46,7 +46,7 @@ tests:
   skip_if_only_changed: ^docs/|\.md$|^(?:.*/)?(?:\.gitignore|OWNERS|PROJECT|LICENSE)$
   steps:
     cluster_profile: openshift-org-aws
-    workflow: openshift-e2e-aws-capi
+    workflow: openshift-e2e-aws-techpreview-post-install
 - as: e2e-gcp-ovn-techpreview
   skip_if_only_changed: ^docs/|\.md$|^(?:.*/)?(?:\.gitignore|OWNERS|PROJECT|LICENSE)$
   steps:

ci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.15.yaml

@@ -45,7 +45,7 @@ tests:
   skip_if_only_changed: ^docs/|\.md$|^(?:.*/)?(?:\.gitignore|OWNERS|PROJECT|LICENSE)$
   steps:
     cluster_profile: openshift-org-aws
-    workflow: openshift-e2e-aws-capi
+    workflow: openshift-e2e-aws-techpreview-post-install
 - as: e2e-gcp-ovn-techpreview
   skip_if_only_changed: ^docs/|\.md$|^(?:.*/)?(?:\.gitignore|OWNERS|PROJECT|LICENSE)$
   steps:

ci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.16.yaml

@@ -42,7 +42,7 @@ tests:
   skip_if_only_changed: ^docs/|\.md$|^(?:.*/)?(?:\.gitignore|OWNERS|PROJECT|LICENSE)$
   steps:
     cluster_profile: openshift-org-aws
-    workflow: openshift-e2e-aws-capi
+    workflow: openshift-e2e-aws-techpreview-post-install
 - as: e2e-gcp-ovn-techpreview
   skip_if_only_changed: ^docs/|\.md$|^(?:.*/)?(?:\.gitignore|OWNERS|PROJECT|LICENSE)$
   steps:

ci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.17.yaml

@@ -42,7 +42,7 @@ tests:
   skip_if_only_changed: ^docs/|\.md$|^(?:.*/)?(?:\.gitignore|OWNERS|PROJECT|LICENSE)$
   steps:
     cluster_profile: openshift-org-aws
-    workflow: openshift-e2e-aws-capi
+    workflow: openshift-e2e-aws-techpreview-post-install
 - as: e2e-gcp-ovn-techpreview
   skip_if_only_changed: ^docs/|\.md$|^(?:.*/)?(?:\.gitignore|OWNERS|PROJECT|LICENSE)$
   steps:

ci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.18.yaml

@@ -42,7 +42,7 @@ tests:
   skip_if_only_changed: ^docs/|\.md$|^(?:.*/)?(?:\.gitignore|OWNERS|PROJECT|LICENSE)$
   steps:
     cluster_profile: openshift-org-aws
-    workflow: openshift-e2e-aws-capi
+    workflow: openshift-e2e-aws-techpreview-post-install
 - as: e2e-gcp-ovn-techpreview
   skip_if_only_changed: ^docs/|\.md$|^(?:.*/)?(?:\.gitignore|OWNERS|PROJECT|LICENSE)$
   steps:

ci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.19.yaml

@@ -42,7 +42,7 @@ tests:
   skip_if_only_changed: ^docs/|\.md$|^(?:.*/)?(?:\.gitignore|OWNERS|PROJECT|LICENSE)$
   steps:
     cluster_profile: openshift-org-aws
-    workflow: openshift-e2e-aws-capi
+    workflow: openshift-e2e-aws-techpreview-post-install
 - as: e2e-gcp-ovn-techpreview
   skip_if_only_changed: ^docs/|\.md$|^(?:.*/)?(?:\.gitignore|OWNERS|PROJECT|LICENSE)$
   steps:

ci-operator/config/openshift-priv/cluster-api-operator/openshift-priv-cluster-api-operator-release-4.20.yaml

@@ -42,7 +42,7 @@ tests:
   skip_if_only_changed: ^docs/|\.md$|^(?:.*/)?(?:\.gitignore|OWNERS|PROJECT|LICENSE)$
   steps:
     cluster_profile: openshift-org-aws
-    workflow: openshift-e2e-aws-capi
+    workflow: openshift-e2e-aws-techpreview-post-install
 - as: e2e-gcp-ovn-techpreview
   skip_if_only_changed: ^docs/|\.md$|^(?:.*/)?(?:\.gitignore|OWNERS|PROJECT|LICENSE)$
   steps:

ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-main.yaml

@@ -92,11 +92,11 @@ tests:
   steps:
     cluster_profile: openshift-org-aws
     workflow: openshift-upgrade-aws
-- as: e2e-aws-capi-techpreview
+- as: e2e-aws-techpreview-post-install
   skip_if_only_changed: ^docs/|\.md$|^(?:.*/)?(?:\.gitignore|OWNERS|PROJECT|LICENSE)$
   steps:
     cluster_profile: openshift-org-aws
-    workflow: openshift-e2e-aws-capi
+    workflow: openshift-e2e-aws-techpreview-post-install
 - as: e2e-hypershift-aws
   skip_if_only_changed: ^docs/|\.md$|^(?:.*/)?(?:\.gitignore|OWNERS|PROJECT|LICENSE)$
   steps:

ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.11.yaml

@@ -89,7 +89,7 @@ tests:
   steps:
     cluster_profile: openshift-org-aws
     workflow: openshift-e2e-aws-disruption
-- as: e2e-aws-capi-techpreview
+- as: e2e-aws-techpreview-post-install
   steps:
     cluster_profile: openshift-org-aws
     workflow: openshift-e2e-aws-capi

ci-operator/config/openshift-priv/cluster-machine-approver/openshift-priv-cluster-machine-approver-release-4.12.yaml

@@ -83,7 +83,7 @@ tests:
   steps:
     cluster_profile: openshift-org-aws
     workflow: openshift-upgrade-aws
-- as: e2e-aws-capi-techpreview
+- as: e2e-aws-techpreview-post-install
   steps:
     cluster_profile: openshift-org-aws
     workflow: openshift-e2e-aws-capi