Skip to content

add custom credencials to codeready-toolchain-toolchain-e2e-master.yaml#68811

Merged
openshift-merge-bot[bot] merged 4 commits intoopenshift:masterfrom
rsoaresd:add_custom_creds
Sep 4, 2025
Merged

add custom credencials to codeready-toolchain-toolchain-e2e-master.yaml#68811
openshift-merge-bot[bot] merged 4 commits intoopenshift:masterfrom
rsoaresd:add_custom_creds

Conversation

@rsoaresd
Copy link
Copy Markdown
Contributor

@rsoaresd rsoaresd commented Sep 3, 2025 •
edited
Loading

Description

For now, we will only enable the Developer Sandbox UI E2E tests on toolchain-e2e. When running them, we need specific qe secrets (SSO_USERNAME and SSO_PASSWORD) that the tests cluster should have. For more details, check codeready-toolchain/toolchain-e2e#1180

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2025
@openshift-ci openshift-ci Bot requested review from mfrancisc and xcoulon September 3, 2025 11:33
@deepsm007
Copy link
Copy Markdown
Contributor

deepsm007 commented Sep 3, 2025

/pj-rehearse pull-ci-codeready-toolchain-toolchain-e2e-master-e2e

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 3, 2025

@deepsm007: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 3, 2025

[REHEARSALNOTIFIER]
@rsoaresd: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-codeready-toolchain-toolchain-e2e-master-e2e codeready-toolchain/toolchain-e2e presubmit Ci-operator config changed
periodic-ci-codeready-toolchain-toolchain-e2e-master-ci-daily N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@rsoaresd
Copy link
Copy Markdown
Contributor Author

rsoaresd commented Sep 3, 2025

/pj-rehearse pull-ci-codeready-toolchain-toolchain-e2e-master-e2e

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 3, 2025

@rsoaresd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

rsoaresd
rsoaresd commented Sep 3, 2025
View reviewed changes
Comment thread ...rator/config/codeready-toolchain/toolchain-e2e/codeready-toolchain-toolchain-e2e-master.yaml
credentials:
- collection: ""
mount_path: /usr/local/sandbox-secrets
name: sandbox-devsso
Copy link
Copy Markdown
Contributor Author

@rsoaresd rsoaresd Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the name of the secret created on selfservice/sandbox-secrets/sandbox-devsso

@rsoaresd rsoaresd changed the title add custom creds to codeready-toolchain-toolchain-e2e-master.yaml add custom credencials to codeready-toolchain-toolchain-e2e-master.yaml Sep 4, 2025
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2025
@xcoulon
Copy link
Copy Markdown
Contributor

xcoulon commented Sep 4, 2025

/lgtm

mfrancisc
mfrancisc approved these changes Sep 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fbm3307, mfrancisc, rsoaresd, xcoulon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rsoaresd
Copy link
Copy Markdown
Contributor Author

rsoaresd commented Sep 4, 2025

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 4, 2025

@rsoaresd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 4, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 4, 2025

@rsoaresd: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit b6c97b7 into openshift:master Sep 4, 2025
15 checks passed
xiaojiey pushed a commit to xiaojiey/release that referenced this pull request Sep 25, 2025
@rsoaresd @xiaojiey
add custom credencials to codeready-toolchain-toolchain-e2e-master.ya…
b851be1 
…ml (openshift#68811)

* add custom creds

* fix

* fix

* fix

---------

Co-authored-by: KubeSaw <devsandbox@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@xcoulon xcoulon xcoulon approved these changes

@mfrancisc mfrancisc mfrancisc approved these changes

@fbm3307 fbm3307 fbm3307 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@xcoulon xcoulon

@mfrancisc mfrancisc

@fbm3307 fbm3307

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rsoaresd @deepsm007 @openshift-ci-robot @xcoulon @mfrancisc @fbm3307