(round 2) Fix GCP permissions for cri-o workflows by removing hardcod… by haircommander · Pull Request #77990 · openshift/release

haircommander · 2026-04-17T19:39:11Z

…ed cluster profiles

commit 465cd3d partially fixed this problem, and the canary runs seem good let's do the same for the rest

Summary by CodeRabbit

Chores
- Updated 16 workflow configurations across multiple test pipelines to remove cluster profile specifications.

…ed cluster profiles commit 465cd3d partially fixed this problem, and the canary runs seem good let's do the same for the rest Signed-off-by: Peter Hunt <pehunt@redhat.com>

haircommander · 2026-04-17T19:39:31Z

/pj-rehearse max
/pj-rehearse auto-ack

openshift-merge-bot · 2026-04-17T19:39:34Z

@haircommander: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

coderabbitai · 2026-04-17T19:39:58Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b47d9449-48af-4ecb-8c33-20d54abaec6d

📥 Commits

Reviewing files that changed from the base of the PR and between 2b7f094 and 5d43b29.

📒 Files selected for processing (16)

ci-operator/step-registry/cri-o/cgroupv2/e2e-crun/cri-o-cgroupv2-e2e-crun-workflow.yaml
ci-operator/step-registry/cri-o/cgroupv2/e2e-features/cri-o-cgroupv2-e2e-features-workflow.yaml
ci-operator/step-registry/cri-o/cgroupv2/e2e/cri-o-cgroupv2-e2e-workflow.yaml
ci-operator/step-registry/cri-o/cgroupv2/integration/cri-o-cgroupv2-integration-workflow.yaml
ci-operator/step-registry/cri-o/crun/e2e/cri-o-crun-e2e-workflow.yaml
ci-operator/step-registry/cri-o/crun/integration/cri-o-crun-integration-workflow.yaml
ci-operator/step-registry/cri-o/fedora/critest/cri-o-fedora-critest-workflow.yaml
ci-operator/step-registry/cri-o/fedora/e2e/cri-o-fedora-e2e-workflow.yaml
ci-operator/step-registry/cri-o/fedora/integration/cri-o-fedora-integration-workflow.yaml
ci-operator/step-registry/cri-o/fedora/kata/cri-o-fedora-kata-workflow.yaml
ci-operator/step-registry/cri-o/node/e2e/conformance/cri-o-node-e2e-conformance-workflow.yaml
ci-operator/step-registry/cri-o/node/e2e/nodeconformance/cri-o-node-e2e-nodeconformance-workflow.yaml
ci-operator/step-registry/cri-o/node/e2e/nodefeature/cri-o-node-e2e-nodefeature-workflow.yaml
ci-operator/step-registry/cri-o/rhel/critest/cri-o-rhel-critest-workflow.yaml
ci-operator/step-registry/cri-o/rhel/e2e/cri-o-rhel-e2e-workflow.yaml
ci-operator/step-registry/cri-o/rhel/integration/cri-o-rhel-integration-workflow.yaml

💤 Files with no reviewable changes (16)

ci-operator/step-registry/cri-o/fedora/e2e/cri-o-fedora-e2e-workflow.yaml
ci-operator/step-registry/cri-o/crun/e2e/cri-o-crun-e2e-workflow.yaml
ci-operator/step-registry/cri-o/node/e2e/conformance/cri-o-node-e2e-conformance-workflow.yaml
ci-operator/step-registry/cri-o/fedora/critest/cri-o-fedora-critest-workflow.yaml
ci-operator/step-registry/cri-o/fedora/kata/cri-o-fedora-kata-workflow.yaml
ci-operator/step-registry/cri-o/node/e2e/nodefeature/cri-o-node-e2e-nodefeature-workflow.yaml
ci-operator/step-registry/cri-o/rhel/critest/cri-o-rhel-critest-workflow.yaml
ci-operator/step-registry/cri-o/crun/integration/cri-o-crun-integration-workflow.yaml
ci-operator/step-registry/cri-o/cgroupv2/integration/cri-o-cgroupv2-integration-workflow.yaml
ci-operator/step-registry/cri-o/cgroupv2/e2e/cri-o-cgroupv2-e2e-workflow.yaml
ci-operator/step-registry/cri-o/cgroupv2/e2e-features/cri-o-cgroupv2-e2e-features-workflow.yaml
ci-operator/step-registry/cri-o/rhel/e2e/cri-o-rhel-e2e-workflow.yaml
ci-operator/step-registry/cri-o/fedora/integration/cri-o-fedora-integration-workflow.yaml
ci-operator/step-registry/cri-o/node/e2e/nodeconformance/cri-o-node-e2e-nodeconformance-workflow.yaml
ci-operator/step-registry/cri-o/cgroupv2/e2e-crun/cri-o-cgroupv2-e2e-crun-workflow.yaml
ci-operator/step-registry/cri-o/rhel/integration/cri-o-rhel-integration-workflow.yaml

Walkthrough

This PR removes the cluster_profile: [gcp-3](https://redhat.atlassian.net/browse/gcp-3) configuration setting from the steps section across 16 CRI-O workflow YAML files. All referenced pre, test, post, and env step definitions remain unchanged; only the explicit cluster profile specification is removed.

Changes

Cohort / File(s)	Summary
CRI-O CGROUPv2 Workflows `ci-operator/step-registry/cri-o/cgroupv2/e2e-crun/-workflow.yaml`, `ci-operator/step-registry/cri-o/cgroupv2/e2e-features/-workflow.yaml`, `ci-operator/step-registry/cri-o/cgroupv2/e2e/-workflow.yaml`, `ci-operator/step-registry/cri-o/cgroupv2/integration/-workflow.yaml`	Removed `cluster_profile: [gcp-3](https://redhat.atlassian.net/browse/gcp-3)` from workflow steps configuration.
CRI-O CRUN Workflows `ci-operator/step-registry/cri-o/crun/e2e/-workflow.yaml`, `ci-operator/step-registry/cri-o/crun/integration/-workflow.yaml`	Removed `cluster_profile: [gcp-3](https://redhat.atlassian.net/browse/gcp-3)` from workflow steps configuration.
CRI-O Fedora Workflows `ci-operator/step-registry/cri-o/fedora/critest/-workflow.yaml`, `ci-operator/step-registry/cri-o/fedora/e2e/-workflow.yaml`, `ci-operator/step-registry/cri-o/fedora/integration/-workflow.yaml`, `ci-operator/step-registry/cri-o/fedora/kata/-workflow.yaml`	Removed `cluster_profile: [gcp-3](https://redhat.atlassian.net/browse/gcp-3)` from workflow steps configuration.
CRI-O Node E2E Workflows `ci-operator/step-registry/cri-o/node/e2e/conformance/-workflow.yaml`, `ci-operator/step-registry/cri-o/node/e2e/nodeconformance/-workflow.yaml`, `ci-operator/step-registry/cri-o/node/e2e/nodefeature/*-workflow.yaml`	Removed `cluster_profile: [gcp-3](https://redhat.atlassian.net/browse/gcp-3)` from workflow steps configuration.
CRI-O RHEL Workflows `ci-operator/step-registry/cri-o/rhel/critest/-workflow.yaml`, `ci-operator/step-registry/cri-o/rhel/e2e/-workflow.yaml`, `ci-operator/step-registry/cri-o/rhel/integration/*-workflow.yaml`	Removed `cluster_profile: [gcp-3](https://redhat.atlassian.net/browse/gcp-3)` from workflow steps configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 10

✅ Passed checks (10 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately describes the main change: removing hardcoded cluster profiles (specifically gcp-3) from cri-o workflows to fix GCP permissions issues.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names	✅ Passed	This PR only modifies YAML workflow configuration files in ci-operator/step-registry/cri-o/, not Go test files containing Ginkgo test definitions.
Test Structure And Quality	✅ Passed	The PR modifies only YAML workflow configuration files in ci-operator/step-registry/cri-o/, removing cluster profile settings. No Ginkgo test code or Go test files are present or modified.
Microshift Test Compatibility	✅ Passed	PR modifies only CI/CD workflow configuration files with no new Ginkgo e2e test code added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only modifies CI/CD workflow configuration files; no new Ginkgo e2e tests are being added, so SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility	✅ Passed	Changes are CI infrastructure workflow configuration files that remove hardcoded cluster profile references, not deployment manifests or controllers that introduce Kubernetes scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	PR modifies only YAML workflow configuration files, not executable code, making the OTE Binary Stdout Contract check inapplicable.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR modifies only CI workflow YAML files, removing cluster_profile settings. No new Ginkgo e2e tests are added.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-merge-bot · 2026-04-17T19:42:31Z

[REHEARSALNOTIFIER]
@haircommander: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-cri-o-cri-o-main-ci-cgroupv2-e2e	cri-o/cri-o	presubmit	Registry content changed
pull-ci-cri-o-cri-o-main-ci-cgroupv2-e2e-crun	cri-o/cri-o	presubmit	Registry content changed
pull-ci-cri-o-cri-o-main-ci-cgroupv2-e2e-features	cri-o/cri-o	presubmit	Registry content changed
pull-ci-cri-o-cri-o-main-ci-cgroupv2-integration	cri-o/cri-o	presubmit	Registry content changed
pull-ci-cri-o-cri-o-main-ci-crun-e2e	cri-o/cri-o	presubmit	Registry content changed
pull-ci-cri-o-cri-o-main-ci-fedora-critest	cri-o/cri-o	presubmit	Registry content changed
pull-ci-cri-o-cri-o-main-ci-fedora-integration	cri-o/cri-o	presubmit	Registry content changed
pull-ci-cri-o-cri-o-main-ci-fedora-kata	cri-o/cri-o	presubmit	Registry content changed
pull-ci-cri-o-cri-o-main-ci-rhel-critest	cri-o/cri-o	presubmit	Registry content changed
pull-ci-cri-o-cri-o-main-ci-rhel-e2e	cri-o/cri-o	presubmit	Registry content changed
periodic-ci-cri-o-cri-o-main-periodics-crio-node-e2e-conformance-periodic	N/A	periodic	Registry content changed
periodic-ci-cri-o-cri-o-main-periodics-crio-node-e2e-nodeconformance-periodic	N/A	periodic	Registry content changed
periodic-ci-cri-o-cri-o-main-periodics-crio-node-e2e-nodefeature-periodic	N/A	periodic	Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

openshift-merge-bot · 2026-04-17T19:43:03Z

@haircommander: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

kannon92

/lgtm
/approve

kannon92 · 2026-04-17T20:50:04Z

/hold

Guess testing is still going on on this.

openshift-ci · 2026-04-17T20:50:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/step-registry/cri-o/cgroupv2/e2e/OWNERS~~ [haircommander]
~~ci-operator/step-registry/cri-o/cgroupv2/e2e-crun/OWNERS~~ [haircommander]
~~ci-operator/step-registry/cri-o/cgroupv2/e2e-features/OWNERS~~ [haircommander]
~~ci-operator/step-registry/cri-o/cgroupv2/integration/OWNERS~~ [haircommander]
~~ci-operator/step-registry/cri-o/crun/e2e/OWNERS~~ [haircommander]
~~ci-operator/step-registry/cri-o/crun/integration/OWNERS~~ [haircommander]
~~ci-operator/step-registry/cri-o/fedora/critest/OWNERS~~ [haircommander]
~~ci-operator/step-registry/cri-o/fedora/e2e/OWNERS~~ [haircommander]
~~ci-operator/step-registry/cri-o/fedora/integration/OWNERS~~ [haircommander]
~~ci-operator/step-registry/cri-o/fedora/kata/OWNERS~~ [haircommander]
~~ci-operator/step-registry/cri-o/node/e2e/conformance/OWNERS~~ [haircommander]
~~ci-operator/step-registry/cri-o/node/e2e/nodeconformance/OWNERS~~ [haircommander]
~~ci-operator/step-registry/cri-o/node/e2e/nodefeature/OWNERS~~ [haircommander]
~~ci-operator/step-registry/cri-o/rhel/critest/OWNERS~~ [haircommander]
~~ci-operator/step-registry/cri-o/rhel/e2e/OWNERS~~ [haircommander]
~~ci-operator/step-registry/cri-o/rhel/integration/OWNERS~~ [haircommander]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-04-17T21:37:29Z

@haircommander: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/cri-o/cri-o/main/ci-cgroupv2-e2e	`5d43b29`	link	unknown	`/pj-rehearse pull-ci-cri-o-cri-o-main-ci-cgroupv2-e2e`
ci/rehearse/periodic-ci-cri-o-cri-o-main-periodics-crio-node-e2e-nodeconformance-periodic	`5d43b29`	link	unknown	`/pj-rehearse periodic-ci-cri-o-cri-o-main-periodics-crio-node-e2e-nodeconformance-periodic`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

haircommander · 2026-04-17T23:06:30Z

/pj-rehearse ci-cgroupv2-e2e

openshift-merge-bot · 2026-04-17T23:06:34Z

@haircommander: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-merge-bot · 2026-04-17T23:09:33Z

@haircommander: job(s): ci-cgroupv2-e2e either don't exist or were not found to be affected, and cannot be rehearsed

haircommander · 2026-04-17T23:10:58Z

/pj-rehearse pull-ci-cri-o-cri-o-main-ci-cgroupv2-e2e

haircommander · 2026-04-21T16:30:23Z

cgroupv2-e2e still seems to fail the same but the rest are better, I'm gona merge this and potentially we need to keep iterating
/unhold
/pj-rehearse ack

openshift-merge-bot · 2026-04-21T16:30:26Z

@haircommander: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

(round 2) Fix GCP permissions for cri-o workflows by removing hardcod…

5d43b29

…ed cluster profiles commit 465cd3d partially fixed this problem, and the canary runs seem good let's do the same for the rest Signed-off-by: Peter Hunt <pehunt@redhat.com>

openshift-ci Bot requested review from QiWang19 and hasan4791 April 17, 2026 19:39

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2026

kannon92 reviewed Apr 17, 2026

View reviewed changes

openshift-ci Bot assigned kannon92 Apr 17, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2026

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2026

openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 21, 2026

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2026

openshift-merge-bot Bot merged commit 5f532c7 into openshift:main Apr 21, 2026
22 of 24 checks passed

Conversation

haircommander commented Apr 17, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

haircommander commented Apr 17, 2026

Uh oh!

openshift-merge-bot Bot commented Apr 17, 2026

Uh oh!

coderabbitai Bot commented Apr 17, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

openshift-merge-bot Bot commented Apr 17, 2026

Uh oh!

openshift-merge-bot Bot commented Apr 17, 2026

Uh oh!

kannon92 left a comment

Choose a reason for hiding this comment

Uh oh!

kannon92 commented Apr 17, 2026

Uh oh!

openshift-ci Bot commented Apr 17, 2026

Uh oh!

openshift-ci Bot commented Apr 17, 2026

Uh oh!

haircommander commented Apr 17, 2026

Uh oh!

openshift-merge-bot Bot commented Apr 17, 2026

Uh oh!

openshift-merge-bot Bot commented Apr 17, 2026

Uh oh!

haircommander commented Apr 17, 2026

Uh oh!

haircommander commented Apr 21, 2026

Uh oh!

openshift-merge-bot Bot commented Apr 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

haircommander commented Apr 17, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 17, 2026 •

edited by openshift-ci Bot

Loading