ci-operator/jobs/Azure/ARO-RP/Azure-ARO-RP-master-presubmits.yaml (1)

1-637: Prowgen-generated file—recommend regenerating via standard flow.

This file carries the ci.openshift.io/generator: prowgen label and is intended to be regenerated from the ci-operator config rather than hand-edited. Verification confirms the seven test targets in the config (e2e-parallel-csp, integration-e2e-parallel-csp, integration-e2e-parallel-miwi, prod-e2e-parallel-csp, prod-e2e-parallel-miwi, stage-e2e-parallel-csp, stage-e2e-parallel-miwi) all have matching presubmits with correct --target values, trigger patterns, and optional/always_run flags.

The Boskos resource types aro-classic-test-msi-containers-{int,stg,prod} required by the MIWI variants are already declared in core-services/prow/02_config/_boskos.yaml with 50 numbered instances (0–49) each.

Regenerate this file via make jobs or ci-operator-prowgen to ensure byte-for-byte consistency with the canonical config and to guarantee any additional fields (e.g., max_concurrency, pathAlias) are included if defined upstream.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@ci-operator/jobs/Azure/ARO-RP/Azure-ARO-RP-master-presubmits.yaml` around
lines 1 - 637, This file is prowgen-generated and should not be hand-edited;
regenerate it to restore canonical output: run the standard generation flow
(e.g. make jobs or ci-operator-prowgen) to recreate Azure/ARO-RP presubmits so
that the ci.openshift.io/generator: prowgen label, the seven targets
(e2e-parallel-csp, integration-e2e-parallel-csp, integration-e2e-parallel-miwi,
prod-e2e-parallel-csp, prod-e2e-parallel-miwi, stage-e2e-parallel-csp,
stage-e2e-parallel-miwi), their --target args, trigger regexes,
optional/always_run flags, and any missing fields like max_concurrency or
pathAlias match the canonical ci-operator config and the Boskos resource
declarations.

ci-operator/step-registry/aro-classic/test/persistent/aro-classic-test-persistent-ref.yaml (1)

18-23: Use block scalar for consistency and add the new sentence under the correct key.

The added sentence on Line 19 is implicitly folded into the documentation plain scalar of MULTISTAGE_PARAM_OVERRIDE_LOCATION via YAML line-continuation. It works, but it's inconsistent with the |- block scalars used for LOCATION and the newly added E2E_TYPE, and the continuation indent makes the ownership of the sentence easy to misread. The E2E_TYPE entry itself looks good (default "csp" aligns with the behavior in aro-classic-test-persistent-commands.sh Line 23).

🧹 Suggested formatting tweak

     - name: MULTISTAGE_PARAM_OVERRIDE_LOCATION
       default: ""
-      documentation: Overrides LOCATION via Gangway API.
-        That way we can have tests that choose different locations.
+      documentation: |-
+        Overrides LOCATION via Gangway API.
+        That way we can have tests that choose different locations.
     - name: E2E_TYPE
       default: "csp"
       documentation: |-
         Type of end-to-end test to run.  For example, "csp" or "miwi".

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@ci-operator/step-registry/aro-classic/test/persistent/aro-classic-test-persistent-ref.yaml`
around lines 18 - 23, The documentation scalar for
MULTISTAGE_PARAM_OVERRIDE_LOCATION should use a block scalar (|-) like LOCATION
and E2E_TYPE to avoid accidental line-folding and make ownership clear; update
the MULTISTAGE_PARAM_OVERRIDE_LOCATION entry so its documentation value is
written with |- and move the added sentence onto its own indented line under
that key, ensuring E2E_TYPE remains a separate top-level mapping with its
default "csp" and documentation block intact.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes